From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id E9D1D3858414 for ; Fri, 10 Feb 2023 17:07:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9D1D3858414 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 56E7C1004B4FC for ; Fri, 10 Feb 2023 17:07:37 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id QWs5pJlgOVjzQQWs5pUPht; Fri, 10 Feb 2023 17:07:37 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=bt2JuGWi c=1 sm=1 tr=0 ts=63e679d9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=O_s_lzHhvBWfqt3gkowA:9 a=7Zwj6sZBwVKJAoWSPKxL6X1jA+E=:19 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yzRyCkcaAZICcMQ0C8o+kl/tJeQFzSi7vlrLYTnqzMc=; b=iMwYpBt276jJBS+hLNJ6ifbIR2 lkW0o3wgp3vQDPZS0lltaOPjYr5rpl9zWyIr1P3V4bLjrff0MW3+71T7/+Dmhs1gwIqncShO6/RIX ZqZ83bWEcqcTs60MWInxWT/8m; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:45310 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pQWs5-000k1H-31; Fri, 10 Feb 2023 10:07:37 -0700 From: Tom Tromey To: Simon Sobisch via Gdb Cc: Simon Sobisch Subject: Re: How to adjust the lexer used by pygments highlighting References: <9aa7a6cf-93f8-3a96-c99f-3f9a71e41333@gnu.org> X-Attribution: Tom Date: Fri, 10 Feb 2023 10:07:32 -0700 In-Reply-To: <9aa7a6cf-93f8-3a96-c99f-3f9a71e41333@gnu.org> (Simon Sobisch via Gdb's message of "Sun, 22 Jan 2023 15:30:19 +0100") Message-ID: <87fsbdxxd7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pQWs5-000k1H-31 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:45310 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Sobisch via Gdb writes: Simon> The highlighting via pygments actually works quite fine in general, Simon> but in some cases it uses the wrong lexer and then has bad results. Simon> It _seems_ that pygments' "filename (extension) based" language lookup Simon> is not used, because tested files using `pygmentize` are always well Simon> colored, the ones in GDB sometimes use the wrong lexer. Simon> Question: How can we adjust the lexer used by pygments syntax Simon> higlighting in GDB for a given file? There's no customization to be done here, as far as I know, but the code is in gdb/python/lib/gdb/styling.py. Simon> Is it possible to setup a filename extension-based selection when GDB Simon> does not know of the language ("set language " _seems_ to have no Simon> effect on highlighting, but that would only work if the language is Simon> known to GDB)? If not can the "normal" extension list [1] be added to Simon> GDB or the decision which lexer to be used passed on to pygments? >From what I can see it does appear to use just the filename and not the current language: def colorize(filename, contents): # Don't want any errors. try: lexer = lexers.get_lexer_for_filename(filename, stripnl=False) formatter = get_formatter() return highlight(contents, lexer, formatter).encode( gdb.host_charset(), "backslashreplace" ) except: return None We're definitely open to accepting improvements here. One thing is to be sure you're using pygments and not Source Highlight. Tom