From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id F11C53857C6F; Sat, 3 Oct 2020 06:28:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F11C53857C6F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=whitebox@nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C3H3d2TNnz1rsNT; Sat, 3 Oct 2020 08:27:57 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C3H3d25mVz1qtwm; Sat, 3 Oct 2020 08:27:57 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id eYmYT1N3ui9n; Sat, 3 Oct 2020 08:27:56 +0200 (CEST) X-Auth-Info: QYEWF2Dpp0wcMQ7OpVn5d5osW9KRJDtwCdgSP/WfzsdI/SOToC0FU3iDQozYClfH Received: from hase.home (ppp-46-244-163-67.dynamic.mnet-online.de [46.244.163.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 3 Oct 2020 08:27:56 +0200 (CEST) Received: by hase.home (Postfix, from userid 1000) id 1BCAA1027F5; Sat, 3 Oct 2020 08:27:54 +0200 (CEST) From: Andreas Schwab To: "H.J. Lu via Binutils" Cc: GDB , "H.J. Lu" Subject: Re: Does "git bisect" work for anyone? References: X-Yow: It's a lot of fun being alive... I wonder if my bed is made?!? Date: Sat, 03 Oct 2020 08:27:54 +0200 In-Reply-To: (H. J. Lu via Binutils's message of "Fri, 2 Oct 2020 15:25:14 -0700") Message-ID: <87imbrhlhx.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_LOTSOFHASH, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Oct 2020 06:28:02 -0000 On Okt 02 2020, H.J. Lu via Binutils wrote: > On master branch, I got > > $ git checkout d0e70c4189d5d6a6e63b85c1d3c10c74852173b4 > Previous HEAD position was 5a805384b83 asan: readelf buffer overflow and abort > HEAD is now at d0e70c4189d Automatic date update in version.in > $ git bisect good > $ git checkout fe07b5721a64a84e36ec63e15638b87655faf1bf > Previous HEAD position was d0e70c4189d Automatic date update in version.in > HEAD is now at fe07b5721a6 gdb/testsuite: Update test pattern in > ptype-on-functions.exp > $ git bisect bad > Some good revs are not ancestors of the bad rev. Git told you the reason. $ git rev-list d0e70c4189d5d6a6e63b85c1d3c10c74852173b4..fe07b5721a64a84e36ec63e15638b87655faf1bf | wc -l 0 $ git rev-list fe07b5721a64a84e36ec63e15638b87655faf1bf..d0e70c4189d5d6a6e63b85c1d3c10c74852173b4 | wc -l 232 > git bisect cannot work properly in this case. > Maybe you mistook good and bad revs? If you want to find the commit where an issue is fixed, you need to mark the commits that don't have the issue as bad and the the ones that have the issue as good. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."