From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Gary Benson <gbenson@redhat.com>,
Mike Frysinger <vapier@gentoo.org>,
gdb@sourceware.org,
Andreas Arnez <arnez@linux.vnet.ibm.com>
Subject: Re: ChangeLogs in commit messages
Date: Thu, 14 Aug 2014 19:04:00 -0000 [thread overview]
Message-ID: <87ioluao58.fsf@redhat.com> (raw)
In-Reply-To: <20140814132939.GH4924@adacore.com> (Joel Brobecker's message of "Thu, 14 Aug 2014 06:29:39 -0700")
On Thursday, August 14 2014, Joel Brobecker wrote:
> No, I strongly object to #5. The ChangeLog entries are part of
> the email to be sent along with the patch to be reviewed, We had
> that discussion many many years ago, and at the time, people
> wanted the CL entry in the email, rather than as a diff.
On Thursday, August 14 2014, Joel Brobecker wrote:
> Again, I do think that having the CL entry in the commit message is
> useful, and I disagree with the idea of removing it from there.
> Imagine you are scanning the past changes, looking for what might
> have caused a behavior change. When using "git log", having the CL
> in there often helps.
Being the maintainer of GDB for RHEL, and having to deal with many
patches to backport, I second what Joel said.
I prefer CL messages to be included in the commit message (a la option
#1 in Gary's message), and I strongly prefer to have a good explanation
of what the patch does in the message too.
Cheers,
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2014-08-14 19:04 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 8:32 Gary Benson
2014-08-14 12:52 ` Joel Brobecker
2014-08-14 13:15 ` Gary Benson
2014-08-14 13:25 ` Joel Brobecker
2014-08-14 15:22 ` Eli Zaretskii
2014-08-15 8:05 ` Gary Benson
2014-08-15 8:41 ` Eli Zaretskii
2014-08-15 11:45 ` Andreas Schwab
2014-09-03 20:54 ` Sergio Durigan Junior
2014-09-03 21:22 ` Sergio Durigan Junior
2014-09-03 22:18 ` Andreas Schwab
2014-09-04 9:06 ` Gary Benson
2014-09-04 14:23 ` Sergio Durigan Junior
2014-09-04 16:08 ` Doug Evans
2014-09-04 17:36 ` Gary Benson
2014-09-05 10:13 ` Gary Benson
2014-09-05 16:43 ` Doug Evans
2014-09-08 9:50 ` Gary Benson
2014-09-08 13:08 ` James Hogan
2014-09-08 13:21 ` James Hogan
2014-09-08 13:24 ` Joel Brobecker
2014-09-08 15:31 ` Gary Benson
2014-09-09 8:51 ` James Hogan
2014-09-09 16:25 ` Doug Evans
2014-09-10 10:58 ` Pedro Alves
2014-09-10 16:12 ` Doug Evans
2014-09-10 16:28 ` Joel Brobecker
2014-09-15 10:30 ` Gary Benson
2014-09-15 12:45 ` Joel Brobecker
2014-09-15 15:30 ` Doug Evans
2014-09-15 16:05 ` Joel Brobecker
2014-09-15 17:47 ` Doug Evans
2014-09-16 9:31 ` Gary Benson
2014-09-16 15:50 ` Doug Evans
[not found] ` <0CEE46EB9C50E44486A861D738D3E20645F67101@rsex2.realsil.com.cn>
2014-10-03 18:22 ` GDB bugs Pedro Alves
2014-08-14 12:57 ` ChangeLogs in commit messages Mike Frysinger
2014-08-14 13:12 ` Gary Benson
2014-08-14 13:29 ` Joel Brobecker
2014-08-14 13:39 ` Andreas Schwab
2014-08-14 13:48 ` Joel Brobecker
2014-08-14 13:57 ` Andreas Schwab
2014-08-14 14:22 ` Joel Brobecker
2014-08-14 14:45 ` Andreas Schwab
2014-08-14 15:01 ` Joel Brobecker
2014-08-14 15:13 ` Andreas Schwab
2014-08-14 15:22 ` Joel Brobecker
2014-08-14 15:44 ` Andreas Schwab
2014-08-14 15:49 ` Joel Brobecker
2014-08-14 19:04 ` Sergio Durigan Junior [this message]
2014-08-15 8:48 ` Gary Benson
2014-08-15 12:11 ` Joel Brobecker
2014-08-15 13:09 ` Gary Benson
2014-08-15 13:28 ` Joel Brobecker
2014-08-15 15:02 ` Gary Benson
2014-08-15 15:27 ` Andreas Arnez
2014-08-15 16:08 ` Joel Brobecker
2014-08-18 8:31 ` Gary Benson
2014-08-18 14:54 ` Doug Evans
2014-08-18 15:05 ` Joel Brobecker
2014-08-18 15:27 ` Gary Benson
2014-08-20 12:20 ` Gary Benson
2014-08-14 16:22 ` Andreas Arnez
2014-08-14 13:23 ` Mike Frysinger
2014-08-14 13:36 ` Siva Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioluao58.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=brobecker@adacore.com \
--cc=gbenson@redhat.com \
--cc=gdb@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).