From: Gaius Mulley <gaius.southwales@gmail.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Tom de Vries <tdevries@suse.de>,
gdb@sourceware.org, gdb-patches@sourceware.org
Subject: Re: Patch: Fix for Bug 26372 [Modula-2] Parsing of multi-subscript arrays
Date: Tue, 25 Aug 2020 13:33:26 +0100 [thread overview]
Message-ID: <87lfi2gb1l.fsf@ettard> (raw)
In-Reply-To: <20200825093613.GT853475@embecosm.com> (Andrew Burgess's message of "Tue, 25 Aug 2020 10:36:13 +0100")
Andrew Burgess <andrew.burgess@embecosm.com> writes:
> * Tom de Vries <tdevries@suse.de> [2020-08-25 11:29:18 +0200]:
>
>> On 8/25/20 4:29 AM, Gaius Mulley wrote:
>> >
>> >
>> > Hi Tom,
>> >
>> > here is a bugfix for Pr 26372 [Modula-2] Parsing of multi-subscript arrays.
>> > Also included is a dejagnu testcase. No extra regressions are caused on
>> > Debian GNU/Linux Buster amd64, is this ok to apply?
>> >
>>
>> Hi Gaius,
>>
>> I ran into some trouble applying the patch with the patch program, so I
>> applied the patch manually, and then diffed the result of that with the
>> original patch and fixed whitespace problems in the original patch until
>> I got duplicates, to ensure that the application process was sane.
>>
>> I verified that when building with the patch, the warning "rule useless
>> in parser due to conflicts" is gone, and no new warnings are introduced.
>>
>> I ran the test-case and verified that it failed without and passed with
>> the patch.
>>
>> I've also fixed the ChangeLog entry a bit (multidim.y -> multidim.exp)
>> and split it up for gdb/ChangeLog and gdb/testsuite/Changelog, as well
>> as added a PR number.
>>
>> I've gone ahead an applied it (with you as author, obviously). See
>> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=07758bdfa9e5a762f2ec0deeb51b11d6ad5fe376
>> .
>>
>> Attached here for reference.
>
> Given the issues I raised with this patch in [1] I reverted this
> commit and pushed my suggested patch instead. Again maintaining the
> original author.
>
> I hope this does not offend anyone. Please let me know if this was
> the wrong course of action.
>
> Thanks,
> Andrew
>
> [1] https://sourceware.org/pipermail/gdb-patches/2020-August/171456.html
Hi Andrew and Tom,
many thanks for reviewing and testing the patch, improving the patch and
applying it. All looks great now,
regards,
Gaius
prev parent reply other threads:[~2020-08-25 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 2:29 Gaius Mulley
2020-08-25 9:22 ` Andrew Burgess
2020-08-25 12:25 ` Gaius Mulley
2020-08-25 9:29 ` Tom de Vries
2020-08-25 9:36 ` Andrew Burgess
2020-08-25 12:33 ` Gaius Mulley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfi2gb1l.fsf@ettard \
--to=gaius.southwales@gmail.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).