public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: libc-alpha@sourceware.org,  gdb@sourceware.org,
	libc-coord@lists.openwall.com,
	 Daniel Walker <danielwa@cisco.com>
Subject: Re: [PATCH v9 1/1] Extend struct r_debug to support multiple namespaces [BZ #15971]
Date: Mon, 13 Sep 2021 16:40:09 +0200	[thread overview]
Message-ID: <87sfy8bkty.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210910201219.156682-2-hjl.tools@gmail.com> (H. J. Lu's message of "Fri, 10 Sep 2021 13:12:19 -0700")

* H. J. Lu:

> +	  /* Add the new namespace to the linked list.  After a namespace
> +	     is initialized, r_brk becomes non-zero.  A namespace becomes
> +	     empty (r_map == NULL) when it is unused.  But it is never
> +	     removed from the linked list.  */
> +	  r->r_next = _r_debug_extended.r_next;
> +	  atomic_store_release (&_r_debug_extended.r_next, r);

I think the addition should be at the end of the list, and the list
update (with release MO) should come last.  That should help with
reading the list concurrently.

Rest looks okay to me.

Thanks,
Florian


      reply	other threads:[~2021-09-13 14:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 20:12 [PATCH v9 0/1] Extend struct r_debug to support multiple namespaces H.J. Lu
2021-09-10 20:12 ` [PATCH v9 1/1] Extend struct r_debug to support multiple namespaces [BZ #15971] H.J. Lu
2021-09-13 14:40   ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfy8bkty.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=danielwa@cisco.com \
    --cc=gdb@sourceware.org \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=libc-coord@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).