From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.231]) by sourceware.org (Postfix) with ESMTPS id E712F3851C1D for ; Fri, 29 May 2020 12:15:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E712F3851C1D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id E639416B70 for ; Fri, 29 May 2020 07:15:03 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id edugjapJLSl8qedugjq8WI; Fri, 29 May 2020 07:15:03 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CSiRzNU9vbWXQTmIuxHv3OwDMCgdA9xQ5NCC307BKLw=; b=VW+3ravFLVxbR7Npk/qC0cO+Ir UU13he0pNgw6m8vksmFX+fnvUsDz+YH+fqNpVfk2wpNPbWSSqGancf9bdiHZlIHmCy2Z+OgmykGoy kwa313ZK6OR1TaOCsVnoR4yCp; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:46526 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jedug-001e3l-Gm; Fri, 29 May 2020 06:15:02 -0600 From: Tom Tromey To: Martin =?utf-8?Q?Li=C5=A1ka?= Cc: "H.J. Lu" , Simon Marchi , GDB , Binutils Subject: Re: Auto update ChangeLog for binutils+gdb commits? References: <891ef86a-a47f-18f2-c6bd-e525719e3768@simark.ca> <9492d857-c259-1429-f1c7-31a6dbf6510f@simark.ca> <1fb47dab-7a52-524b-17a3-672122277a48@suse.cz> X-Attribution: Tom Date: Fri, 29 May 2020 06:15:01 -0600 In-Reply-To: <1fb47dab-7a52-524b-17a3-672122277a48@suse.cz> ("Martin =?utf-8?Q?Li=C5=A1ka=22's?= message of "Fri, 29 May 2020 09:45:45 +0200") Message-ID: <87tuzzaqey.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jedug-001e3l-Gm X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:46526 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2020 12:15:07 -0000 Martin> I'm the author of the scripts that are currently used in the GCC. Martin> As mentioned, we update ChangeLog files by a script that takes all Martin> the ChangeLog entries from git commit message. The supported ChangeLog Martin> format is documented here: Martin> https://gcc.gnu.org/codingconventions.html#ChangeLogs IIUC, we still have to write the ChangeLog entries by hand, just in the commit message, and using a much stricter format. Is that accurate? If so, then this seems less convenient than the status quo. At least for me, editing the files is simpler -- I use scripts to handle the merges, rebases, and date-updating; and Emacs provides direct support for writing the entries in the correct files and it usually gets the function name correct as well. It's the convenience of the last part that I'm most concerned about losing. If there's a script that does as good a job, then maybe; but otherwise it is a -1 from me. My reasoning here is that editing a ChangeLog entry is labor-intensive, and anything increasing the labor is a negative. It's already a reasonably significant drag on submitting patches. I'd be receptive to removing ChangeLog entirely. I don't believe they provide much value. However, I know others disagree on this point, so I don't plan to press it. I'd also be open to changing the format to something requiring zero manual intervention. For example, if we could have a commit script that simply listed the files and didn't require editing in the names of the functions. thanks, Tom