From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.4]) by sourceware.org (Postfix) with ESMTPS id 122053840C0D for ; Sat, 30 May 2020 19:41:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 122053840C0D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 965071EBD for ; Sat, 30 May 2020 14:41:40 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id f7MSjXaQyAGTXf7MSjjWCE; Sat, 30 May 2020 14:41:40 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+CU53rSg22k/l0mBqnRlunNjaLpXo9zX2C/rRQbuiIA=; b=QidQc/nV1wUvrTHBMC7npa4nhS ZGgFAQ0J93h1At7W/yoAfaMxhu/U5pf2i8qOkBRJ6BrM/TOSxMeA51UA5+4sgGCl+v3870TgeFC5c 78Pt7B3atydFjCPcQhhDqgUjA; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:33018 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jf7MS-000rPy-6u; Sat, 30 May 2020 13:41:40 -0600 From: Tom Tromey To: Martin =?utf-8?Q?Li=C5=A1ka?= Cc: Tom Tromey , "H.J. Lu" , Simon Marchi , GDB , Binutils Subject: Re: Auto update ChangeLog for binutils+gdb commits? References: <891ef86a-a47f-18f2-c6bd-e525719e3768@simark.ca> <9492d857-c259-1429-f1c7-31a6dbf6510f@simark.ca> <1fb47dab-7a52-524b-17a3-672122277a48@suse.cz> <87tuzzaqey.fsf@tromey.com> <87o8q6c3m9.fsf@tromey.com> <12ea10a1-59c1-5858-4619-ed3b40121d30@suse.cz> X-Attribution: Tom Date: Sat, 30 May 2020 13:41:38 -0600 In-Reply-To: <12ea10a1-59c1-5858-4619-ed3b40121d30@suse.cz> ("Martin =?utf-8?Q?Li=C5=A1ka=22's?= message of "Fri, 29 May 2020 15:56:50 +0200") Message-ID: <87y2p9qkgd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jf7MS-000rPy-6u X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (bapiya) [174.16.104.48]:33018 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2020 19:41:42 -0000 >> Could you run it on some recent gdb commits and show the output? I tried it out a little as well. It seems promising. However, I noticed some issues. First, in the basic output: Martin> * gdb/Makefile.in: It would be more convenient for editing if the ":" were followed by a space, since I'm normally going to have to add one anyway. Next, try it like: $ git show af0b2a3e85df9f49a3528e5b7578fcf9412f1acc | ./contrib/mklog.py I get: gdb/ChangeLog: * ChangeLog: * dwarf2/abbrev.c (hash_abbrev): (abbrev_table::add_abbrev): (struct abbrev_info): (abbrev_table::lookup_abbrev): (abbrev_table::read): * dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H): (struct abbrev_table): abbrev.c says: (struct abbrev_info): ... but I didn't see anything that would be relevant in the patch. abbrev.h says: * dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H): ... but this is very incorrect. In gdb we normally ignore changes to the #includes, but if needed I suppose this could mention the addition of one; but either way mentioning the include guard name is wrong -- macros should be ignored unless each preceding line ends with a backslash. If you try 89bcba74f89baceba3fa7387622e3d60e1de02e8, you'll see that mklog ignores namespaces. Martin> Sure. You're a skilled GDB developer with long experience. But for newcomers or Martin> people without the scripts, this can simplify their workflow. IMO we should optimize for reducing the overhead for regular contributors. Newcomers normally have many things to learn. Tom