From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id C364E394D8A6 for ; Mon, 28 Jun 2021 08:34:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C364E394D8A6 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-VrR_urc4NAqIrd1-xMfBLg-1; Mon, 28 Jun 2021 04:34:57 -0400 X-MC-Unique: VrR_urc4NAqIrd1-xMfBLg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C4C08800C78; Mon, 28 Jun 2021 08:34:56 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-228.ams2.redhat.com [10.36.112.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5E2E510074FD; Mon, 28 Jun 2021 08:34:52 +0000 (UTC) From: Florian Weimer To: Carlos O'Donell Cc: libc-alpha@sourceware.org, gdb@sourceware.org, Kevin Buettner Subject: Re: [PATCH] nptl: Export libthread_db-used symbols under GLIBC_PRIVATE References: <877disuwfq.fsf@oldenburg.str.redhat.com> <1058178f-a8d0-4987-cc14-1c9f6da7af5d@redhat.com> Date: Mon, 28 Jun 2021 10:34:50 +0200 In-Reply-To: <1058178f-a8d0-4987-cc14-1c9f6da7af5d@redhat.com> (Carlos O'Donell's message of "Sun, 27 Jun 2021 22:10:29 -0400") Message-ID: <87zgvaxu8l.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 08:35:00 -0000 * Carlos O'Donell: > I audited this against the current pristine upstream. > > I see 3 additional symbols not in your list: > > _thread_db___nptl_initial_report_events (DB_RTLD_VARIABLE) > _thread_db___nptl_nthreads (DB_MAIN_VARIABLE) > _thread_db___pthread_keys (DB_MAIN_ARRAY_VARIABLE) > > Given that they *are* party of the db, is there any reason > not to include them for completeness? I'm going to send a new series which brings this to the maximum set of symbols. Thanks, Florian