From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A6E4E38582B4 for ; Tue, 27 Sep 2022 12:02:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A6E4E38582B4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 28ED01E0D3; Tue, 27 Sep 2022 08:02:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1664280133; bh=KLCHka+kiajEhOM0qXbWq/oW7PbA9g6DqKLByhpLLow=; h=Date:Subject:To:References:From:In-Reply-To:From; b=agFIPDhkFu1s/bdFL+2JaxaO8vQjWytf17RCb7Fr37tCsGpUEnMh0b1NFMYRsxaGJ 60ufFvggUxnLVtnYYivkSQHnhzOphoMeSLvKWypLpd5IHGQ2pXyNBCXnX8Ex5lTk3u 5dTjq3ND2SO95TYxYbBRCWI446CLrujqN9z+xunk= Message-ID: <8b2913f0-fd8c-5b48-cab3-f87b581171e1@simark.ca> Date: Tue, 27 Sep 2022 08:02:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Proposal: Add review tags to patch review workflow. Content-Language: en-US To: Bruno Larsen , John Baldwin , gdb@sourceware.org References: <453759b1-1ddf-1aff-a033-6183b84a4a4d@simark.ca> <4c321d90-ca45-c3dd-27dc-cc8c74b6e999@FreeBSD.org> <5bc9205b-65ea-4436-e9d7-2e9f70147d5d@redhat.com> From: Simon Marchi In-Reply-To: <5bc9205b-65ea-4436-e9d7-2e9f70147d5d@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> It also wasn't clear to me if the intention was for the commits to >> be amended with the annotations?  (I don't think it was explicitly >> stated in the original mail, and I'm not sure if it was an implicit >> assumption?) > No, I didn't intend on amending previous commits. The main problem this change intends to solve is fixing ambiguity, and the pushed patches don't have that issue anymore. Thanking a reviewer is just one more positive side (IMHO) going forward. Err, just to be clear, we won't amend existing commits in master obviously (can't rewrite history) but future commits in master would contain those tags. This means that if you give me a Reviewed-By, I amend my local commit patch to include that trailer before pushing. Simon