From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id B3FCA384772F for ; Wed, 3 Apr 2024 10:21:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3FCA384772F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B3FCA384772F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::429 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712139674; cv=none; b=tei9iezrWRYQ3spJOkfX7iHKKAVdFFTFP1W54ues9lerButqFPBoCxAwC6uCfEMtt6iWFEQUIMMxrQ21snkANb2SFJ4BJwq6rH7Om8Vz7UrPpjW17JL78GVU5M2YKJvOiENcPMBuNBxfuUe9aJUT83PpqacVmhfxHU8nVaAYg3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712139674; c=relaxed/simple; bh=eaMhyXSorzcPnsb+u23b1D6utgrylOljsnR4AWTS5RE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=JUI3FUIZH+lT+mNrNQSRNkusdfrQoaw1rRsAIYkRCki1pE6lXm3CKZKmWDVgUVsCvtz/xo8CMJvBXRDDIZYIKgiAcv6cGeXfzKFH0Nke3LOFZEKqU6PwXy1zHToH/IpLG7kaAiHBOrC6Vi5xZDgKSyjmxMuX++oB4jmM1x2biRY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-343892ca0a7so509532f8f.3 for ; Wed, 03 Apr 2024 03:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1712139666; x=1712744466; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r9PIiCT5QQ2mKVZF34fw8u8jiGvDhwp/2Fv8Utwu4cs=; b=fcovc/76Uoga2+meXVDPdbRPCG1gJzsOseGxwVRepl9snPfR8FxdoBEgomU+BnycFo o66c/SrZ7+rDrH22vE+gNwORCJsuHZEiLLoTL/B1Cs9cyf2kOK2GbXL+4fwsAybL4362 JpFr6wcr1/hvXthuI5t1llOwZXW1w7ZVlNeXi6P4NwJzZ4XiEltQI9SYfS9xNVX6yXNy 0FkYsFw+weIgvA8K3rsh6FM3b8UQ4mMwxUHSi5ZF8nILEEU3Bz+rge8+x0EBdjxacbtZ 2bLLRYvP+eIBqGxVT7X+qgwZ/B1l5bwTa4olEljkVpd6Jsp50NfORWJ1suFgLxy95ngF OoFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712139666; x=1712744466; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r9PIiCT5QQ2mKVZF34fw8u8jiGvDhwp/2Fv8Utwu4cs=; b=b22lMSn0Lj64cHcibBTIUOILvwLClspy4tZ2hv8k68bCUqrL163lZeku/lauHAGrhO kk0FTyHZS9IjiCzZO5BfUekX5cRj+NPdUUZFApPg7XcT+14NlWlyHQxBc8NqxSZYNT0l 20DIr+xqdth2yAJxsXw7rhFkwf52EooNY4dtla0L9VTNdhv0sYUbuQX0KGO6Gm+kzmPi 0Bhm3AmAfYqrHM2RHjd/y0eOq581RMpzOk+L67UsjAQ002h7PIEJ5euD8G9SuIwtEQaa JTUTU3hxhzE21hZrFGdIX8k/27UgEpVoc17wmOc6HhyWp8HEzULdBKQyB3SGtANKOYai /DUg== X-Forwarded-Encrypted: i=1; AJvYcCU2/VWyfNlRHl45lD/bTR4C+9kLESGEZvbo242FGRR0xTirhyC3Ks4qevbhVY57S8gHySHfBp2BtkXdXsiunPDiiQU= X-Gm-Message-State: AOJu0Yza476yhJDitw4qCZ9bLMS/Yegipebj1uCofIdKxVOctZdqBOYK 9U3LN3bHCBSk5Ltj7lQtaIciX25KN5NBgu7a8gR1isrJO0m6mdQ4Ci/VJOzAf/HC5rWiHtWZiKM = X-Google-Smtp-Source: AGHT+IEcYCPQ8/WLO7t622tdoUJJqdjMQbbDmlwJW3gql5P/0jaIbmeKVln1Pv0zIyPvhBxiC1idkw== X-Received: by 2002:a5d:48c8:0:b0:33d:26b1:c460 with SMTP id p8-20020a5d48c8000000b0033d26b1c460mr10214873wrs.39.1712139666368; Wed, 03 Apr 2024 03:21:06 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id g1-20020adfa481000000b00341e7e52802sm16917190wrb.92.2024.04.03.03.21.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 03:21:06 -0700 (PDT) Message-ID: <8c4f8e79-67a2-4834-8b8b-d9223716ea89@suse.com> Date: Wed, 3 Apr 2024 12:21:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Patches submission policy change Content-Language: en-US To: Richard Biener Cc: Jakub Jelinek , Christophe Lyon , binutils@sourceware.org, GCC Mailing List , gdb@sourceware.org, Nick Clifton , Joel Brobecker , Carlos O'Donell , Maxim Kuvyrkov , Thiago Bauermann , Adhemerval Zanella References: <9o7ss477-q221-on04-4sor-151q11s7s99n@fhfr.qr> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <9o7ss477-q221-on04-4sor-151q11s7s99n@fhfr.qr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03.04.2024 10:57, Richard Biener wrote: > On Wed, 3 Apr 2024, Jan Beulich wrote: >> On 03.04.2024 10:45, Jakub Jelinek wrote: >>> On Wed, Apr 03, 2024 at 10:22:24AM +0200, Christophe Lyon wrote: >>>> Any concerns/objections? >>> >>> I'm all for it, in fact I've been sending it like that myself for years >>> even when the policy said not to. In most cases, the diff for the >>> regenerated files is very small and it helps even in patch review to >>> actually check if the configure.ac/m4 etc. changes result just in the >>> expected changes and not some unrelated ones (e.g. caused by user using >>> wrong version of autoconf/automake etc.). >>> There can be exceptions, e.g. when in GCC we update from a new version >>> of Unicode, the regenerated ucnid.h diff can be large and >>> uname2c.h can be huge, such that it can trigger the mailing list size >>> limits even when the patch is compressed, see e.g. >>> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636427.html >>> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636426.html >>> But I think most configure or Makefile changes should be pretty small, >>> usual changes shouldn't rewrite everything in those files. >> >> Which may then call for a policy saying "include generate script diff-s, >> but don't include generated data file ones"? At least on the binutils >> side, dealing (for CI) with what e.g. opcodes/*-gen produce ought to be >> possible by having something along the lines of "maintainer mode light". > > I'd say we should send generated files when it fits the mailing list > limits (and possibly simply lift those limits?). Well, that would allow patches making it through, but it would still severely increase overall size. I'm afraid more people than not also fail to cut down reply context, so we'd further see (needlessly) huge replies to patches as well. Additionally - how does one up front determine "fits the mailing list limits"? My mail UI (Thunderbird) doesn't show me the size of a message until I've actually sent it. > As a last resort > do a series splitting the re-generation out (but I guess this would > confuse the CI as well and of course for the push you want to squash > again). Yeah, unless the CI would only ever test full series, this wouldn't help. It's also imo even more cumbersome than simply stripping the generated file parts from emails. Jan