From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A2CD03858D35 for ; Mon, 22 Nov 2021 15:17:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A2CD03858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id DED4E1E940; Mon, 22 Nov 2021 10:17:13 -0500 (EST) Subject: Re: [PATCH 3/3] gdb: More compile fixes for gnu-nat.c. To: "Jan (janneke) Nieuwenhuizen" , gdb@sourceware.org References: <20211122073057.19946-1-janneke@gnu.org> From: Simon Marchi Message-ID: <9225658f-a554-1ac1-075b-a2f0ea289313@simark.ca> Date: Mon, 22 Nov 2021 10:17:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211122073057.19946-1-janneke@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2021 15:17:16 -0000 On 2021-11-22 2:30 a.m., Jan (janneke) Nieuwenhuizen via Gdb wrote: > This fixes compile errors like > > ../../gdb-11.1/gdb/gnu-nat.c: In function ‘void add_task_commands()’: > ../../gdb-11.1/gdb/gnu-nat.c:3204:17: error: no matching function for call to ‘add_cmd(const char [8], command_class, cmd_list_element*&, char*, cmd_list_element**)’ > 3204 | &setlist); > | ^ > In file included from ../../gdb-11.1/gdb/completer.h:21, > from ../../gdb-11.1/gdb/symtab.h:36, > from ../../gdb-11.1/gdb/infrun.h:21, > from ../../gdb-11.1/gdb/target.h:42, > from ../../gdb-11.1/gdb/inf-child.h:23, > from ../../gdb-11.1/gdb/gnu-nat.h:38, > from ../../gdb-11.1/gdb/gnu-nat.c:24: > ../../gdb-11.1/gdb/command.h:160:33: note: candidate: ‘cmd_list_element* add_cmd(const char*, command_class, void (*)(const char*, int), const char*, cmd_list_element**)’ > 160 | extern struct cmd_list_element *add_cmd (const char *, enum command_class, > | ^~~~~~~ > ../../gdb-11.1/gdb/command.h:161:30: note: no known conversion for argument 3 from ‘cmd_list_element*’ to ‘void (*)(const char*, int)’ > 161 | cmd_const_cfunc_ftype *fun, > | ~~~~~~~~~~~~~~~~~~~~~~~^~~ > ../../gdb-11.1/gdb/command.h:167:33: note: candidate: ‘cmd_list_element* add_cmd(const char*, command_class, const char*, cmd_list_element**)’ > 167 | extern struct cmd_list_element *add_cmd (const char *, enum command_class, > | ^~~~~~~ > ../../gdb-11.1/gdb/command.h:167:33: note: candidate expects 4 arguments, 5 provided > ../../gdb-11.1/gdb/gnu-nat.c:3210:18: error: no matching function for call to ‘add_cmd(const char [8], command_class, cmd_list_element*&, char*, cmd_list_element**)’ > 3210 | &showlist); > | ^ Hi Jan, I only see patch 3/3, is it normal? Otherwise, patches should be sent to the gdb-patches mailing list (same address, just with gdb-patches instead of gdb). > * gdb/gnu-nat.c (add_task_commands): Use a fresh variable instead of > shadowing set_signals_cmd etc. > (add_thread_commands): Likewise. Note that we don't use ChangeLogs in gdb/. Simon