From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3499 invoked by alias); 3 Aug 2010 15:54:29 -0000 Received: (qmail 3487 invoked by uid 22791); 3 Aug 2010 15:54:28 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Aug 2010 15:54:24 +0000 Received: by qwk4 with SMTP id 4so2473675qwk.0 for ; Tue, 03 Aug 2010 08:54:20 -0700 (PDT) Received: by 10.224.19.66 with SMTP id z2mr2877203qaa.187.1280850860535; Tue, 03 Aug 2010 08:54:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.73.203 with HTTP; Tue, 3 Aug 2010 08:54:00 -0700 (PDT) From: Hui Zhu Date: Tue, 03 Aug 2010 15:54:00 -0000 Message-ID: Subject: [RFC] corelow and multi-arch : Move deprecated_add_core_fns to set_gdbarch_regset_from_core_section To: gdb@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00020.txt.bz2 Hi, I got a some error with multi-arch gdb and a mips core file: (gdb) core-file ~/tmp/vmcore warning: "/home/teawater/tmp/vmcore": ambiguous core format, 2 handlers match warning: wrong size gregset struct in core file warning: wrong size gregset struct in core file #0 0x0000000000000000 in ?? () (gdb) This error because sniff_core_bfd return cris_elf_core_fns. So GDB use cris_elf_core_fns.fetch_core_registers to analyze this mips core. It return cris_elf_core_fns because core_sniffer of cris_elf_core_fns and mips-linux-tdep.c:regset_core_fns is default_core_sniffer. So I think this is not fit with the multi-arch. Do you think we can begin move deprecated_add_core_fns to set_gdbarch_regset_from_core_section? BTW, core_vec->core_read_registers have a argument "which" that gdbarch_regset_from_core_section doesn't have. Do you think we can add one to it? Thanks, Hui