From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=OkMo=7A=gmail.com=pinskia@sourceware.org>
Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e])
	by sourceware.org (Postfix) with ESMTPS id C76DF3858D33
	for <gdb@sourceware.org>; Wed,  8 Mar 2023 20:16:58 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C76DF3858D33
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-pg1-x52e.google.com with SMTP id s18so10386266pgq.1
        for <gdb@sourceware.org>; Wed, 08 Mar 2023 12:16:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112; t=1678306618;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=sF6RM9aGkBG2JQ96wxmCRR5fhVoFlFC9Ox7qffDrB+Y=;
        b=GERd81VEQbE05g4zFn8LOlPBhnUqXMqxGg4TOOYnchRNP+eZxqYuTgA9uDWW9hQ5zK
         hUa1MX+1z8hpmNbbkCOh7yoNo/O48XOWYzlwyicRVz4jzPMlYseC8FpdVJEKA/UHGsOo
         k08WGsGdZ46zuFJgtoG3v7hM6QMQxynDD0/IraN7Y9rJi1XbGUQUo9WsiJ534PyRaj3n
         bIJnZwExe9kh8fVyLyKT+i2HkrsLTUFqErGrGch8Mp2BLSE8auP4OvKdS26IzgZlPXWX
         X+hCJk0s5SKqTM+E9R8Oc7UoRnjq0kvuJFAoG7s0hojoJrK+OHwCWUVkHQG7ECAP1Ep0
         gGVg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112; t=1678306618;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=sF6RM9aGkBG2JQ96wxmCRR5fhVoFlFC9Ox7qffDrB+Y=;
        b=CbEH3NdyfflUZIB5mIKe6xnKTZOamg9yVvV6iT3nJknbxYvc9WEr1kF6vzj04ZHh3r
         xR7HjimKJboSrHiM7Xzt4ZH6FVUkQanh2BNTXIgqMjqfLRH6a4niiYm6ykXsDy8dgWlE
         7E+CwH5lD/wEVnf1h6EOBS/Jw1nfpmp7RjuZaS9F6QzmYpUGtp2hpS8iuBPuySKyRaI4
         kIf7mkGaU3SfzaUFqRzAjjcZ/WeXCwyVQIyMeZO6IwE9W9aLMR9gcuGyQBd92p29DCvC
         tVNsX0tMcZM5+J5HsVWbxG2mS5wOVjCIPn9Px4/F3GWyJztwWfTdVyCXYRoLgJ9J2Hwm
         +HQg==
X-Gm-Message-State: AO0yUKVeH2YSYd+390gqFShyj4giBonT6853vH3wX1bIIQlxkt+KyIE0
	qxLqOmrBDmGMv5Rprhhc6/uxnG4XgKRU0EHsa0ll3t/CeJLdsQ==
X-Google-Smtp-Source: AK7set8QDBkyAUg+SKuG4Rw1yEQPEL+LtOzanT6o54GG82bwjUSBwu6C0OzqfLCrhAmS+GeGEJSIuvZ8eYKpOYW+t2I=
X-Received: by 2002:a62:ce87:0:b0:606:d488:f058 with SMTP id
 y129-20020a62ce87000000b00606d488f058mr8099782pfg.3.1678306617692; Wed, 08
 Mar 2023 12:16:57 -0800 (PST)
MIME-Version: 1.0
References: <e8ef3389-458d-7c5a-e5df-650f7af8fef2@rtems.org>
In-Reply-To: <e8ef3389-458d-7c5a-e5df-650f7af8fef2@rtems.org>
From: Andrew Pinski <pinskia@gmail.com>
Date: Wed, 8 Mar 2023 12:16:44 -0800
Message-ID: <CA+=Sn1=sYMqCrw3ARputZQhwB8kecYYJQjjsnNrdFmeC3QD9nw@mail.gmail.com>
Subject: Re: GDB 13.1 and clang
To: Chris Johns <chrisj@rtems.org>
Cc: gdb@sourceware.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb.sourceware.org>

On Wed, Mar 8, 2023 at 12:07=E2=80=AFPM Chris Johns <chrisj@rtems.org> wrot=
e:
>
> Hi,
>
> I have just tried to build the latest RTEMS tools and we now use gdb 13.1=
. I am
> seeing a build failure on FreeBSD 13.1 of:
>
> In file included from ../../gdb-13.1/gdb/xml-tdesc.c:23:
> In file included from ../../gdb-13.1/gdb/target.h:42:
> In file included from ../../gdb-13.1/gdb/infrun.h:21:
> In file included from ../../gdb-13.1/gdb/gdbthread.h:26:
> In file included from ../../gdb-13.1/gdb/breakpoint.h:38:
> ../../gdb-13.1/gdb/target/waitstatus.h:113:1: error: use of undeclared
> identifier 'DIAGNOSTIC_ERROR_SWITCH'
> DIAGNOSTIC_ERROR_SWITCH
> ^
>
> I only have clang installed on the FreeBSD machine.
>
> A quick review of include/diagnostics.h seems to show support for
> DIAGNOSTIC_ERROR_SWITCH only in the gcc area?

Huh? I looked into include/diagnostics.h in git and there is even:
#ifndef DIAGNOSTIC_ERROR_SWITCH
# define DIAGNOSTIC_ERROR_SWITCH
#endif

And before under `#if defined (__clang__) /* clang */`
# define DIAGNOSTIC_ERROR_SWITCH \
  DIAGNOSTIC_ERROR ("-Wswitch")

So I have no idea how it would be broken.
Unless somehow the wrong diagnostics.h is getting included. As far as
I can see include/diagnostics.h is the only one in git even.

Thanks,
Andrew Pinski

>
> Is this something I should raise a ticket for?
>
> Thanks
> Chris