From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2610 invoked by alias); 9 Jul 2012 18:51:38 -0000 Received: (qmail 2477 invoked by uid 22791); 9 Jul 2012 18:51:37 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-lb0-f169.google.com (HELO mail-lb0-f169.google.com) (209.85.217.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Jul 2012 18:51:22 +0000 Received: by lbjn8 with SMTP id n8so11208197lbj.0 for ; Mon, 09 Jul 2012 11:51:21 -0700 (PDT) Received: by 10.152.102.137 with SMTP id fo9mr41950553lab.35.1341859881137; Mon, 09 Jul 2012 11:51:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.4.229 with HTTP; Mon, 9 Jul 2012 11:51:01 -0700 (PDT) In-Reply-To: <20120709181015.2FCA41E13A1@ruffy2.mtv.corp.google.com> References: <20120709181015.2FCA41E13A1@ruffy2.mtv.corp.google.com> From: Steven Bosscher Date: Mon, 09 Jul 2012 18:51:00 -0000 Message-ID: Subject: Re: [RFA libiberty, gdb] Add hashtab support to filename_ncmp.c and use it in gdb. To: Doug Evans Cc: gcc-patches@gcc.gnu.org, gdb@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00006.txt.bz2 On Mon, Jul 9, 2012 at 8:10 PM, Doug Evans wrote: > Hi. > > filename_seen in gdb does a linear search, this patch changes it > to use a hash table. > > Ok to check in? Why not just use htab_hash_string? The file name canonicalization can be put in gdb itself. Ciao! Steven