From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2841 invoked by alias); 6 Dec 2012 20:39:37 -0000 Received: (qmail 2637 invoked by uid 22791); 6 Dec 2012 20:39:34 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-la0-f41.google.com (HELO mail-la0-f41.google.com) (209.85.215.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Dec 2012 20:39:29 +0000 Received: by mail-la0-f41.google.com with SMTP id m15so6118559lah.0 for ; Thu, 06 Dec 2012 12:39:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.152.102.146 with SMTP id fo18mr3149239lab.32.1354826367957; Thu, 06 Dec 2012 12:39:27 -0800 (PST) Received: by 10.112.32.1 with HTTP; Thu, 6 Dec 2012 12:39:27 -0800 (PST) In-Reply-To: <20121204145144.GA30509@host2.jankratochvil.net> References: <20120330161403.GA17891@host2.jankratochvil.net> <87aa2rjkb8.fsf@fleche.redhat.com> <4F8FD047.6030702@codesourcery.com> <20121204141708.GA28600@host2.jankratochvil.net> <201212041444.qB4EiG4L025312@glazunov.sibelius.xs4all.nl> <20121204145144.GA30509@host2.jankratochvil.net> Date: Thu, 06 Dec 2012 20:39:00 -0000 Message-ID: Subject: Re: Will therefore GDB utilize C++ or not? From: Matt Rice To: Jan Kratochvil Cc: Mark Kettenis , gdb@sourceware.org, tromey@redhat.com, yao@codesourcery.com Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00032.txt.bz2 On Tue, Dec 4, 2012 at 6:51 AM, Jan Kratochvil wrote: > On Tue, 04 Dec 2012 15:44:16 +0100, Mark Kettenis wrote: >> > Is it enough plan to justify the -Wc++-compat compatibility step? >> > That is to update and check-in archer-ratmice-compile-Wc++-compat. >> >> Not without proper review of the changes. And since my position on >> C++ has changed, I'd not really eager to do that. But if -Wc++-compat >> would make you happy, and stop pushing for switching GDB to C++, > > No matter whether C++ will happen or not -Wc++-compat is already useful > (for the 64-bit offsets upstreaming). This is why I ask for it on its own. > > While -Wc++-compat enables fixing the 64-bit offsets in GDB it is only like > 1% (random guess) of GDB bugs fixes C++ enables us to do. So the decision of > -Wc++-compat is orthogonal to the C++ decision. > > >> I'd be willing to spend some time to help. > > There is hopefully not much help needed, Matt Rice was offering to update > archer-ratmice-compile-Wc++-compat, and I think one can safely verify the > patch is valid (besides some eyes review) also by comparing byte-by-byte the > compiled stripped binaries. > k, will go ahead and get started on this i've always felt we should at least do -Wc++-compat since when doing the patch originally it did make apparent at least one bug in gdb. If anyone has any particularly large change to an existing source file, and they'd prefer I postpone work on that file until later please let me know, it might save work for one of us or the other.