From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 359 invoked by alias); 4 Sep 2014 16:08:48 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 349 invoked by uid 89); 4 Sep 2014 16:08:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f174.google.com Received: from mail-vc0-f174.google.com (HELO mail-vc0-f174.google.com) (209.85.220.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 04 Sep 2014 16:08:45 +0000 Received: by mail-vc0-f174.google.com with SMTP id hy4so10970083vcb.33 for ; Thu, 04 Sep 2014 09:08:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=7ZPkjlYyiOdoPiHIx7dHSz3wKqO/IAPdsJrRMQOfr9Y=; b=R9kt/6eHumGj9psaP/V6RO9Ag/CU1YBiEbrcZX5Ak5+qBnXy4BG4bhLw1bRmnHeGXl bd4pvAV6CkRnpC6+wijOzQiotwTSEv94PTr9x2iV1UAnXQ9x2j+e+3vYB9ysEPlUWbM4 KcRZJj3bxJB5i7wFJtFA0ZVMMpNMzCcbYizcLE907qmQOsY9b//tlL4YO4ffv3hDAp+G l6TAghXXovakZd/+KdQD8wQ/R2V0OIkIcZFkGreK6Nwll4IdZPvN7fvX/a7GkdZYEoXi 9qEZvgb6bXUg3W7+5q/wefkRy0Ur3jKJP3IgV6a1Z63V9QRo3M/FtvJdJmKvRbaJceB5 /OJg== X-Gm-Message-State: ALoCoQnq8dhKZU6e/u6InrZ7lwvlr2ntFD/ZgewZRpvPGNTF0HEZC4PZLED6sl/q2erMxtzTE6Ge MIME-Version: 1.0 X-Received: by 10.220.105.201 with SMTP id u9mr5096411vco.11.1409846923283; Thu, 04 Sep 2014 09:08:43 -0700 (PDT) Received: by 10.52.136.203 with HTTP; Thu, 4 Sep 2014 09:08:43 -0700 (PDT) In-Reply-To: <87y4tzcvny.fsf@redhat.com> References: <20140814083231.GA6283@blade.nx> <20140814125224.GF4924@adacore.com> <8761h4fmu4.fsf@redhat.com> <87mwage6x2.fsf@redhat.com> <871trsuz55.fsf@igel.home> <20140904090616.GA23758@blade.nx> <87y4tzcvny.fsf@redhat.com> Date: Thu, 04 Sep 2014 16:08:00 -0000 Message-ID: Subject: Re: ChangeLogs in commit messages From: Doug Evans To: Sergio Durigan Junior Cc: Gary Benson , Andreas Schwab , Joel Brobecker , gdb , Andreas Arnez Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00011.txt.bz2 On Thu, Sep 4, 2014 at 7:22 AM, Sergio Durigan Junior wrote: > On Thursday, September 04 2014, Gary Benson wrote: > >>> There is no such thing as a "push date". What you see is the author >>> date and the committer date. But both are set during the local >>> commit, and are unrelated to the point of time of pushing the >>> commits to the remote repository. >> >> Yeah, in git no file (object) is modified when you push or pull >> commits, they're just copied from one place to another. > > Yeah, sorry for not being fluent in git's parlance. > >> The committer date on the commit you mentioned is likely the time >> I updated the ChangeLog prior to pushing, so that date will be the >> "push date", but that's not guaranteed to be the case for all >> commits. > > Right. Anyway, I still consider it is valid to include this info > (author and date) in the commit message. For reference sake, what started this for me is noticing git blame shows the author date by default. Not picking on Gary of course, his patch is just why I noticed this. If I do a git blame of server.c I see patch 860789c7 with a date of 2014-08-08. That's three weeks before it was pushed upstream. Bleah. I'd really like to be able to do a git blame and have what I see be useful, including the date. The author date is basically useless to me. [I realize neither author nor commit dates are the so-called push date, but I'm guessing the commit date is generally reasonably close to the date the patch is pushed upstream. If not ... yikes.] I realize any changes to what goes into the commit log won't help solve this of course. But that's what started the discussion for me.