From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id 45EC33861027 for ; Mon, 8 Mar 2021 20:39:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 45EC33861027 Received: by mail-io1-xd2d.google.com with SMTP id 81so11416384iou.11 for ; Mon, 08 Mar 2021 12:39:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m46spQ1oWrJG3ntaQ7CNf4LTaVzbdNx9wRFxB9kkiaw=; b=TVLySw9KI67OMNT5E7iTrOo8DsgqyVoVcUsnlt98C9rPAk3NyQt4BojPvmZK+kjnPa 3x8s4o0T99Ym766Kyoap+Xj3nJJh/OVYHZ9vpi+lERbmEbB9HZuvjF/Vn6T2Bg+H2cHW BGnakpDcEmNklg1mb6PlVqRxX+kvktKLDR+gjuHV8j5jeRMCB62qMJ+IyJKKEZV/aUVl Q7J6xlaOSZkqAZDjax7Pt2eR2fYNpPTchlItoRZP9EeXvZkGdSCDhYwOSys7hNc2ybph 35drfLxiKdW/Sx5KQs3IbPX8oCeQyINbQXX2uTI5L7NkFivCEaoz5plePkdZf0OtzgLL nZOA== X-Gm-Message-State: AOAM5308aX5wydWRLgjwRWnvpPZwU7g1P5QOVVypBnoRDOVUHIx/Qj6S Q1WTlBN83hjHAqfKJV/e1vNoVkdoWBwJeLNpvPHEB/zzUSc= X-Google-Smtp-Source: ABdhPJy8/EX1yAwIRbHWvb6cJaS07gadNOY0f7b9YaQwfzLS292KW5KJCUK4qKRiiRqI+NHmTpxv85fMGQNtGSZHpYs= X-Received: by 2002:a05:6602:2be1:: with SMTP id d1mr19599125ioy.148.1615235954799; Mon, 08 Mar 2021 12:39:14 -0800 (PST) MIME-Version: 1.0 References: <3a4748a5-8059-aa9e-a55a-3939dd569c36@trande.de> <278d129c-f27c-c47c-3e33-4a5a85cda855@polymtl.ca> In-Reply-To: <278d129c-f27c-c47c-3e33-4a5a85cda855@polymtl.ca> From: David Blaikie Date: Mon, 8 Mar 2021 12:39:03 -0800 Message-ID: Subject: Re: GNU style checker for GDB To: Simon Marchi Cc: Zied Guermazi , gdb@sourceware.org X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2021 20:39:16 -0000 If anyone's interested in investing some time in it, I expect clang-format would be open to bugs/patches to support whatever formatting idioms gdb needs. On Mon, Mar 8, 2021 at 10:26 AM Simon Marchi via Gdb wrote: > On 2021-03-08 8:10 a.m., Zied Guermazi wrote: > > hi, > > > > is there a style checker that I can use to detect styles issues before > sending patches to gdb-patches@sourceware.org? > > > > I have the program indent installed on my machine. can it be used for > this purpose? which options shall i use? > > > > Kind Regards > > > > Zied Guermazi > > People try now and then to configure tools to do this, but so > unfortunately so far there is no tool/configuration that matches exactly > the style we use. If I remember correctly, indent does not know C++, so > it's not useful here. clang-format can get quite close, but not enough > so that we can say "just run this and it will be fine". > > To be clear, I really wish there existed such a tool, it would simplify > things a lot. > > Simon > > >