From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id E20A13858D28 for ; Fri, 17 Mar 2023 16:37:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E20A13858D28 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=linaro.org Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdD5K-0005l4-Ga for gdb@gnu.org; Fri, 17 Mar 2023 12:37:45 -0400 Received: by mail-pf1-x432.google.com with SMTP id s8so3364846pfk.5 for ; Fri, 17 Mar 2023 09:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679071061; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bXjDhVXGMhnumxyVHUzpj0olGsdargOsMsFYmhE4nEk=; b=EAsZfvAcqTW192AqI28UuUCFzeJ/Y1isNdi+8QpeTQV9rN8WhBTt2X/dDDGF3EWXq6 cai7r2bikB5MKpJjrEHaOh7JLshA4yOpY8jFo+dQN1H9UG1XIWDbZuOoeTGw2AvE5Cv5 OnZ4M0epayxXujbs32XOfMMrREmJ+dSDXvNBEDlWRwIMBaXbii6ky+zIm6agVq3AseVQ tuQod8byxNUuaTBnPULHyha9edEooAuI6D6mxZ76Ov1k+EY6Cd5OsOSkt9grGKqXQLBb VJBAX9SLko5acaMYFJvSsYOQp2ummKKZZ1HMGBiNzorxjWKz00kvnhjK5JmevZGNXsBC fRcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679071061; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bXjDhVXGMhnumxyVHUzpj0olGsdargOsMsFYmhE4nEk=; b=EPwKXofJ7ycaR8r5xVdOV6/Vvn8bTBiFRRhNgoZ8mgieTESHEsbeXtwfwnQ7dB8RZn rjf2+S0EEV5Q58WFkECFi4F5wTcjJJ+PjrZiD+O9vfqRKU5o4YzQYVHkDXTb3476ci1b Fe+76a88EvINcggn9CGb0pIsETxmt64iY15HJYCKmy7yvF79npbAk+fxOzhwSyU6YmRZ FUxWjMdATYfBtbu+RRQ4BCgUhXigM1NMK2E0fO8+xLaWRYTIa2MqnNTjqnXyL02ufgng qXU05K/OwSR7WbFJXbPD0UzpSi4x8FtNc1DKyarqgqWAjlm4J2KmJtdlhwdqNf4PuhjW thTw== X-Gm-Message-State: AO0yUKWFEgRcCQSqHQutQIlL5F1Z7E6Sxy2b0ZK9iN0iglEekPPCgADP Y2r/NIzhRACOCRZyBmTIBvhvBuyArUwLRJ6o0Y5NZA== X-Google-Smtp-Source: AK7set8rCN/moXRSQZiutfvZ8gC+LveEcdQh80LRcFgwNHE9ebfl7xe5nhSJG73LV00oRxPpkc5p9lHEWXDIeLkZ9dk= X-Received: by 2002:a65:4544:0:b0:4fc:2369:811 with SMTP id x4-20020a654544000000b004fc23690811mr2035530pgr.6.1679071060848; Fri, 17 Mar 2023 09:37:40 -0700 (PDT) MIME-Version: 1.0 References: <20230310103123.2118519-1-alex.bennee@linaro.org> <20230310103123.2118519-10-alex.bennee@linaro.org> <87wn3ocwqz.fsf@suse.de> <87sfeclb8o.fsf@linaro.org> <9bb8ab52-c6ae-95a7-e6c8-64bcce166c19@arm.com> In-Reply-To: From: Peter Maydell Date: Fri, 17 Mar 2023 16:37:29 +0000 Message-ID: Subject: Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests To: Luis Machado Cc: =?UTF-8?B?QWxleCBCZW5uw6ll?= , Fabiano Rosas , qemu-devel@nongnu.org, David Hildenbrand , Wainer dos Santos Moschetta , Richard Henderson , qemu-arm@nongnu.org, Peter Xu , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Cleber Rosa , Thomas Huth , Paolo Bonzini , Beraldo Leal , gdb , Thiago Jung Bauermann , Omair Javaid Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=peter.maydell@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DKIM_VALID_EF=-0.1,RCVD_IN_DNSWL_NONE=-0.0001,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 15 Mar 2023 at 09:51, Luis Machado wrote: > On 3/13/23 11:44, Luis Machado wrote: > > On 3/13/23 11:22, Peter Maydell via Gdb wrote: > >> Luis and I came up with two options: > >> > >> (1) leave QEMU outputting the pauth xml as-is, and tell people > >> whose gdb 12 crashes that they should upgrade to a newer gdb > >> > >> (2) make QEMU output the pauth info under a different XML namespace, > >> and tell people who need backtraces when pauth is enabled > >> that they should upgrade to a newer gdb > >> > >> Neither of these feel great, but on balance I guess 2 is better? > >> > >> Luis: I think that rather than doing (2) with a QEMU namespace, > >> we should define a gdb namespace for this. That makes it clear > >> that this is still a gdb-upstream-sanctioned way of exposing > >> the pauth registers. > > > > That should be fine as well, and would work to side-step the gdb 12 bug so it doesn't crash. > > > > We could name the feature "org.gnu.gdb.aarch64.pauth_v2" or somesuch, and slowly stop using the original > > "org.gnu.gdb.aarch64.pauth" feature. I can document the requirements for a compliant pauth_v2. > > > > FYI, I've pushed a better documentation for the arm/aarch64 xml descriptions here: > > > > https://sourceware.org/git?p=binutils-gdb.git;a=commit;h=d7001b29e9f256dfc60acb481d9df8f91f2ee623 > > https://sourceware.org/git?p=binutils-gdb.git;a=commit;h=e0994165d1b8469dfc27b09b62ac74862d535812 > Just an update on this. I had a chat with Richard Henderson yesterday, and it might actually be easier and more convenient to backport > fixes to older gdb versions (at least gdb-12 and gdb-11, but gdb-10 and gdb-9 are also affected). This will ensure those won't crash when > they connect to a qemu that advertises the pauth feature. > > It also means we won't need qemu-side changes. My understanding is that we're close to the 8.0.0 release, and the code is already in place. Having run into this problem in another couple of situations, one of which involved gdb 10, I think I'm increasingly favouring option 2 here. The affected gdbs seem to be quite widely deployed, and the bug results in crashes even for users who didn't really care about pauth. So I'd rather we didn't release a QEMU 8.0 which crashes these affected deployed gdbs. So: (a) if on the gdb side you can define (within the next week) a suitable new XML name you want QEMU to expose, we can commit a change to switch to that before we do the 8.0 release (b) if that's too tight a timescale, we can commit a patch which just stops QEMU from exposing the pauth.xml, and we can come up with a better solution after 8.0 releases In fact, I think I'm going to submit a patch to do (b) for now and we can follow up with a patch for (a) if we want. thanks -- PMM