From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 3FD583847700; Wed, 3 Apr 2024 09:50:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FD583847700 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3FD583847700 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::630 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712137857; cv=none; b=X4o+uzFigkdaKSuFurtCv31AeOBSmloo3vIsIXIo0XX2QKNQPdEO3GDYBcpflc7HCRD51YdaL+w8mrg2AxO43V9enoS1k6AjDiUR0z1zpnpwpkFRZhRfn3LF3BbziwWomqIAtHg6P0OysUHgQD2V8LmAhT+APFGVfVFJJZpkNKI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712137857; c=relaxed/simple; bh=lNZ3dDIw6N1KmqpkXCUDJV4/cJUrsOLdVgRo7FRKSc8=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=hEckAIiE5ivN5j6pt2lTNtNTl4c6kKA0L9Uk6ETF37nHkRwssQ0f5e+t+0pbNfIS8kalc607BgEOWz6/1Cph4vh3hpAE3wZUnF9cHUx6YmbLqkCW3EPg8rA7ysvjP+6sWcNRXz+guP8T9nr6j/oRydlOOFDai6RYrZCHAq2MQ6w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a46ea03c2a5so141226166b.1; Wed, 03 Apr 2024 02:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712137853; x=1712742653; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=v7tTfANymTZqQ9aqnBcb8XBzWWTASaEIAaNwU9h5kXs=; b=Y/HiZVVegV+VFhLnVUvej/JM2psmtgcdNebE5n6/mzNb3RT2GxxTUAG7MVpxrGcrJF mf/EQGDpGp3vnFNbl5F3VX+tbD1NlYf5Fg/bo/wNo8OWi/Q54LaDcgorHk08TZT/QF6F atdGsaLRyfKJ/WcwilkxHurfixT+a1Wo1q2ztOSmjZU3zOJIKVGzriKwDDK4e5/gKfRC AoAgzzweSW3gj8ks6kskW46umaj3Yyl4e7cvRfROwkD+iP+WRbqFTZ1bDPpMQepBv7HN JCFRTlv/q9SO1pCe2eBK/Di0D0sqACk6hwHi0Ls40XZPIbYlZOaJy1iWFAYeRqwebquI GA2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712137853; x=1712742653; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v7tTfANymTZqQ9aqnBcb8XBzWWTASaEIAaNwU9h5kXs=; b=Eqhjj4H1HqsI1ivxnlyOXDOmDfZ/Fym4iDXNKMB8jnJjwuZa640ig2Zz8/PHZFIAsU hbvjKJQ1sFBYdb5Iqeqp1pZMefQqnQODTyzNJ57wGT1sZH+sG7LvaVP0X+/Hzv+Ds5dI hur3aPIoIvbypZ4y/aTTZeN0HQg57576IGV/tjTP8+5LjmxErV4Fd7hvM4X6Byjmhfnl qERz+j0B00jdjuK6s+yyskxmpmNtCFr0+P1fGu6hK3pUQR1+xnbTePhxHU8VoWXD3k/q XLcnc8cbqc4xeq1zXfOMZexamSG3uQF5kjEHeTiIVk+arBzRVcccV5hlAHTUaftW5OEN JwSg== X-Forwarded-Encrypted: i=1; AJvYcCVVFis79KP09YHSzMM7CpM9VMxkZ4WJt2bSy/OJ5IEhtZFgPrF0L7i7IskgRZpqT1JqYyDHcivNGEiaAIbiDWs3LvYHXdDDShvo6J1zPjQX7aktb7Jka3+1BvEd X-Gm-Message-State: AOJu0Yzd1yu1sQPHEZFcERKQX+UvKJfFV2cYflH0jhZeq9fdVdLLyGUO UTWrLoFyQX13+ddDnnByRiFdQiL9A4cRns/VHVLLAykn3qUwbkv2VjGKNSPoZBk7GdxFaShc6kW +hXSGKxvp/qt2yM98en5X/IhoN8w= X-Google-Smtp-Source: AGHT+IGbjrcJgVfgG1ccnBQORJIeNzmAEGq8qZ0JZEuYew9fedvlM28FYz/LmMyrWE3HB96dDBXsJElYPzFwmqTPSXM= X-Received: by 2002:a17:906:d216:b0:a4e:24e6:9880 with SMTP id w22-20020a170906d21600b00a4e24e69880mr1690562ejz.33.1712137852701; Wed, 03 Apr 2024 02:50:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Wed, 3 Apr 2024 10:50:41 +0100 Message-ID: Subject: Re: Patches submission policy change To: Jakub Jelinek Cc: Christophe Lyon , binutils@sourceware.org, GCC Mailing List , gdb@sourceware.org, Nick Clifton , Richard Biener , Joel Brobecker , "Carlos O'Donell" , Maxim Kuvyrkov , Thiago Bauermann , Adhemerval Zanella Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 3 Apr 2024 at 09:46, Jakub Jelinek via Gcc wrote: > > On Wed, Apr 03, 2024 at 10:22:24AM +0200, Christophe Lyon wrote: > > Any concerns/objections? > > I'm all for it, in fact I've been sending it like that myself for years > even when the policy said not to. In most cases, the diff for the > regenerated files is very small and it helps even in patch review to > actually check if the configure.ac/m4 etc. changes result just in the > expected changes and not some unrelated ones (e.g. caused by user using > wrong version of autoconf/automake etc.). > There can be exceptions, e.g. when in GCC we update from a new version > of Unicode, the regenerated ucnid.h diff can be large and > uname2c.h can be huge, such that it can trigger the mailing list size > limits even when the patch is compressed, see e.g. > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636427.html > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636426.html > But I think most configure or Makefile changes should be pretty small, > usual changes shouldn't rewrite everything in those files. For libstdc++ we've had two "large" changes to regenerated files in the past year, but they're not common: https://gcc.gnu.org/r14-5424-gdb50aea6259545 https://gcc.gnu.org/r14-5342-g898fd81b831c10 We were getting large, useless diffs for libstdc++-v3/include/bits/version.h too (e.g. r14-7220-gac1a399bf61b04) but I've fixed that now. In ye olde days I used filterdiff to strip the generated files from patch submissions, but with git send-email I no longer use filterdiff, so as Christophe said, the suggested policy would avoid manually editing emails before sending. I don't feel strongly either way, but I have no objection to the change.