From: Jeffrey Walton <noloader@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: i.nixman@autistici.org, gdb@sourceware.org
Subject: Re: _WIN32_WINNT redefined?
Date: Wed, 2 Nov 2022 09:10:21 -0400 [thread overview]
Message-ID: <CAH8yC8mFh8Kde9OGd-uGCv5EDDRw+SnR+pHzm41dPW-Zpc8HrA@mail.gmail.com> (raw)
In-Reply-To: <83zgd9a4w7.fsf@gnu.org>
On Wed, Nov 2, 2022 at 9:02 AM Eli Zaretskii via Gdb <gdb@sourceware.org> wrote:
>
> > Date: Wed, 02 Nov 2022 10:15:01 +0000
> > X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
> > DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS,
> > TXREP autolearn=ham autolearn_force=no version=3.4.6
> > From: niXman via Gdb <gdb@sourceware.org>
> >
> > On 2022-11-02 09:46, niXman via Gdb wrote:
> > > On 2022-11-02 08:44, niXman via Gdb wrote:
> > >> On 2022-11-02 08:21, niXman via Gdb wrote:
> > >
> > > ok, I did a little research.
> > >
> > > the `_WIN32_WINNT` is defined in `gdbsupport/common-defs.h` only, but
> > > referenced in `gnulib/import/gettimeofdeay.c` and
> > > `gnulib/import/stat-w32.c` only, but not directly because those files
> > > include `windows,h` and `sdkdkver.h`. thus that `_WIN32_WINNT` define
> > > is never used!
> > >
> > > so I think the best way is to remove that define completely.
> > >
> > >
> > > ideas?
> >
> > right, with commented out the entire PP block the build was successful!
>
> This is the wrong solution, IMO.
Here's what Microsoft has to say about it:
https://learn.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt
"
To modify the macros, in a header file (for example, in targetver.h,
which is included by some project templates that target Windows),
add the following lines.
#define WINVER 0x0A00
#define _WIN32_WINNT 0x0A00
If I am reading that correctly, there should be a common header file
which defines WINVER and _WIN32_WINNT. In my old MFC days, we would
set it in a file like <stdafx.h> . In a non-MFC project, we would set
it under the Visual Studio preprocessor macros, which is just
CPPFLAGS.
Maybe there needs to be a configure option to set the values.
Configure would then create the header file with the values. If the
configure option is not supplied, then use a sane default value and
create the header file.
Jeff
next prev parent reply other threads:[~2022-11-02 13:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 8:14 i.nixman
2022-11-02 8:21 ` i.nixman
2022-11-02 8:44 ` i.nixman
2022-11-02 9:46 ` i.nixman
2022-11-02 10:15 ` i.nixman
2022-11-02 12:59 ` Eli Zaretskii
2022-11-02 13:10 ` Jeffrey Walton [this message]
2022-11-02 13:26 ` Eli Zaretskii
2022-11-02 12:50 ` Eli Zaretskii
2022-11-02 14:13 ` i.nixman
2022-11-02 15:18 ` Eli Zaretskii
2022-11-02 15:51 ` i.nixman
2022-11-02 16:02 ` i.nixman
2022-11-02 16:51 ` Eli Zaretskii
2022-11-02 17:20 ` i.nixman
2022-11-02 18:13 ` Eli Zaretskii
2022-11-02 12:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH8yC8mFh8Kde9OGd-uGCv5EDDRw+SnR+pHzm41dPW-Zpc8HrA@mail.gmail.com \
--to=noloader@gmail.com \
--cc=eliz@gnu.org \
--cc=gdb@sourceware.org \
--cc=i.nixman@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).