From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12698 invoked by alias); 29 Nov 2011 03:25:57 -0000 Received: (qmail 12678 invoked by uid 22791); 29 Nov 2011 03:25:56 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-iy0-f169.google.com (HELO mail-iy0-f169.google.com) (209.85.210.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Nov 2011 03:25:43 +0000 Received: by iaek3 with SMTP id k3so12421714iae.0 for ; Mon, 28 Nov 2011 19:25:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.50.180.193 with SMTP id dq1mr53301472igc.34.1322537142406; Mon, 28 Nov 2011 19:25:42 -0800 (PST) Received: by 10.50.186.228 with HTTP; Mon, 28 Nov 2011 19:25:42 -0800 (PST) In-Reply-To: <20111128153809.GB17887@adacore.com> References: <87wrak63cd.fsf@gmail.com> <20111128153809.GB17887@adacore.com> Date: Tue, 29 Nov 2011 03:25:00 -0000 Message-ID: Subject: Re: Two quick questions From: Andrey Smirnov To: Joel Brobecker Cc: gdb@sourceware.org, cgf-use-the-mailinglist-please@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00124.txt.bz2 On Mon, Nov 28, 2011 at 10:38 PM, Joel Brobecker wr= ote: >> =A0 =A0 =A01. Since neither >> =A0 =A0 =A0http://www.sourceware.org/gdb/current/onlinedocs/gdbint/Codin= g-Standards.html >> =A0 =A0 =A0nor http://sourceware.org/gdb/wiki/JoelsCodingStyleCheatSheet >> =A0 =A0 =A0mentions this, or at least yours myopic truly haven't noticed= it, >> =A0 =A0 =A0I wonder what is the GDB's allegiance in the Tabs, Spaces, Ta= bs + >> =A0 =A0 =A0Spaces holy war? Who are the infidels we must crush? :) The >> =A0 =A0 =A0reason I'm asking is that I don't want to generate false diffs >> =A0 =A0 =A0just because I re-indented the line in different style. > > We use tabs mostly, optionally followed by spaces if a line of code > doesn't exactly start at a tabulation. So Tabs + Spaces, OK. > Although it's perfectly fine > to tabify a line of code that you're modifying, I would personally > prefer that you don't touch lines just for the sake of tabifying. > Others might disagree (hence the "personally"), but these little > changes don't bring anything in terms of readability, mess up the > indentation when reading diffs, and also potentially create merge > conflicts for changes that are essentially no-ops. > Oh no, that not the meaning I was trying to convey in my message, I'm sorry I wasn't very clear and was misconstrued. I was asking exactly because I wanted avoid generated unnecessary "junk" in the patches just because I idly hit the tab on some line in the code an my editor re-indented it differently(for example with all spaces, which is default for me now) while writing a patch. It is just that I've already seen one such occurrence in one of my patches and I would like to avoid having them in further ones. So, just to be clear, I'm neither planning nor thinking about planning to re-indent the code. Andrey Smirnov