From: "H.J. Lu" <hjl.tools@gmail.com>
To: Alan Modra <amodra@gmail.com>
Cc: Mark Wielaard <mark@klomp.org>,
Luis Machado <luis.machado@arm.com>,
"gdb@sourceware.org" <gdb@sourceware.org>,
Overseers mailing list <overseers@sourceware.org>,
"Frank Ch. Eigler" <fche@elastic.org>,
Binutils <binutils@sourceware.org>
Subject: [PATCH] x86: Disable 2 tests with large memory requirement
Date: Wed, 27 Apr 2022 11:32:41 -0700 [thread overview]
Message-ID: <CAMe9rOppFL7kiYOPyApPtr6BWWqnEsfKcakFJdUMSM4qtxwj9Q@mail.gmail.com> (raw)
In-Reply-To: <YmiBOSnM3jbQSbn3@squeak.grove.modra.org>
[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]
On Tue, Apr 26, 2022 at 4:33 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Tue, Apr 26, 2022 at 08:54:49AM -0700, H.J. Lu wrote:
> > On Mon, Apr 25, 2022 at 8:33 PM Alan Modra <amodra@gmail.com> wrote:
> > >
> > > On Mon, Apr 25, 2022 at 08:20:50PM +0200, Mark Wielaard wrote:
> > > > I think we should try to keep builds/checks under 10 minutes, that the
> > >
> > > Related to that, there are some x86_64 gas and ld tests that I find to
> > > be annoying resource hogs when running multiple binutils target builds
> > > in parallel. gas/testsuite/gas/i386/rept and
> > > ld/testsuite/ld-x86-64/pr17618 both require over 1G of memory.
> > >
> > > HJ, would you please look at reducing the memory footprint of those
> > > test?
> >
> > These tests check if large memory footprints are handed properly.
> > What do you recommend?
>
> Delete the gas test. For the ld plt overflow test, don't use .space
> in the .s file to create a huge .text section, instead use a linker
> script to place sections so as to cause the address overflow. Or just
> delete the ld test too. What future failure does it prevent? Someone
> deleting the plt overflow checks?
>
>
I am disabling these tests.
--
H.J.
[-- Attachment #2: 0001-x86-Disable-2-tests-with-large-memory-requirement.patch --]
[-- Type: text/x-patch, Size: 1470 bytes --]
From 69f1317da0d9781c13dbf91a607f4bc80cfcf638 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 27 Apr 2022 11:26:44 -0700
Subject: [PATCH] x86: Disable 2 tests with large memory requirement
gas/
* testsuite/gas/i386/i386.exp: Disable rept.
ld/
* testsuite/ld-x86-64/x86-64.exp: Disable pr17618.
---
gas/testsuite/gas/i386/i386.exp | 3 ++-
ld/testsuite/ld-x86-64/x86-64.exp | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/gas/testsuite/gas/i386/i386.exp b/gas/testsuite/gas/i386/i386.exp
index 2c84ccc62b4..1e10277da31 100644
--- a/gas/testsuite/gas/i386/i386.exp
+++ b/gas/testsuite/gas/i386/i386.exp
@@ -726,7 +726,8 @@ run_list_test "string-bad" ""
run_list_test "reg-bad" ""
run_list_test "space1" "-al"
run_list_test "xmmword" ""
-run_dump_test rept
+# Disabled due to large memory requirement.
+# run_dump_test rept
run_dump_test pr19498
run_list_test "nop-bad-1" ""
run_list_test "unspec" ""
diff --git a/ld/testsuite/ld-x86-64/x86-64.exp b/ld/testsuite/ld-x86-64/x86-64.exp
index f337b485901..1a7d1eddc97 100644
--- a/ld/testsuite/ld-x86-64/x86-64.exp
+++ b/ld/testsuite/ld-x86-64/x86-64.exp
@@ -2314,8 +2314,8 @@ run_ld_link_tests [list \
] \
]
-# Linux only tests
-if { "$LD_CLASS" == "64bit" } then {
+# Linux only tests. Disabled due to large memory requirement.
+if { "x$LD_CLASS" == "64bit" } then {
# This test needs 64-bit linker.
run_dump_test "pr17618"
}
--
2.35.1
next prev parent reply other threads:[~2022-04-27 18:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YmZkKRO+yUHeFqV0@wildebeest.org>
2022-04-25 10:37 ` Adding binutils to the GNU Toolchain buildbot on sourceware Luis Machado
2022-04-25 10:43 ` Frank Ch. Eigler
2022-04-25 12:16 ` Luis Machado
2022-04-25 12:30 ` Frank Ch. Eigler
2022-04-25 18:20 ` Mark Wielaard
2022-04-25 18:27 ` Frank Ch. Eigler
2022-04-25 22:11 ` Mark Wielaard
2022-04-26 3:33 ` Alan Modra
2022-04-26 6:22 ` Jan Beulich
2022-04-26 12:27 ` Nick Clifton
2022-04-26 13:49 ` Jan Beulich
2022-04-26 15:47 ` H.J. Lu
2022-04-27 6:15 ` Jan Beulich
2022-04-28 12:10 ` Nick Clifton
2022-04-28 13:07 ` Jan Beulich
2022-04-26 15:54 ` H.J. Lu
2022-04-26 23:33 ` Alan Modra
2022-04-27 18:32 ` H.J. Lu [this message]
2022-04-26 7:01 ` Luis Machado
2022-04-26 9:40 ` Frank Ch. Eigler
2022-04-26 22:59 ` Mark Wielaard
2022-04-26 22:34 ` Mark Wielaard
2022-04-28 12:23 ` Luis Machado
2022-04-28 13:50 ` Frank Ch. Eigler
2022-04-28 13:53 ` Luis Machado
2022-04-28 14:22 ` Frank Ch. Eigler
2022-04-28 17:04 ` Mark Wielaard
2022-04-28 14:48 ` Mark Wielaard
2022-04-28 14:19 ` Mark Wielaard
2022-04-28 14:47 ` Thomas Fitzsimmons
2022-04-28 16:28 ` Mark Wielaard
2022-04-29 20:04 ` gdb builder status (Was: Adding binutils to the GNU Toolchain buildbot on sourceware) Mark Wielaard
2022-05-01 19:44 ` Mark Wielaard
2022-05-03 15:41 ` Simon Marchi
2022-05-13 8:21 ` Mark Wielaard
2022-04-28 17:50 ` Adding binutils to the GNU Toolchain buildbot on sourceware Nick Alcock
2022-04-29 17:54 ` Mark Wielaard
2022-04-30 0:12 ` Nick Alcock
2022-04-30 22:27 ` Mark Wielaard
2022-05-03 12:48 ` Nick Alcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOppFL7kiYOPyApPtr6BWWqnEsfKcakFJdUMSM4qtxwj9Q@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=fche@elastic.org \
--cc=gdb@sourceware.org \
--cc=luis.machado@arm.com \
--cc=mark@klomp.org \
--cc=overseers@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).