From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4155 invoked by alias); 30 Oct 2012 13:32:54 -0000 Received: (qmail 4131 invoked by uid 22791); 30 Oct 2012 13:32:51 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-da0-f41.google.com (HELO mail-da0-f41.google.com) (209.85.210.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Oct 2012 13:32:43 +0000 Received: by mail-da0-f41.google.com with SMTP id i14so134488dad.0 for ; Tue, 30 Oct 2012 06:32:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.217.67 with SMTP id ow3mr103148726pbc.26.1351603962399; Tue, 30 Oct 2012 06:32:42 -0700 (PDT) Received: by 10.68.19.138 with HTTP; Tue, 30 Oct 2012 06:32:42 -0700 (PDT) In-Reply-To: <508FCA04.6010600@codesourcery.com> References: <1350881426-4945-1-git-send-email-yao@codesourcery.com> <508F3B88.8060701@codesourcery.com> <508F578F.8050807@codesourcery.com> <508FCA04.6010600@codesourcery.com> Date: Tue, 30 Oct 2012 13:32:00 -0000 Message-ID: Subject: Re: [rfc] bi-arch for x86-64 corefile. From: "H.J. Lu" To: Yao Qi Cc: binutils@sourceware.org, "gdb@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00114.txt.bz2 On Tue, Oct 30, 2012 at 5:37 AM, Yao Qi wrote: > On 10/30/2012 03:21 PM, H.J. Lu wrote: >> >> I am checking in this. But sourceware.org times out for me. Please >> give it a try. >> > > H.J., it works for me! Thanks for the review and checking it in. > >> diff --git a/bfd/configure b/bfd/configure >> index fdf5356..427e5c1 100755 >> --- a/bfd/configure >> +++ b/bfd/configure >> @@ -13927,6 +13927,10 @@ if test "${target}" = "${host}"; then >> >> i[3-7]86-*-linux-*) >> COREFILE=trad-core.lo >> TRAD_HEADER='"hosts/i386linux.h"' >> + case "$enable_targets" in >> + *x86_64-*linux*) >> + CORE_HEADER='"hosts/x86-64linux.h"' >> + esac >> >> ;; >> i[3-7]86-*-isc*) COREFILE=trad-core.lo ;; >> i[3-7]86-*-aix*) COREFILE=aix386-core.lo ;; > > > This part is a little different from my original patch, which is > > > + if test x${want64} = xtrue ; then > + CORE_HEADER='"hosts/x86-64linux.h"' > + fi > > This requires something different in configure options. In my previous > patch, when configure i686-pc-linux-gnu-gdb to handle bi-arch, we run > configure with '--enable-64-bit-bfd'. In current trunk (w/ your patch), we > have to run configure with '--enable-targets=x86_64-pc-linux-gnu'. I checked in this patch. -- H.J. ---- diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 56b40c5..00f63f2 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2012-10-30 H.J. Lu + + * configure.in: Also handle --enable-64-bit-bfd when setting + CORE_HEADER for 'i[3-7]86-*-linux-*'. + 2012-10-30 Steve McIntyre * elf32-arm.c (elf32_arm_print_private_bfd_data): Recognise and diff --git a/bfd/configure b/bfd/configure index 427e5c1..43bff03 100755 --- a/bfd/configure +++ b/bfd/configure @@ -13927,8 +13927,8 @@ if test "${target}" = "${host}"; then i[3-7]86-*-linux-*) COREFILE=trad-core.lo TRAD_HEADER='"hosts/i386linux.h"' - case "$enable_targets" in - *x86_64-*linux*) + case "$enable_targets"-"$want64" in + *x86_64-*linux*|*-true) CORE_HEADER='"hosts/x86-64linux.h"' esac ;; diff --git a/bfd/configure.in b/bfd/configure.in index 9a31c04..6261aab 100644 --- a/bfd/configure.in +++ b/bfd/configure.in @@ -331,8 +331,8 @@ changequote(,)dnl changequote([,])dnl COREFILE=trad-core.lo TRAD_HEADER='"hosts/i386linux.h"' - case "$enable_targets" in - *x86_64-*linux*) + case "$enable_targets"-"$want64" in + *x86_64-*linux*|*-true) CORE_HEADER='"hosts/x86-64linux.h"' esac ;;