From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19272 invoked by alias); 9 Apr 2015 11:47:12 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 19261 invoked by uid 89); 9 Apr 2015 11:47:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f176.google.com Received: from mail-ob0-f176.google.com (HELO mail-ob0-f176.google.com) (209.85.214.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 09 Apr 2015 11:47:10 +0000 Received: by obbry2 with SMTP id ry2so9088131obb.1 for ; Thu, 09 Apr 2015 04:47:09 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.227.132 with SMTP id sa4mr38457410obc.40.1428580028942; Thu, 09 Apr 2015 04:47:08 -0700 (PDT) Received: by 10.76.54.14 with HTTP; Thu, 9 Apr 2015 04:47:08 -0700 (PDT) In-Reply-To: References: Date: Thu, 09 Apr 2015 11:47:00 -0000 Message-ID: Subject: Re: Invalid use of $zlibdir within GDB_AC_CHECK_BFD From: "H.J. Lu" To: Ilya Malakhov Cc: GDB Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-04/txt/msg00022.txt.bz2 On Thu, Apr 9, 2015 at 1:14 AM, Ilya Malakhov wrote: > Hi, > > The use of $zlibdir when setting LDFLAGS within GDB_AC_CHECK_BFD in > gdb/acinclude.m4 seems to be incorrect unless gdb is configured > `--with-system > -zlib'. At configure time it becomes (see config/zlib.m4) > > -L$(top_builddir)/../zlib > > with $(top_builddir) being a make(!) variable. This makes a number of > gdb/configure > tests fail unless a user has got an installed system zlib for the host of > GDB. As a result, > one may quite unexpectedly obtain GDB without ELF support. > I checked in this patch to fix it. -- H.J. --- >From 5a2d4533e2b9cc9c069d47071013cb30f1e0fc7e Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Thu, 9 Apr 2015 04:43:57 -0700 Subject: [PATCH] Replace $zlibdir with $ZLIBDIR in LDFLAGS * acinclude.m4: (GDB_AC_CHECK_BFD): Set ZLIBDIR with $zlibdir. Replace $zlibdir with $ZLIBDIR in LDFLAGS. * configure: Regenerated. --- gdb/ChangeLog | 6 ++++++ gdb/acinclude.m4 | 3 ++- gdb/configure | 6 ++++-- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 73a32a9..84d437f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2015-04-09 H.J. Lu + + * acinclude.m4: (GDB_AC_CHECK_BFD): Set ZLIBDIR with $zlibdir. + Replace $zlibdir with $ZLIBDIR in LDFLAGS. + * configure: Regenerated. + 2015-04-09 Pedro Alves * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add strtok_r. diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4 index 98ae85f..845e65f 100644 --- a/gdb/acinclude.m4 +++ b/gdb/acinclude.m4 @@ -465,7 +465,8 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [ # points somewhere with bfd, with -I/foo/lib and -L/foo/lib. We # always want our bfd. CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS" - LDFLAGS="-L../bfd -L../libiberty $zlibdir $LDFLAGS" + ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'` + LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS" intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'` LIBS="-lbfd -liberty -lz $intl $LIBS" AC_CACHE_CHECK([$1], [$2], diff --git a/gdb/configure b/gdb/configure index f835157..2baf6dd 100755 --- a/gdb/configure +++ b/gdb/configure @@ -13526,7 +13526,8 @@ esac # points somewhere with bfd, with -I/foo/lib and -L/foo/lib. We # always want our bfd. CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS" - LDFLAGS="-L../bfd -L../libiberty $zlibdir $LDFLAGS" + ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'` + LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS" intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'` LIBS="-lbfd -liberty -lz $intl $LIBS" { $as_echo "$as_me:${as_lineno-$LINENO}: checking for ELF support in BFD" >&5 @@ -13636,7 +13637,8 @@ fi # points somewhere with bfd, with -I/foo/lib and -L/foo/lib. We # always want our bfd. CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS" - LDFLAGS="-L../bfd -L../libiberty $zlibdir $LDFLAGS" + ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'` + LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS" intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'` LIBS="-lbfd -liberty -lz $intl $LIBS" { $as_echo "$as_me:${as_lineno-$LINENO}: checking for Mach-O support in BFD" >&5 --