From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27276 invoked by alias); 5 Dec 2012 12:22:48 -0000 Received: (qmail 27263 invoked by uid 22791); 5 Dec 2012 12:22:46 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-bk0-f41.google.com (HELO mail-bk0-f41.google.com) (209.85.214.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Dec 2012 12:22:38 +0000 Received: by mail-bk0-f41.google.com with SMTP id jg9so2285102bkc.0 for ; Wed, 05 Dec 2012 04:22:37 -0800 (PST) Received: by 10.204.12.220 with SMTP id y28mr5517358bky.112.1354710156818; Wed, 05 Dec 2012 04:22:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.205.32.12 with HTTP; Wed, 5 Dec 2012 04:21:56 -0800 (PST) In-Reply-To: <20121205120845.GA31696@Krystal> References: <20121205120845.GA31696@Krystal> From: Hui Zhu Date: Wed, 05 Dec 2012 12:22:00 -0000 Message-ID: Subject: Re: [lttng-dev] Request change name of function lookup_enum in libbabeltrace to make GDB use this lib To: Mathieu Desnoyers Cc: Julien Desfossez , lttng-dev , Tom Tromey , gdb@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00021.txt.bz2 On Wed, Dec 5, 2012 at 8:08 PM, Mathieu Desnoyers wrote: > * Hui Zhu (teawater@gmail.com) wrote: >> Hi, >> >> I am working on add CTF support to GDB. You can see my patch review threads in: >> http://sourceware.org/ml/gdb-patches/2012-11/msg00552.html >> http://sourceware.org/ml/gdb-patches/2012-11/msg00554.html >> http://sourceware.org/ml/gdb-patches/2012-11/msg00553.html >> http://sourceware.org/ml/gdb-patches/2012-11/msg00555.html >> http://sourceware.org/ml/gdb-patches/2012-11/msg00556.html >> >> To make GDB support CTF read, I use libbabeltrace with GDB. You can >> see the patch in >> http://sourceware.org/ml/gdb-patches/2012-11/msg00555.html. >> I have a issue is libbabeltrace have a function called lookup_enum >> that is same with a GDB function. >> I change the function name of GDB to handle this issue in my patch. >> >> But Tom said let libbabeltrace to change function name is better. >> So I send this mail to ask do you mind change the function name of >> lookup_enum? If you can change the function name that will be really >> helpful for us. Thanks a lot. >> And I post a patch about change the function name in libbabeltrace. > > I'm CCing Julien Desfossez on this one. From what I see, > include/babeltrace/types.h is not included into the system, so it should > not be considered to be a public header of libbabeltrace. > > Julien, is there an publically exposed babeltrace API that performs > something similar to the internal lookup_enum() ? > > Hui, are you using other functions from include/babeltrace/types.h ? No, my patch didn't use any function in this file. Thanks, Hui > > Thanks, > > Mathieu > >> >> Thanks, >> Hui >> >> --- a/formats/ctf/ctf.c >> +++ b/formats/ctf/ctf.c >> @@ -423,7 +423,7 @@ int ctf_read_event(struct stream_pos *pp >> } else { >> struct definition_enum *enum_definition; >> >> - enum_definition = lookup_enum(&stream->stream_event_header->p, "id", FALSE); >> + enum_definition = ctf_lookup_enum(&stream->stream_event_header->p, >> "id", FALSE); >> if (enum_definition) { >> id = enum_definition->integer->value._unsigned; >> } >> --- a/include/babeltrace/types.h >> +++ b/include/babeltrace/types.h >> @@ -513,7 +513,7 @@ struct definition *lookup_definition(con >> struct definition_integer *lookup_integer(const struct definition *definition, >> const char *field_name, >> int signedness); >> -struct definition_enum *lookup_enum(const struct definition *definition, >> +struct definition_enum *ctf_lookup_enum(const struct definition *definition, >> const char *field_name, >> int signedness); >> struct definition *lookup_variant(const struct definition *definition, >> --- a/types/types.c >> +++ b/types/types.c >> @@ -634,7 +634,7 @@ struct definition_integer *lookup_intege >> return lookup_integer; >> } >> >> -struct definition_enum *lookup_enum(const struct definition *definition, >> +struct definition_enum *ctf_lookup_enum(const struct definition *definition, >> const char *field_name, >> int signedness) >> { >> >> _______________________________________________ >> lttng-dev mailing list >> lttng-dev@lists.lttng.org >> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev > > -- > Mathieu Desnoyers > Operating System Efficiency R&D Consultant > EfficiOS Inc. > http://www.efficios.com