From: Hui Zhu <teawater@gmail.com>
To: Julien Desfossez <jdesfossez@efficios.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
tromey@redhat.com, gdb@sourceware.org,
lttng-dev@lists.lttng.org, palves@redhat.com
Subject: Re: [lttng-dev] [BABELTRACE PATCH] Namespace the lookup_enum function
Date: Fri, 25 Jan 2013 11:17:00 -0000 [thread overview]
Message-ID: <CANFwon2ThqwK+HJUxoiKn+Q6nzMtCk6MgXR=xDiEWk4rnEuO3Q@mail.gmail.com> (raw)
In-Reply-To: <510172B7.1090908@efficios.com>
Hi Julien and Mathieu,
I just tried it with GDB ctf patches. It works very good.
Thanks for your help.
Best,
Hui
On Fri, Jan 25, 2013 at 1:43 AM, Julien Desfossez
<jdesfossez@efficios.com> wrote:
> For info, this patch was merged in Babeltrace master, see commit
> 9e3274b092343c999fcde33854d2df37b3702496
>
> Thanks,
>
> Julien
>
> On 13/01/13 12:57 PM, Mathieu Desnoyers wrote:
>> * Julien Desfossez (jdesfossez@efficios.com) wrote:
>>> This patch namespaces the lookup_enum function because it causes problem
>>> with the integration in gdb even though it is not exported.
>>> Hui, can you try this patch and confirm it solves the current problem ?
>>> After that we will continue the internal namespacing.
>>
>> Hi Julien,
>>
>> Since we know these changes are needed, can you provide patches with
>> proper changelogs, and I'll pull them.
>>
>> Thanks,
>>
>> Mathieu
>>
>>>
>>> Thanks,
>>>
>>> Julien
>>> ---
>>> formats/ctf/ctf.c | 2 +-
>>> include/babeltrace/types.h | 2 +-
>>> types/types.c | 2 +-
>>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/formats/ctf/ctf.c b/formats/ctf/ctf.c
>>> index 18a5601..a8f8408 100644
>>> --- a/formats/ctf/ctf.c
>>> +++ b/formats/ctf/ctf.c
>>> @@ -431,7 +431,7 @@ int ctf_read_event(struct stream_pos *ppos, struct ctf_stream_definition *stream
>>> } else {
>>> struct definition_enum *enum_definition;
>>>
>>> - enum_definition = lookup_enum(&stream->stream_event_header->p, "id", FALSE);
>>> + enum_definition = bt_lookup_enum(&stream->stream_event_header->p, "id", FALSE);
>>> if (enum_definition) {
>>> id = enum_definition->integer->value._unsigned;
>>> }
>>> diff --git a/include/babeltrace/types.h b/include/babeltrace/types.h
>>> index b42ba03..00c928b 100644
>>> --- a/include/babeltrace/types.h
>>> +++ b/include/babeltrace/types.h
>>> @@ -521,7 +521,7 @@ struct definition *lookup_definition(const struct definition *definition,
>>> struct definition_integer *lookup_integer(const struct definition *definition,
>>> const char *field_name,
>>> int signedness);
>>> -struct definition_enum *lookup_enum(const struct definition *definition,
>>> +struct definition_enum *bt_lookup_enum(const struct definition *definition,
>>> const char *field_name,
>>> int signedness);
>>> struct definition *lookup_variant(const struct definition *definition,
>>> diff --git a/types/types.c b/types/types.c
>>> index 5599027..139e318 100644
>>> --- a/types/types.c
>>> +++ b/types/types.c
>>> @@ -642,7 +642,7 @@ struct definition_integer *lookup_integer(const struct definition *definition,
>>> return lookup_integer;
>>> }
>>>
>>> -struct definition_enum *lookup_enum(const struct definition *definition,
>>> +struct definition_enum *bt_lookup_enum(const struct definition *definition,
>>> const char *field_name,
>>> int signedness)
>>> {
>>> --
>>> 1.7.10.4
>>>
>>
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next prev parent reply other threads:[~2013-01-25 11:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 11:38 Request change name of function lookup_enum in libbabeltrace to make GDB use this lib Hui Zhu
2012-12-05 12:08 ` [lttng-dev] " Mathieu Desnoyers
2012-12-05 12:22 ` Hui Zhu
2012-12-06 15:57 ` Pedro Alves
2012-12-06 16:21 ` Pedro Alves
2012-12-06 16:25 ` Mathieu Desnoyers
2012-12-10 8:31 ` Hui Zhu
2012-12-10 14:05 ` Mathieu Desnoyers
2012-12-11 15:19 ` Hui Zhu
2012-12-20 13:47 ` Hui Zhu
2012-12-20 14:16 ` Mathieu Desnoyers
2012-12-21 2:58 ` Hui Zhu
2013-01-07 21:19 ` Mathieu Desnoyers
2013-01-09 19:48 ` [BABELTRACE PATCH] Namespace the lookup_enum function Julien Desfossez
2013-01-13 17:58 ` Mathieu Desnoyers
2013-01-24 17:43 ` [lttng-dev] " Julien Desfossez
2013-01-25 11:17 ` Hui Zhu [this message]
2012-12-06 10:51 ` Request change name of function lookup_enum in libbabeltrace to make GDB use this lib John Gilmore
2012-12-06 12:13 ` Hui Zhu
2012-12-06 15:38 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANFwon2ThqwK+HJUxoiKn+Q6nzMtCk6MgXR=xDiEWk4rnEuO3Q@mail.gmail.com' \
--to=teawater@gmail.com \
--cc=gdb@sourceware.org \
--cc=jdesfossez@efficios.com \
--cc=lttng-dev@lists.lttng.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).