From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nkulikov@gmail.com>
Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com
 [IPv6:2607:f8b0:4864:20::635])
 by sourceware.org (Postfix) with ESMTPS id D7F3B385EC44
 for <gdb@sourceware.org>; Wed, 26 Jan 2022 07:30:45 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D7F3B385EC44
Received: by mail-pl1-x635.google.com with SMTP id y17so11256254plg.7
 for <gdb@sourceware.org>; Tue, 25 Jan 2022 23:30:45 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=angZsSjZw45kLyG1N7E8qtRp20f374rtJzWrD+wESB8=;
 b=qFNc0B5RWbKFQAeERba+dn10/al2wtsdr/Aj/sroUG19MvMmlO5zPaiGlp7PzKeevc
 eLCEwNTvQuNUMkQIfcbY62Q7UHhKH8I6GzNs/MlOw3Nc4qsDZKSmvZsgvlTjltmryOmE
 /M0ePb9nxpHgvGmcZfZU20Rz5aGF8bFG8YTNt9Maa4RejBKTOd8U1CkYP1F0cdqAzAnH
 rBz0aGfw/JgBsWxY8xf97pPYHomILjkXESDd0gFxFYSAyWcB9vrnqqZxlUgB09J5AtUr
 iiD6ZpaReQPr45lsWOGUkg6OIuuwSP+Zxj474vHzsYQ9h9K6nSrtKyuTySr+KxvsGzFv
 fH4g==
X-Gm-Message-State: AOAM530DYhNsKDRlbiMUlnAwArmcOxu4o0jYDpQEATp53VRdY4NRHqZf
 H0YYnDy6k/+JuDPBsioz2oRotZ2j5tHlEsXQ2zgqKBPd8BM=
X-Google-Smtp-Source: ABdhPJwKbifY2Zfz6qZL9vgcyxASMz02RRq4g5Iwtly3kcVCmL3z+6eSnvuvSUUoO+cma1KRneMP35ho86ND5YVKAVA=
X-Received: by 2002:a17:90b:17c7:: with SMTP id
 me7mr7428454pjb.166.1643182244767; 
 Tue, 25 Jan 2022 23:30:44 -0800 (PST)
MIME-Version: 1.0
From: Nicholas Kulikov <nkulikov@gmail.com>
Date: Wed, 26 Jan 2022 10:30:33 +0300
Message-ID: <CAOOM2W1kxEx0DWfj0fe2PNzRjxZK8mnhfWApSoMRKtVRGT74=g@mail.gmail.com>
Subject: tdesc_get_features_xml() logic
To: gdb@sourceware.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb mailing list <gdb.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb>,
 <mailto:gdb-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb>,
 <mailto:gdb-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jan 2022 07:30:47 -0000

Hello,

What is the idea to check the precondition `tdesc->xmltarget != NULL`
in assert while there is (the code below) conditional logic which
handles this case? Do I miss something or there is a flaw in assert
logic?

gdbserver/tdesc.cc:

const char *
tdesc_get_features_xml (const target_desc *tdesc)
{
  /* Either .xmltarget or .features is not NULL.  */
  gdb_assert (tdesc->xmltarget != NULL
              || (!tdesc->features.empty ()
                  && tdesc->arch != NULL));

  if (tdesc->xmltarget == NULL)
    {
      std::string buffer ("@");
      print_xml_feature v (&buffer);
      tdesc->accept (v);
      tdesc->xmltarget = xstrdup (buffer.c_str ());
    }

  return tdesc->xmltarget;
}

This assert triggered at first call of tdesc_get_features_xml() when
tdesc->xmltarget is NULL.