From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id C90063858D20 for ; Tue, 30 Apr 2024 12:46:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C90063858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C90063858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::233 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714481163; cv=none; b=ildQGeOCrB6vBU+FvS3EWQCt5E6qAAlhrwq/O8y+wu2AqN6YYUZasUhZDDTDNeCOU3q8CUOdV7zsHTW96ehKoJRk9tYe1KJa5ROC9/wHTCpPROv9dQnqjfeI/2butayBlIWDjy+ODEaxyaF2+LjlV74CQD9bw6PdjNrbehrp6+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714481163; c=relaxed/simple; bh=v6Ex7Y+zK27KY2iVNL804S0j+6M2s71JESfJJ6kzDkE=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=gi1tbgZRRhYUJPoPrrJYl2o2YtsJWNJVGsyvZiQZ3Oe7t4oXk3b8wSbdMxrLOqISFc76S2CH2gg5MLFEYZt3HuaqS8pO7JR6wjFvGh/Icvg0rxjdgjRCG6lnCuyyk5fcb8R/2vZEw5pRkAmd7B/edSGTlzKJpVJwFQpcGMab5P0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2dd6a7ae2dcso90033911fa.1 for ; Tue, 30 Apr 2024 05:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714481160; x=1715085960; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hspRNJ+Uko4/B/Jp9BixLZMOpbMPs8FMDqlQTfN7RAw=; b=Ne+D9WgkE//LtXu8YZzJwcPcygz2jsFm9yZfS+i8Zv5bn8cJJLBcnXITEyKQ8Zse/V t1kOXU9/sLgWch36StusCXbEdhqHnX60ESDHZDEMBeTwY0fDqAr0GJ7mm84EVhFra/O0 /ZLlaaOF1bedeNWz49tuuVvWF7trQ3+AAu+6WZ9Wz6L9966nkxuuZPxtLhSvKGGTo8Zw 3g2pHgW2KPgqBd6mhZnVQZvd7PVO4rUfZ5uQb10RA+MAScQw5o0IQU22RaH0IU8S/blI oh/ZGXAx/M2pWZ5hqctOh+BEqdhwKF22mImgJx9OE8UzbPSizVItCmNY9TWj9aF902Ag Jo+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714481160; x=1715085960; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hspRNJ+Uko4/B/Jp9BixLZMOpbMPs8FMDqlQTfN7RAw=; b=I08dC2IHZH6M51/Hz+hfsbodxUD0QDEyiNQNGHxeCXCda+sMHmzcmr+vWPyz/zMgzC V6JPDK0FTjjFLgGye5JJhLdQixiVAL3vqSGx89/1BeTytbn29LKxF63xCubgrKb7gaBd TQuRixPXeQoZqCWHxWDdcDPj7SDqAd7WWHH9Qo2i/FVXJ1EapgZmOohIA6L+JtjEV5rF AG8KZEA6kI4cbYOlLVRACAPnx+1DnEDPxWXmcltTrEpB8FRIRzYKU0Lw0vBXwPPGaeyu 0imJ47eg/Es4FocS+/+1ia5ICOOWOPujRwYM29tFkG0bW8yF2D25y0AXUXnNoXr/zNFW VVYg== X-Forwarded-Encrypted: i=1; AJvYcCUlVNAAl4hOr7elmS7+1jfP6CtCiUtc2w3vnKOx9dTuhvoujIj8lAjtrvwW/ZD2Q4oNoA1R68a566DWTid3h1jK9qI= X-Gm-Message-State: AOJu0YzKuDhZnYF2Uicy550LNb8yo5TPM18hkuN2/YRWf6Nf1FWjJoaI 4hiHmSnT+TwSCcdttcMHKdXKHTBPjzJojp5r9kVwRONNYayfYzCIl21fezCMDJLsRcPgy2cz7AL U8Dr7ntGaQ+ppOgG3SMUfvbIMV1huaixtPvYIKpsiVe6AEUsE7AM= X-Google-Smtp-Source: AGHT+IEIH3s7I02xB6i0O4ssSYShRKEzrHCzcNYw6U2ibIcYJ3BrzwoFiBz6KcmClFZRJuvf6jb1tXBDJTExxehuliA= X-Received: by 2002:a05:651c:1a23:b0:2df:70b5:c842 with SMTP id by35-20020a05651c1a2300b002df70b5c842mr12165855ljb.41.1714481160068; Tue, 30 Apr 2024 05:46:00 -0700 (PDT) MIME-Version: 1.0 References: <20240419090903.2080043-1-christophe.lyon@linaro.org> <87cyqlxqwc.fsf@tromey.com> <8e024d9b-3066-42af-b665-9a48a5f2c801@simark.ca> In-Reply-To: <8e024d9b-3066-42af-b665-9a48a5f2c801@simark.ca> From: Christophe Lyon Date: Tue, 30 Apr 2024 14:45:49 +0200 Message-ID: Subject: Re: [PATCH] contrib: Add autoregen.py To: Simon Marchi Cc: Tom Tromey , Christophe Lyon via Gdb Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Fri, 19 Apr 2024 at 19:51, Simon Marchi wrote: > > > > On 2024-04-19 12:23, Tom Tromey wrote: > >>>>>> Christophe Lyon via Gdb writes: > > > >> This script is a copy of the current script used by Sourceware's > >> autoregen buildbots. > > > >> It is intended as a helper to regenerate files managed by autotools > >> (autoconf, automake, aclocal, ....), as well as the toplevel > >> Makefile.in which is created by autogen. > > > >> Other files can be updated when using maintainer-mode, but this is not > >> covered by this script. > > > > Thanks for working on this. > > > >> +# these directories are known to be re-generatable with a simple autoreconf > >> +# without special -I flags > > > > Can other directories be updated to this same standard? If not, why > > not? I'm somewhat uncomfortable with the number of special cases in > > this script. > > > > I was hoping it would be more like: > > > > top level -> autogen + autoconf > > anywhere else with configure.{ac,in} -> autoreconf > > > > Tom > > I wrote the initial version of the autoreconf support in this script, > originally it only had gdb, gdbserver and gdbsupport. But Christophe > later added all the directories that currently work with a simple > autoreconf. At this point, I think it would make sense to flip the > logic and list only the directories that don't work with a simple > autoreconf, and then work on reducing that list to 0. > I've recently added a patch to the 'master' copy of this script which now defaults to using autoreconf, it is much simpler. And Simon just sent a couple of GCC patches to fix incorrectly generated files, which should enable us to use autoreconf in more places. Thanks, Christophe > Simon