From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by sourceware.org (Postfix) with ESMTPS id 7B0EC385EC55 for ; Wed, 15 Jun 2022 12:47:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7B0EC385EC55 Received: by mail-yb1-xb35.google.com with SMTP id v81so20407556ybe.0 for ; Wed, 15 Jun 2022 05:47:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=SaoIbUdOJ205zSScx3Fv1jyx8MQeG2SY1zJLzNApvuM=; b=IXdwkcY/KyzhdWRPlELjw3vDpUTB7BrD3yaCZS9wP8vsWkkpZCZ0lljBPQKXNVa4jZ rXIej68vDG/BMYbsrFeL89eO9zil10lxCjqpe0a4hhY6wC+HM+qUm3TGKSePezPQkMgV eWODjUDiOe9sc7vg+xZEftdAdSpKqa2ticmCzey/0cledQzrbJehUWs2OgISpZiUKr1A v6O1kX1McInYXldnoRv+6Q/YQL7lZaP0s2nEpabrI0fh98tsnc6fqFCQtAwuJfgwHs4x oLztjbG30RnzEb2o9jgusDZP7V1CBMYYrzuca0VuyZx/YiHAXFS+1WgvAlbSSsccmfXD JMxg== X-Gm-Message-State: AJIora/HmNFyKFcx1coSRU0X7zSmZxbznEgOZDjTFLMetHGpFy397B5I V9yREJLe/LjPt4Gf04riGaP9XSzIe+L/YJlHMzfKR2AUPpm9UQ== X-Google-Smtp-Source: AGRyM1sujwYlEFgi+8Cqwk+FsXqsW+ouO4GvK4WbQDuR1tMlfrnpvJMgIAdoYCwHzB60dPAS6SEjIhoP8JiCpC8e/64= X-Received: by 2002:a25:4585:0:b0:65d:49fc:7949 with SMTP id s127-20020a254585000000b0065d49fc7949mr10433030yba.307.1655297259595; Wed, 15 Jun 2022 05:47:39 -0700 (PDT) MIME-Version: 1.0 References: <040e723a-1f8b-3fb2-a076-85664243513f@redhat.com> <4ed767fb-f9d6-7dbd-47ce-1691a0a4ee38@redhat.com> In-Reply-To: <4ed767fb-f9d6-7dbd-47ce-1691a0a4ee38@redhat.com> From: Christian Biesinger Date: Wed, 15 Jun 2022 08:47:02 -0400 Message-ID: Subject: Re: [RFC] Change displayed line when execution direction is reversed To: Bruno Larsen Cc: Reuben Thomas via Gdb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-16.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2022 12:47:42 -0000 Sorry, just to clarify, you are not suggesting a change when using "reverse-next" without "set exec-direction reverse"? Christian On Wed, Jun 15, 2022 at 8:39 AM Bruno Larsen wrote: > > It would only happen if the user explicitly used the command `set exec-di= rection reverse`. If the previous line was printed right after this command= is run, I imagine the user would understand what is going on through conte= xt. That said, I'm open to suggestions on other messages or documentations = of the feature to avoid confusion. > > Cheers! > Bruno Larsen > > On 6/15/22 09:34, Christian Biesinger wrote: > > My personal opinion: > > In general, the state of the program when gdb is stopped is the state > > at the start of the displayed line (I concede that it gets more > > complicated when "step"ping) > > This change would make it so the state is the state at the end of the > > displayed line. > > > > I think that could be confusing? Perhaps could be mitigated by > > printing a message explaining that in some way. > > > > Christian > > > > On Wed, Jun 15, 2022 at 8:26 AM Bruno Larsen via Gdb wrote: > >> > >> Hello all, > >> > >> I was doing some reverse debugging and noticed that setting the execut= ion direction to reverse does not change how GDB displays lines. The proble= m with this is that the user doesn't see what will be executed if a step is= taken, which makes the user experience quite annoying. How would the commu= nity feel if GDB printed the previous line, instead of current line, when t= he execution direction is reversed? > >> > >> Sorry if this is the wrong list. It didn't feel like a bug, and I don'= t have a patch yet, so this felt like the best place to send. > >> -- > >> Cheers! > >> Bruno Larsen > >> > > >