From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by sourceware.org (Postfix) with ESMTPS id CC3C63858D1E for ; Tue, 19 Apr 2022 06:28:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CC3C63858D1E X-IronPort-AV: E=McAfee;i="6400,9594,10321"; a="243621847" X-IronPort-AV: E=Sophos;i="5.90,272,1643702400"; d="scan'208";a="243621847" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2022 23:28:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,272,1643702400"; d="scan'208";a="665835838" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga004.jf.intel.com with ESMTP; 18 Apr 2022 23:28:25 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr 2022 23:28:25 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Apr 2022 23:28:24 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 18 Apr 2022 23:28:24 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 18 Apr 2022 23:28:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nWB5WIThWh7iz8qFPS1K7BDBDgQHS0NqrAr1IQle8rFHEowGokLzAPNjGK3b/Bql6H6P9zJVBN2JqudCe9ovsGMsFyHicdn8zqCWTjDccJ37h/ZkYT8SuumUonfjH7WF22tDzn39/RlEa1sXiTIjZ0bnywbgr3MT9wL0bx7H95A30u+K5zMd7vFR06YePao1IGVpOegS7m84QeiwnBISFNMlfX6OS5NsBQr0/BdNp3CmLzXiiAn+R9F/l1wmeI7Y9fSQHO6LNGJFgihH2ESF99J4hUrJuLXI08uoiU+IoPGH/pHczPi/5MS18W5faZXn582h8nYg6bh5vncbNtex3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iapRSrZ8RyNtIoJ4O4DRAgwmkSKZNbEyAttxTit5a+Q=; b=Ey2GBTARTn5J6DolK5LZDGBNPj1ucJdRHbfCrqhgy2oQ9RLdFt+Qsf2hSiJzxmGCSf84RL0swWIYD+0WA0wYYKSv/xhFqgMGY5Nf1M6/UCZqdWrlfaCDBVfepYj90KClfQmMDzrCdJ3Nqd0dDEuygYErwkWgbZooD454TTlM3yy+bnUAgnuoLt0GtWpqXwXEicc9oJCya1JA78FwhSThjaNw7H63czOk57UtsYQi/ZNYVjLKyDL0hVJb2zwbExraRZyfl51iL9DlGg9/oXYx9ZDRdKmMa4pl2cwlX+sPxYXYKtN1+P61yLEOZTAhWlzmxZutEelezpmpengrX0iOpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4564.namprd11.prod.outlook.com (2603:10b6:5:2a0::7) by PH7PR11MB5794.namprd11.prod.outlook.com (2603:10b6:510:131::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr 2022 06:28:22 +0000 Received: from DM6PR11MB4564.namprd11.prod.outlook.com ([fe80::7020:861:32c3:44b6]) by DM6PR11MB4564.namprd11.prod.outlook.com ([fe80::7020:861:32c3:44b6%6]) with mapi id 15.20.5164.020; Tue, 19 Apr 2022 06:28:22 +0000 From: "Rohr, Stephan" To: Tom Tromey , Andreas Arnez CC: "Rohr, Stephan via Gdb" Subject: RE: Issue in dwarf2/expr.c Thread-Topic: Issue in dwarf2/expr.c Thread-Index: AdhPVlK+Yrom0as+TeaLasSnLw9KswAsIgmxAEACsX4Aq2bu8A== Date: Tue, 19 Apr 2022 06:28:22 +0000 Message-ID: References: <877d7reps0.fsf@li-07e5db4c-3052-11b2-a85c-815382633c95.ibm.com> <875ynajdrg.fsf@tromey.com> In-Reply-To: <875ynajdrg.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b63d72cb-06b4-4c4d-5461-08da21cdcda9 x-ms-traffictypediagnostic: PH7PR11MB5794:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a0sdOYgI88KtjnQVwxdHXTEkZDACm1Pt3jpQWgLiUHRSRSftLwyX6LV9bQTSRI3bz40DRILsr548YOhm4urch2TobcG3ddu4WYlvP+AiTudhEA54FbPpAKwahLBrb6l8BnJmL8+ZdSuf4SghojNKJL66tf3YvVbPxnQ3PyWoyWI4xVdodbOvk70cWYPhrkvkOUsUTX9ffvDy/TXfWyB9p8Zet/3m9ya4Y3Wlqj/XHahaL5Oqtkw4ooaoUBQmoom5CjLlgBAm9mbn84aZgdXhSlOAxwOojfLf+pWm5fYU93JBRZimAjkXJjuKPTy1Bvf55RTwJcKxp6/R1hJ6AI4fkVwVE8vQJqm3SKdYFcw8qUJkJ4AY4QqZ4t9yAmc/S2W26c/LhjnG5sK/RZkz8I0zkOyhemtfOz/ayQk52IritPiWVfgDv1CGRW9ShIzVi0tAINcuAs66Nub6GBxtqUgQjOQKZQ8yr+C1pG7Jv01VdqyYx2XwJXPGGHGiz93oJVqd6QmTNHFnEneHy73IEBG1BLP6lI/K/XprLZtu/ShB9zZmm0RP/j8OhSuXcToy7ibHpAdEf0F9zOpCXQg/wkFRG8iuBluxwl9z1u9yn1gYPKuLG/ceZ9s5tDsMHAoQcM4ndIsNxTjhbRcIF+2wrpyOj8fJsqqndKvH6QaOfeOlRmu6Ht/UsgxMpHRSJxIwDHZTyybeMq5KtfUf5i9GkleIrg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4564.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(53546011)(82960400001)(33656002)(66556008)(8936002)(7696005)(8676002)(76116006)(38070700005)(38100700002)(64756008)(4326008)(66446008)(52536014)(66946007)(66476007)(55016003)(110136005)(5660300002)(6506007)(122000001)(2906002)(71200400001)(26005)(9686003)(186003)(508600001)(83380400001)(86362001)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?npCvoLRJiMKBgB2uQuXiMieo7BXjV0HWPxIBDcG1Z4/gDkJ4vByuCNZWcmRd?= =?us-ascii?Q?WTn8fgMUKj9gFYKfnyVK7HqoglRc+DCHHYB2zBdoFT7ZIJlbjVI0kAsHp5sX?= =?us-ascii?Q?Q8IMI98Bfajp2A3wKEuWD+xIefuiMpqFvgjjL2rcYt8BAYBOAOEUAUlek8E6?= =?us-ascii?Q?Mx9B5NE56Lb3BmgjR/muP+xnMYyTs3Zh8slfZabnrEv7FVwtN4iwzMngi3a/?= =?us-ascii?Q?lp45Q/IFF0AJ8fCbvynnfbCSHkgBGdkcx4xvcImELBfEFjB9Goao1VL0djko?= =?us-ascii?Q?KWmE5/EcAWM6ZWIZtsWC0QCiHBVMp8logokfOGo0NUZcfOrFruVUaCT3QxFl?= =?us-ascii?Q?PJEAo9pA5kWkJX4M9W7qQWMjfr/TPc6XWqeA2WhtvIaEySt6mKcuwBCIfCDf?= =?us-ascii?Q?WK7L4wganN8uhpqg52pYIwMx2+NhXM1TlilQo3G7y9bpe3r62k6c5Fr8QU6r?= =?us-ascii?Q?2TW1yoU3w7+gWLY4p00OW2YrYO572BXWGULNs1CkxaFs8GQppmUTSF9Pt9Wx?= =?us-ascii?Q?BUtPAZhreKkDSfr7gFVJW9RlxpTib7CAMS42BBA6dY8Dif5lZbv05AFa4nPY?= =?us-ascii?Q?rMuV9oHcxlOhhNvPjIS3Pbbn/dwiEe7OQY3sM4PyhNBj+e4ksKnnwteyOGEo?= =?us-ascii?Q?Ohl5fZSS+46OTbui2v+Gmrv0YYR23UKrMGEizWLYK6qywEIbGVNmH2hTNExB?= =?us-ascii?Q?CfreiWaZjKfC+xNiNfdAtUvATf7RdeFBMO77mfWNqm8LRcjI2DCI5Rg7hwHm?= =?us-ascii?Q?FbEk36XXMFbU3amiHE7wOqlbVQUVpIqMfr10Q5BU6c5IMYIJSvmljDVKjs+2?= =?us-ascii?Q?JcCxZaqyt4RzhiHH9S91Z+9fKFrAWGwBTW29F6adOpT1yIPo+6/zKUTZTGCC?= =?us-ascii?Q?YyYQfDshbSnlyNrRvdg3nj1MCmBLxUQJ/7iLDcegEjCVnFkZt1zHGpocOp09?= =?us-ascii?Q?7rDTsZ2dh8s1AkYKA9q2a236HKZSJtLFrokkUGSnvUk8oVE9vbn7YOTmI4cF?= =?us-ascii?Q?2p0omyf2YVjgDDzaaljqyI3jdnkHbIiT4ylSC9/zGmQHU5qeACFAVMMtLwsI?= =?us-ascii?Q?l4UUt0/oUj/p5QpjEx2zsso22ldZ3BkUZbxOz74jo+m6FCcyUL5kCLDGMDzM?= =?us-ascii?Q?0I6wM8cdmRPBGRryL6z0P/d6sDJH6Ym3FiWL35iIw/5ZWBoPef6qn4GaIpPd?= =?us-ascii?Q?Z4rfxJg5CboKuqDTVhiKUIOfRfgSpIjPvpcR2wve90mSsj+dwPrJMTZlM5uD?= =?us-ascii?Q?XmAbVTWjaJj3YE1Og3drsbK/wI9CaOtpsB5wedSNxahOGr/qKJ4cXTOl2RTE?= =?us-ascii?Q?CHHVCcPqkeV0jkNluRBQNgmFknSyC7tAk1lZMN/JIphd8jARpW903udjbZRj?= =?us-ascii?Q?Oibc1QQVq1DkWX449uflpx/VaOmQeu+DORH5bENtUYEnth/unR4xPkAlYNAk?= =?us-ascii?Q?DANUGQ/UXhmcur5SXmW3E8dItw4GRFDsJWJAs6upA0v5LRwYrxJtXZIUNGu9?= =?us-ascii?Q?PvBGcmY/ue3n6x3OSiqxnK3atYAZ/YeHUkV5iuZebPjCMz7RHcmqTiC1GlVr?= =?us-ascii?Q?B7y4RB4ZqNTv2s4nE2StjlBp7M1gQIaZlLGdfPHlQLBHYB0NEabBUZ5qlcH0?= =?us-ascii?Q?pettDzJT6yquslV4sxPmzTnYNElyfIWTOxwMREIcWcu5B+dyZxLDWNHOamQe?= =?us-ascii?Q?M/X3ofh3HUmFlU3YiknQCsxJVb62BgR8o3nAEckoDlZ8j7VG+MHmc62yDmDj?= =?us-ascii?Q?0CPGkxTlTw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4564.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b63d72cb-06b4-4c4d-5461-08da21cdcda9 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 06:28:22.7847 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: djUdu1fiADPDcED06wz9wQE7U29i6XVPf2c3bitF8Sw9My4plp+HjTzvf/ejxZLHpuEtE9hhfTcgX/ePKYtR4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5794 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2022 06:28:30 -0000 Hi Tom, Thanks for your feedback.=20 The 'embedded_offset' is considered in the ' value_contents_raw (v)' functi= on call whereas the 'offset' is handled in 'rw_pieced_value'. So from my un= derstanding it should work as expected. I will check for regressions and su= bmit a patch. Best stephan -----Original Message----- From: Tom Tromey =20 Sent: Friday, April 15, 2022 10:25 PM To: Andreas Arnez Cc: Rohr, Stephan via Gdb ; Rohr, Stephan ; Tom Tromey Subject: Re: Issue in dwarf2/expr.c >> I came across a bug in dwarf2/expr.c:177 in function rw_pieced_value. w= hen reading a pieced value described by DW_OP_piece or DW_OP_bit_piece. >>=20 >> if (value_type (v) !=3D value_enclosing_type (v)) internal_error=20 >> (__FILE__, __LINE__, _("Should not be able to create a lazy value=20 >> with " >> "an enclosing type")); > Since I did some work on this function in the past, I just looked=20 > where this check comes from, and it turns out that it was introduced=20 > in 2010 by Tom Tromey with commit=20 > afd74c5ff76010405caddd2834be4a0178fa93dd -- > gdb > * dwarf2loc.c (read_pieced_value): Work properly when 'v' has an > offset. > (write_pieced_value): Likewise. > Perhaps Tom still remembers the rationale? I don't remember, sorry. It's possible I assumed that it should be impossible to create a value with= an enclosing type without un-lazying it. Removing the assertion seems fine but it's important to make sure the resul= t works correctly. An enclosing type normally means that the data represen= ting the 'type' is at some offset in the contents, but it seems to me that = rw_pieced_value may not handle this case. Tom