From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12olkn2074.outbound.protection.outlook.com [40.92.23.74]) by sourceware.org (Postfix) with ESMTPS id CC40C387091D; Fri, 15 Jan 2021 01:18:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CC40C387091D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=i@maskray.me ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WdwkVd/nE9qg7AbqS2LSNT0aLsAf9WaGOTtTi1e4ukQwDbU+/HSnLsBr4O9lJdaLcfRgbXgM8img/NnSrTC40Nd1y4j523KZRMqBp+5L0TGOjQ7q9TQzw15qSHbDfRAIusokNXZ2dnvXmyZvJ6oaFVRwCu9rT0KLGryDgPUfWpKCIcVOsJXxbL0+FGGB6hR1/lQ2AZkurjt1hpo5NHozBaG8fmOjPdx9lOwtYHO/uJvTZukeMbwtInfysmFjYYgCS1whtLoLeab5Pfh8FbAL+akOLiPwrWCNWIgErFDI035xLf4+ne18owjInrZVFAve9fdBDi6htaKJIh+ZiG6AQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cEH7buQM/TgQPpvlqqDQzwnUm5hlMQ4o9ljmdfUphwI=; b=Qztcels+KKHxlV3Y4DFHopFdx4LpmGKMDXh60bhYw0pNu5rBD5rb8qEjU9CfSIrsxkKdfuLIB6/ixs6OMHU1+y+eGnKVd84Nsys1UL3LDQojjxLSU0BWthcK6GmJESJh8Q1wHdwFG6ErVC85VsdGkk720PDg9oavbzSN0vGUBdEcScjKHNt8SDfJ9zLtGrJ4V9PQBecWznGmDj3CXP2DEi2kWJAd5kwOo15HVgSb6e73l9mgOoUTyIQzeN2hi/lrixnjQmJY8jE0xqoHW+3r4NkT9AEOdoslJ9wBvZuVhU7eIuHwcIp+NIc1ZGcZN3MHGfCHUSsc3RuwpjDjspzmoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6NAM12FT068.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::43) by DM6NAM12HT185.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::306) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.7; Fri, 15 Jan 2021 01:18:50 +0000 Received: from MWHPR1201MB0110.namprd12.prod.outlook.com (2a01:111:e400:fc64::4d) by DM6NAM12FT068.mail.protection.outlook.com (2a01:111:e400:fc64::373) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.2 via Frontend Transport; Fri, 15 Jan 2021 01:18:50 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:06563D8495C3326E17179E20F37D87F55258A940BBEE7562AEA82C1EA800EEB6; UpperCasedChecksum:8F2B262B03A5B6C87434409DAD8AB8D6CE0082D124ECB0007CAE029A1C8418FB; SizeAsReceived:9770; Count:51 Received: from MWHPR1201MB0110.namprd12.prod.outlook.com ([fe80::d413:5a54:24aa:906d]) by MWHPR1201MB0110.namprd12.prod.outlook.com ([fe80::d413:5a54:24aa:906d%8]) with mapi id 15.20.3763.012; Fri, 15 Jan 2021 01:18:49 +0000 X-Gm-Message-State: AOAM533vhB95Phd+nlwbOQlHxya1FuAB55uVvezZZI1cdhcWBYeTTA6M MoIdvmOtOkqra1Fdjk7Y6N5ubKGyHgTsvfGUVu4= X-Google-Smtp-Source: ABdhPJzfaGJA8XJQWQIGmkqNGr/uFKKc249m+BoZNHhKdGjDqyiT3Gh0aBuOwaoKhMzuu45sFZFN8qM18U5+i/3giA4= X-Received: by 2002:a0c:aed0:: with SMTP id n16mr9930924qvd.14.1610673524787; Thu, 14 Jan 2021 17:18:44 -0800 (PST) References: <891ef86a-a47f-18f2-c6bd-e525719e3768@simark.ca> <9492d857-c259-1429-f1c7-31a6dbf6510f@simark.ca> <1fb47dab-7a52-524b-17a3-672122277a48@suse.cz> <87tuzzaqey.fsf@tromey.com> <83tuzyn8sd.fsf@gnu.org> <87367hrzua.fsf@tromey.com> <83h7vxkygu.fsf@gnu.org> <838sh6g7cu.fsf@gnu.org> <7b70bf47-db34-51a8-ae7e-a9d295954db8@suse.cz> In-Reply-To: <7b70bf47-db34-51a8-ae7e-a9d295954db8@suse.cz> From: Fangrui Song Date: Thu, 14 Jan 2021 17:18:34 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Auto update ChangeLog for binutils+gdb commits? To: binutils@sourceware.org Cc: Eli Zaretskii , =?UTF-8?Q?Martin_Li=C5=A1ka?= , simark@simark.ca, tom@tromey.com, gdb@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-TMN: [k2t6pucLc1rEyw3yCairfPnF493eos8R] X-ClientProxiedBy: MN2PR22CA0008.namprd22.prod.outlook.com (2603:10b6:208:238::13) To MWHPR1201MB0110.namprd12.prod.outlook.com (2603:10b6:301:56::8) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mail-qv1-f44.google.com (209.85.219.44) by MN2PR22CA0008.namprd22.prod.outlook.com (2603:10b6:208:238::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.9 via Frontend Transport; Fri, 15 Jan 2021 01:18:47 +0000 Received: by mail-qv1-f44.google.com with SMTP id bd6so3286800qvb.9; Thu, 14 Jan 2021 17:18:46 -0800 (PST) X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 51 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 25d77ebd-69a3-474f-aa45-08d8b8f383bb X-MS-TrafficTypeDiagnostic: DM6NAM12HT185: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: elSNsHZEkhu0I46x9hkkf9AIrsms9UGpQ8qrLbiOa+2mCYQ6A7dBhOXn3ZbiDW2T/RkGBkE3EBP3GphQeb13X6fTD9vTJnvvD/Rtxv2SKrTr7qdvXGIc3xhlsVUncOH23f3fdENiskil66CLycGXpByWhIisBqC9283/QavAxFkaLYZ9irZZWomTQT8pG9eCz2zqrBfDRjldlgiypF6zDYp5NXfH+cxBVf2U4caOH+11On1cTh3S/5ZCzjKxqDOx X-MS-Exchange-AntiSpam-MessageData: jP2625xQhUEFlRbClI7DHyUO8VzlzGzXlCwAx4WOkp2NjCss9sEPQUEp8SRcyTdtE/PPmV01TTqu8660YM7J9f+TTsf04obIIXMVuIb8oU3jckaaa322A/mwgeHRTOZ12qfkOy5lwJtX0VUPGYZNzg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2021 01:18:49.8023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: 25d77ebd-69a3-474f-aa45-08d8b8f383bb X-MS-Exchange-CrossTenant-AuthSource: DM6NAM12FT068.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM12HT185 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2021 01:18:56 -0000 On Mon, Jun 1, 2020 at 11:49 PM Martin Li=C5=A1ka wrote: > > On 6/1/20 4:59 PM, Eli Zaretskii wrote: > >> Cc: simark@simark.ca, hjl.tools@gmail.com, binutils@sourceware.org, > >> gdb@sourceware.org > >> From: Martin Li=C5=A1ka > >> Date: Mon, 1 Jun 2020 09:39:08 +0200 > >> > >>> If all the script does is look at the hunk headers of the diffs, then > >>> indeed such a script doesn't have any added value. I thought it did = a > >>> more thorough (and thus more accurate) job than that. > >>> > >> > >> It does, it tries to find a function name, macro, struct in a diff hun= k > >> and this name is taken as changed. If nothing like this is found, then > >> diff header name is used. > > > > How does it handle the frequent case where the change is attributed by > > Diff to the previous function because the function's type or argument > > list is being modified? > > It's handled by parsing of each diff line where we try to identify > beginning of a function, strut or something else. In that case the > diff header is ignored. > > > > > And how does the script decide that "nothing like this is found", > > i.e. how does it know that what is in the hunk header is not really a > > function name? > > It's best effort approach and it's not easy task ;) > > Martin > > > > > Thanks. > > > Seems that ChangeLog files in binutils and gdb are still being modified manually. See glibc tag changelog-ends-here. They stopped updating ChangeLog files manually.