From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2056.outbound.protection.outlook.com [40.92.22.56]) by sourceware.org (Postfix) with ESMTPS id 834953851C09; Sun, 31 May 2020 04:48:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 834953851C09 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=i@maskray.me ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IOBQVyOBlrNMdf/PU0NJ5wdzYlOUeuAhG25KAP0t5RTN9RbJuzab/SFmwWkUdh1XUpT/YPWJpySA0+mCTssvF5qdbeE5I/bRosIWE4N4sXrTCS4Xl39t1UWwwRutZc74r+ye9kHDa3xRnBPGmdiRYIgIrzD/jRMQa/DBhAK+aEVVHSPr1UEG3152AHvIfmnvqTBD/q5v17elS9JUMMrOwLLWuRTQDxMRLiavgM4Bwzd9jx6M7gz6huQxXSZiEVGh4JFhYYZkHRMYBeJ8aBJ2NOsWe+VUsyiwEGPTaiIYid41DU2/KkhwvsgOxiLwPUlg9wgCPh6Jc5PSfSejbHdObA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NL3rYdNHCl8tp86mY2Wj2KhxcG54aYnPkFaYJKKonHg=; b=F2XHpcIspFDmMne75d3gRUZhmqOfVNy98La+OHgZJFjAjnJaxJcxFaG9P5BsbkcUmWesaCoC2+CZOIA9SsT+Svyhf58LQkWbf/JCeVw3qbw+gfQSmIcgPeFvAJ3UGlwYRM2jIBbQ8/mvYcCwBnKYClaXBhBC3HoEVFYTKuwmzc95asnsWbAC2zI0QAxQyyVzyYcf/GdbtfaGqiTMrAm5qS12RyQU/rMt3lq7qclMCVF5ASqe1XtZPCHLCJVjxJ/M2OcYQd/iSJaA1+ssqnJDB/fD7wpsyw6p0ssAAXgddS0jz1NhT7C9PMfVd5yHQbg/LAaudJ2RomKWH2GfxpM2XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6NAM12FT063.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::48) by DM6NAM12HT233.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::383) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.8; Sun, 31 May 2020 04:48:52 +0000 Received: from MWHPR12MB1456.namprd12.prod.outlook.com (2a01:111:e400:fc64::4b) by DM6NAM12FT063.mail.protection.outlook.com (2a01:111:e400:fc64::112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.8 via Frontend Transport; Sun, 31 May 2020 04:48:52 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:3CDF72E1E8884A2B57CEE29EB866A426E99ED495CCF0A9B6DB2A05520DEDF2B0; UpperCasedChecksum:1CE1B6607C549655A5B60046BA9D0B6E5FBA22CF9EA1DFA4019CEF133A618FF3; SizeAsReceived:10252; Count:56 Received: from MWHPR12MB1456.namprd12.prod.outlook.com ([fe80::4539:a2c4:b80b:d9c4]) by MWHPR12MB1456.namprd12.prod.outlook.com ([fe80::4539:a2c4:b80b:d9c4%11]) with mapi id 15.20.3045.022; Sun, 31 May 2020 04:48:52 +0000 X-Gm-Message-State: AOAM532g8I4+eGY2mG/kLKdxHMaJ9ZrLaoyDLaSHcQwTrYIcH82CAOFk 0vuTTOfnIhgpz+w3NFjZCew4Auze4eoF4ofz2Uw= X-Google-Smtp-Source: ABdhPJxN5NmvKDRTj8v4ovzLmm0UYAwwVRDD5o1KGiKZh0QPEd6QbTzuXnhsPoJLO+wdjJvGEqHebI8/mUXIW3y10eA= X-Received: by 2002:ac8:7552:: with SMTP id b18mr16874897qtr.150.1590900054483; Sat, 30 May 2020 21:40:54 -0700 (PDT) References: <891ef86a-a47f-18f2-c6bd-e525719e3768@simark.ca> <9492d857-c259-1429-f1c7-31a6dbf6510f@simark.ca> <1fb47dab-7a52-524b-17a3-672122277a48@suse.cz> <87tuzzaqey.fsf@tromey.com> <87o8q6c3m9.fsf@tromey.com> <12ea10a1-59c1-5858-4619-ed3b40121d30@suse.cz> <87y2p9qkgd.fsf@tromey.com> In-Reply-To: <87y2p9qkgd.fsf@tromey.com> From: Fangrui Song Date: Sat, 30 May 2020 21:40:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Auto update ChangeLog for binutils+gdb commits? To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: Tom Tromey , Simon Marchi , Binutils , GDB Content-Type: text/plain; charset="UTF-8" X-ClientProxiedBy: MN2PR01CA0063.prod.exchangelabs.com (2603:10b6:208:23f::32) To MWHPR12MB1456.namprd12.prod.outlook.com (2603:10b6:301:f::9) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mail-qt1-f177.google.com (209.85.160.177) by MN2PR01CA0063.prod.exchangelabs.com (2603:10b6:208:23f::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17 via Frontend Transport; Sun, 31 May 2020 04:48:52 +0000 Received: by mail-qt1-f177.google.com with SMTP id g18so5256925qtu.13; Sat, 30 May 2020 21:48:52 -0700 (PDT) X-Gm-Message-State: AOAM532g8I4+eGY2mG/kLKdxHMaJ9ZrLaoyDLaSHcQwTrYIcH82CAOFk 0vuTTOfnIhgpz+w3NFjZCew4Auze4eoF4ofz2Uw= X-Google-Smtp-Source: ABdhPJxN5NmvKDRTj8v4ovzLmm0UYAwwVRDD5o1KGiKZh0QPEd6QbTzuXnhsPoJLO+wdjJvGEqHebI8/mUXIW3y10eA= X-Received: by 2002:ac8:7552:: with SMTP id b18mr16874897qtr.150.1590900054483; Sat, 30 May 2020 21:40:54 -0700 (PDT) X-Gmail-Original-Message-ID: X-Microsoft-Original-Message-ID: X-TMN: [EFVjJlf6hNMs9mB7Dg1LkwvhKPQR7Ic2] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 56 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: dd943f1a-3091-4f53-e109-08d8051deab5 X-MS-TrafficTypeDiagnostic: DM6NAM12HT233: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SSkNdr9DqjRSZNWJuGhx4iozTed6vHGDqUaXkCb7mAYoo6VAN4N9JEDl8QeaphCyoz49ry1LHQQEGYy1nlLhA3g+iP51aRtEkiLq0e92JK3vzTQXoa4WlV5qXxzI/USjSehx5zvtZuh54Sgjm11WWE3YufiG54zWrYZUKu56CMeIFGCl5+s8cBoJPNOoOtWJfvQ/CklJHUrNLdl1AlFX7w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1456.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; X-MS-Exchange-AntiSpam-MessageData: JGDL4kjabs61K2VAOMgxbRD1N7+5BtzeYEf1lUH7mvBDb9fqkPHwrm0S3YLU6lumRDUjEnN9lrRsokcepQPiPMPJcANiAK87rBKibXwauHnwgZMDgjremYp7rTADBASmvWsW5JTNy9Brt28k/NycFA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd943f1a-3091-4f53-e109-08d8051deab5 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2020 04:48:52.6432 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM12HT233 X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 May 2020 04:48:55 -0000 I tried mklog.py on my gold patch. % ~/Dev/gcc/contrib/mklog.py < 0001-gold-Set-DF_1_PIE-for-pie.patch ChangeLog: * elfcpp/elfcpp.h (enum DF_1): * gold/layout.cc (Layout::finish_dynamic_section): IIUC, the practice is to group ChangeLog's by the top-level directories elfcpp * elfcpp.h (enum DF_1): gold * layout.cc (Layout::finish_dynamic_section): On Sat, May 30, 2020 at 12:41 PM Tom Tromey wrote: > > >> Could you run it on some recent gdb commits and show the output? > > I tried it out a little as well. > > It seems promising. However, I noticed some issues. > > First, in the basic output: > > Martin> * gdb/Makefile.in: > > It would be more convenient for editing if the ":" were followed by a > space, since I'm normally going to have to add one anyway. > > > Next, try it like: > > $ git show af0b2a3e85df9f49a3528e5b7578fcf9412f1acc | ./contrib/mklog.py > > I get: > > gdb/ChangeLog: > > * ChangeLog: > * dwarf2/abbrev.c (hash_abbrev): > (abbrev_table::add_abbrev): > (struct abbrev_info): > (abbrev_table::lookup_abbrev): > (abbrev_table::read): > * dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H): > (struct abbrev_table): > > abbrev.c says: > > (struct abbrev_info): > > ... but I didn't see anything that would be relevant in the patch. > > abbrev.h says: > > * dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H): > > ... but this is very incorrect. In gdb we normally ignore changes to > the #includes, but if needed I suppose this could mention the addition > of one; but either way mentioning the include guard name is wrong -- > macros should be ignored unless each preceding line ends with a > backslash. > > If you try 89bcba74f89baceba3fa7387622e3d60e1de02e8, you'll see that > mklog ignores namespaces. > > Martin> Sure. You're a skilled GDB developer with long experience. But for newcomers or > Martin> people without the scripts, this can simplify their workflow. > > IMO we should optimize for reducing the overhead for regular > contributors. Newcomers normally have many things to learn. > > Tom