RE: [EXT] Re: Semihosting in GDB 11.1 | Proposed patch for interrupting in sync mode

[Adrian Oltean <adrian.oltean@nxp.com>]

Hi guys,

Unfortunately, my knowledge on GDB's internals is quite limited... I'm leaving below two old mail threads, [1] and [2],
that describe the GDB's behavior in a custom use case and what makes it difficult to handle when target-async
is enabled. GDB 8.3 is referred in those threads but behavior is mostly the same in GDB 11.1. The key is the execution
of post_event("cont").

As far as 'H' packet handling is concerned, note that the GDB server I'm referring is a proprietary implementation
that is used for JTAG debugging. Threads are numbered from 1. However, in the old implementation "Hg0" was always
switching to thread 1 ("first thread") internally, even though some other core/thread was suspended. The original
implementation assumed "Hg0" must *always* switch to "first thread" (thread 1 in my case) but this doesn't seem
to be enforced in the RSP specs. I updated the code and assimilate "arbitrary" (from spec) as "if there's no suspended
thread/core internally selected, find a valid one".

Thank you,
Adrian

[1] https://sourceware.org/pipermail/gdb/2020-February/048395.html
[2] https://www.eclipse.org/lists/cdt-dev/msg35130.html

-----Original Message-----
From: Pedro Alves <pedro@palves.net> 
Sent: Thursday, March 10, 2022 11:48 AM
To: Tom Tromey <tom@tromey.com>; Adrian Oltean <adrian.oltean@nxp.com>
Cc: Adrian Oltean via Gdb <gdb@sourceware.org>
Subject: [EXT] Re: Semihosting in GDB 11.1 | Proposed patch for interrupting in sync mode

Caution: EXT Email

On 2022-03-09 19:49, Tom Tromey wrote:
> Adrian> Unfortunately, I could not find ways to adapt all the other 
> Adrian> components I have around GDB to work with target-async mode enabled. It is what it is...
>
> I'm a little lost about this, because my mental model is that target 
> async shouldn't really change anything.  I think it is just an 
> implementation detail about where gdb waits for events -- is it in
> wait() or in select()?
>
> So, it would be interesting to learn what the differences are.  
> Perhaps this can be patched up.
>
> Adrian> Regarding the 'H' packet, I had a second look in the RSP specs 
> Adrian> where it's stated that '0' indicates an arbitrary 
> Adrian> process/thread. So, as you mentioned, I changed the GDB server 
> Adrian> code to simply ensure there's a valid thread stopped marked as 
> Adrian> 'current'. The original implementation incorrectly assimilated 
> Adrian> '0' with 'first thread' (always).
>
> I'm a little surprised this matters as well, but anyway I think it's 
> fine to submit a patch like this.  Maybe others have some idea of 
> what's going on.

I'm not sure that I get what Adrian is callilng "first thread", but I take it to mean that the server was numbering threads starting at "0".
But, in the RSP, you can't use '0' as thread id, as it has a special meaning.
I.e., if the server is numbering threads like, 0,1,2,3,... then it will run into problems, because when GDB says "Hg0", it doesn't mean "select the first thread, the one with id "0".  The typical fix is to just start numbering threads at 1 instead of 0, for example.