From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 7C2093858D33 for ; Thu, 16 Feb 2023 04:14:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C2093858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x431.google.com with SMTP id h16so594483wrz.12 for ; Wed, 15 Feb 2023 20:14:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=h2ottUe+rhK3IzVc5/7frmf0EUHlB2veXTNeiqR1Q5M=; b=BknitbG4X7JcqtNvlS8ZC62aBLjUMXwKatIP4NbI/CZFK4z+GEUuaW1qtVRh4Rw6x/ 3R8JdJyW23fVEHxFV4lPEZ5pLjT051AG5DYi8/pUTEOH0KzROVv8voN7bgogtTHqVfNr oHCuF9EJPrhQbEDc+1kahoIGSo5G/tyH93/exQ+SJ6Hr2Gw1E1ogNO87D8v2Cs/MOi+h h+6Hh/6yBFJwq4SW7+57kUauzaPXPxBhYZGzYmaWsJW6iIy2ZD+4w+HqSAGh92JdYBpZ eqsjT4cjokatxqe8nqD9tgZkCpAbnfDytG29t53XIr5X3WOJfyYIddNgYAqS2ylEYYsI Sqig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h2ottUe+rhK3IzVc5/7frmf0EUHlB2veXTNeiqR1Q5M=; b=rwYvBNxeNoJNx2+2GZ3/6ureYMSB977mRrA8bEkJJ9tQP4fNQAq8q/s2rwNm68JyNs Q29rnroX4ZbeGsy6aGnuOgaAfgJR2DtkKVwr1qnKkA++5/GvQlPzs3bN/brqGQ/epmI4 P2hdhO78nS8DoPaZmUMIj/kH9P0zNQjWszB9FcSOT5GNOrWRpncrmhOHv/0hI2pEI/WI aH99joUveqySxxzlKrEDBI76aXVTZ29I1wt899WMEWOoutvbvxspfPC7chL4ke6NucNH 4pO/aQ8jeHmFQ/pH1YmZFgCdPKU5b2pDKgbeLhmkHBB5pzkpXGtvVlLSEhK3TsSOjrZy UxJQ== X-Gm-Message-State: AO0yUKWj9V7OzhMLv6oPCEso9kLQPYsfPG8N3186yP5ZhNkCnVBQYQ4y FNdHAlzjV0YjieKPtXIb4o/unvnWUMJpdzK4tQ== X-Google-Smtp-Source: AK7set+86TQf0URHngiD6wYQlgk/pJ8U7TBz5rp+CdVOkRpPMPssR3HXFSsVzHkYcPZ9Xtr938lqwQ== X-Received: by 2002:a05:6000:10c4:b0:2c5:4ca2:656d with SMTP id b4-20020a05600010c400b002c54ca2656dmr3276351wrx.36.1676520874145; Wed, 15 Feb 2023 20:14:34 -0800 (PST) Received: from takamaka.gnat.com ([2a01:cb22:1d5:1100:34cb:f64e:ec1b:3824]) by smtp.gmail.com with ESMTPSA id b8-20020adff248000000b002c3f81c51b6sm351403wrp.90.2023.02.15.20.14.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 20:14:33 -0800 (PST) Received: by takamaka.gnat.com (Postfix, from userid 1000) id 0389781E82; Thu, 16 Feb 2023 08:14:31 +0400 (+04) Date: Thu, 16 Feb 2023 08:14:30 +0400 From: Joel Brobecker To: Andrew Burgess Cc: Joel Brobecker , Luis Machado , Mark Wielaard , Simon Marchi , Simon Marchi via Gdb Subject: Re: Any concrete plans after the GDB BoF? Message-ID: References: <87mt5kunum.fsf@redhat.com> <20230212124345.GH2430@gnu.wildebeest.org> <87r0utu6ew.fsf@redhat.com> <65409b73-fc6d-9a89-3541-31eb1a0b0791@arm.com> <87bklxtx7r.fsf@redhat.com> <7112932f-4260-2f33-e619-c7130e0abb20@arm.com> <87zg9fkmt4.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zg9fkmt4.fsf@redhat.com> X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > > As long as the the tool is able to do the formatting of a given file > > using only that one file, the git-hooks are ready. There is a > > style_checker option which is currently calling a script that does > > nothing. But if we have some tools that check things such as formatting, > > copyright header format, etc, it's easy to insert them and reject > > the commit. > > > > The problem is that this arrives too late in the process, IMO, because > > by then, the review has already gone through. For a formatting issue, > > one could argue that the change is trivial, and therefore automatically > > re-approved, but this is not ideal. > > Whether the commit should be reformatted and auto-approved is orthogonal > I think to whether we should have an auto-format checked as part of the > commit hook. > > As long as folk are able to manually push to master then the process is > open to (honest) user mistakes, and we should, as far as possible aim to > have systems in place to guard against those mistakes. > > So having git refuse to accept a commit that is incorrectly formatted > would be a good thing; though I 100% agree with you that ideally we > would ALSO have tools that could auto-check the formatting earlier in > the process and bring that to the developers attention. Agreed. If we want to ensure correct formatting, we need to check for it before the commit gets pushed. The earlier, the better. > > Good or bad, my concern is that the younger generation views emails > > as antiquated and at the same time they have grown up learning about > > collaboration using systems such as GitLab or GitHub. > > I'd avoid the word 'antiquated' as it (too me) seems to have negative > connotations. I agree with that, and was only using this word in the context of me putting myself in the shoes of those who shared this feedback with me. Personally, I love email. But truly, some of the younger generation I talked to simply do not understand our reluctance to switch to what they believe to be superior technology. As far as code collaboration goes, they truly see email as a thing of the past. Having gone through a transition from email-based review to reviews through a dedicated system, I have to say that it hurt at first, but generally speaking, I think it was a huge boost overall. > But I agree, many developers are familiar with a pull-request > development model, and I think it has many advantages over our current > way of doing things, I'd be very much in favour of switching to a PR > style system. > > That doesn't mean there aren't also advantages to how we do things > today. Agreed also. -- Joel