Re: Adding binutils to the GNU Toolchain buildbot on sourceware

[Mark Wielaard <mark@klomp.org>]

[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]

Hi Frank,

On Tue, Apr 26, 2022 at 05:40:25AM -0400, Frank Ch. Eigler via Overseers wrote:
> > Unfortunately gdb's testsuite is not too reliable. It's been improved over
> > the years, but still gives quite a bit of non-deterministic results based on
> > distro version/compiler version etc. So I'd leave those out in favor of just
> > making sure things build properly.
> 
> This problem is why we're building out a gadget called bunsen, which
> is a tool to absorb histories of testsuites, and draw statistical
> conclusions.  Still early days, but noisy testsuites are not a
> problem.

Right. And because Keith is very involved with this having builders
that feed bunsen lots of gdb testsuite results is important. Sorry if
I made it sound like "large checks" aren't important for the
builder. They are!

But I do think we should try to split the "heavy test everything
builders" from the "quick sanity check builders" a bit.

e.g. maybe we can use the fedrawhide-x86_64 worker only for the full
gdb-binutils builder and use another worker for the "quick" binutils
only builder. That way a "quick" builder doesn't get behind a couple
of "heavy" builds (which means you might get your quick result only
after a couple of hours).

How about using the other fedora-x86_64 worker (as attached)?

I tried a couple of other workers, but some were too slow, or didn't
generate a clean make check-ld results.

Cheers,

Mark

[-- Attachment #2: binutils-fedora-x86_64.patch --]
[-- Type: text/x-diff, Size: 2409 bytes --]

diff --git a/builder/master.cfg b/builder/master.cfg
index 340904f..b706401 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -123,7 +123,7 @@ debian_ppc64_worker = worker.Worker("debian-ppc64",
                                                        'fitzsim@fitzsim.org']);
 c['workers'].append(debian_ppc64_worker)
 
-# Power VM run by Tom on a Talos workstation
+# Frank's Fedora Rawhide builder
 fedrawhide_x86_64_worker = worker.Worker("fedrawhide-x86_64",
                                     getpw("fedrawhide-x86_64"),
                                     max_builds=1,
@@ -374,7 +374,8 @@ binutils_scheduler = schedulers.SingleBranchScheduler(
         change_filter=util.ChangeFilter(project="binutils-gdb",
                                         branch="master"),
         fileIsImportant=binutilsImportant,
-        builderNames=["binutils-debian-amd64", "binutils-fedrawhide-x86_64"])
+        builderNames=["binutils-debian-amd64",
+                      "binutils-fedora-x86_64"])
 c['schedulers'].append(binutils_scheduler)
 
 # Only trigger scheduler for changes to gdb (or deps)
@@ -1146,12 +1147,12 @@ binutils_debian_amd64_builder = util.BuilderConfig(
         factory=binutils_factory)
 c['builders'].append(binutils_debian_amd64_builder)
 
-binutils_fedrawhide_x86_64_builder = util.BuilderConfig(
-        name="binutils-fedrawhide-x86_64",
-        workernames=["fedrawhide-x86_64"],
+binutils_fedora_x86_64_builder = util.BuilderConfig(
+        name="binutils-fedora-x86_64",
+        workernames=["fedora-x86_64"],
         tags=["binutils", "fedora", "x86_64"],
         factory=binutils_factory)
-c['builders'].append(binutils_fedrawhide_x86_64_builder)
+c['builders'].append(binutils_fedora_x86_64_builder)
 
 # gdb build steps, factory and builders
 
diff --git a/htdocs/index.html b/htdocs/index.html
index b08a17b..d732d5d 100644
--- a/htdocs/index.html
+++ b/htdocs/index.html
@@ -34,6 +34,8 @@
 	  <td><a href="/buildbot/#/builders?tags=binutils">binutils</a></td>
 	  <td><a href="/buildbot/#builders/binutils-debian-amd64">debian-amd64<br>
               <img src="/buildbot/badges/binutils-debian-amd64.svg"></a></td>
+	  <td><a href="/buildbot/#builders/binutils-fedora-x86_64">fedora-x86_64<br>
+              <img src="/buildbot/badges/binutils-fedora-x86_64.svg"></a></td>
 	</tr>
 	<tr>
 	  <td><a href="/buildbot/#/builders?tags=bzip2">bzip2</a></td>