From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 7E07A3858C83; Tue, 26 Apr 2022 22:34:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E07A3858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x0b.wildebeest.org [172.31.17.141]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 11192302BBED; Wed, 27 Apr 2022 00:34:11 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id AF3732E82D76; Wed, 27 Apr 2022 00:34:11 +0200 (CEST) Date: Wed, 27 Apr 2022 00:34:11 +0200 From: Mark Wielaard To: Luis Machado Cc: "Frank Ch. Eigler" , Overseers mailing list , binutils@sourceware.org, "gdb@sourceware.org" Subject: Re: Adding binutils to the GNU Toolchain buildbot on sourceware Message-ID: References: <5c1f217a-109c-2973-6c69-abf412133dee@arm.com> <524b04b7-a78c-7aae-4605-b40f61e6830c@arm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="ePX3+SIwIKTfUMoB" Content-Disposition: inline In-Reply-To: <524b04b7-a78c-7aae-4605-b40f61e6830c@arm.com> X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 22:34:15 -0000 --ePX3+SIwIKTfUMoB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Luis, On Tue, Apr 26, 2022 at 08:01:33AM +0100, Luis Machado wrote: > > If so lets just pick one or more of the workers which seem like stable > > distros/arches that should always build gdb: > > https://builder.sourceware.org/buildbot/#/workers > > (don't pick sourceware, which is special, debian-arm64, debian-armhf, > > debian-i386 or fedora-ppc64 which are too slow) > > > > Provide a file list (directories) of files in the binutils-gdb.git > > repo that should trigger a build. > > > > A configure and make line that does a quick build for just > > gdb/gdbserver which should always build. > > I think the following will do: > > ./configure --enable-targets=all; make all-gdb all-gdbserver > > or > > ./configure --enable-targets=all --disable-sim; make all-gdb all-gdbserver > > gdbserver, unlike gdb, will only build natively, hence why it would benefit > from being built everywhere. I added a gdb-centos-x86_64 builder. That is a fairly old distro (it is centos7) but the worker isn't used for that many other builds and it can do a quick compile in under 5 minutes. Once it works out I'll add some other distro/arches. Please review the gdb important files list. I might have missed some directoy. Thanks, Mark --ePX3+SIwIKTfUMoB Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Add-gdb-centos-x86_64-builder.patch" >From fa23744e04367b2d6f2081fd90bc58ad6d7ff6a6 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Wed, 27 Apr 2022 00:29:38 +0200 Subject: [PATCH] Add gdb-centos-x86_64 builder --- builder/master.cfg | 68 ++++++++++++++++++++++++++++++++++++++++++++++ htdocs/index.html | 5 ++++ 2 files changed, 73 insertions(+) diff --git a/builder/master.cfg b/builder/master.cfg index 45066b8..340904f 100644 --- a/builder/master.cfg +++ b/builder/master.cfg @@ -377,7 +377,30 @@ binutils_scheduler = schedulers.SingleBranchScheduler( builderNames=["binutils-debian-amd64", "binutils-fedrawhide-x86_64"]) c['schedulers'].append(binutils_scheduler) +# Only trigger scheduler for changes to gdb (or deps) +gdb_files = ["bfd/", + "gdb/", "gdbserver/", "gdbsupport/", + "gnulib/", "sim/", + "include/", "libiberty/", "opcodes/", + "configure", "Makefile.in"] + +def gdbImportant(change): + for file in change.files: + for pattern in gdb_files: + match = re.match(pattern, file) + if match: + return True + return False + +gdb_scheduler = schedulers.SingleBranchScheduler( + name="gdb", + change_filter=util.ChangeFilter(project="binutils-gdb", + branch="master"), + fileIsImportant=gdbImportant, + builderNames=["gdb-centos-x86_64"]) +c['schedulers'].append(gdb_scheduler) +# A scheduler for everything binutils-gdb without filters binutils_gdb_scheduler = schedulers.SingleBranchScheduler( name="binutils-gdb", change_filter=util.ChangeFilter(project="binutils-gdb", @@ -1130,6 +1153,41 @@ binutils_fedrawhide_x86_64_builder = util.BuilderConfig( factory=binutils_factory) c['builders'].append(binutils_fedrawhide_x86_64_builder) +# gdb build steps, factory and builders + +gdb_factory = util.BuildFactory() +gdb_factory.addStep(steps.Git( + workdir='binutils-gdb', + repourl=binutils_gdb_repourl, + mode='full', method='fresh', + name="git checkout", + haltOnFailure=True)) +gdb_factory.addStep(steps.ShellCommand( + command=["rm", "-rf", + util.Interpolate ("%(prop:builddir)s/gdb-build")], + name="rm -rf gdb-build", + haltOnFailure=True)) +gdb_factory.addStep(steps.Configure( + workdir='gdb-build', + command=['../binutils-gdb/configure', + '--enable-target=all'], + name='configure', + haltOnFailure=True)) +gdb_factory.addStep(steps.Compile( + workdir='gdb-build', + command=['make', + util.Interpolate('-j%(prop:ncpus)s'), + 'all-gdb', 'all-gdbserver'], + name='make', + haltOnFailure=True)) + +gdb_centos_x86_64_builder = util.BuilderConfig( + name="gdb-centos-x86_64", + workernames=["centos-x86_64"], + tags=["gdb", "centos", "x86_64"], + factory=gdb_factory) +c['builders'].append(gdb_centos_x86_64_builder) + # binutils-gdb build steps, factory and builders # just a native build @@ -1468,6 +1526,16 @@ mn_binutils = reporters.MailNotifier( generators=[generator_binutils]) c['services'].append(mn_binutils) +# Report for the whole gdb tagged builder set +generator_gdb = reporters.BuildSetStatusGenerator( + mode=('change',), tags=['gdb']) +mn_gdb = reporters.MailNotifier( + fromaddr="builder@sourceware.org", + sendToInterestedUsers=True, + extraRecipients=['gdb-testers@sourceware.org'], + generators=[generator_gdb]) +c['services'].append(mn_gdb) + # Report for the whole libabigail tagged builder set generator_libabigail = reporters.BuildSetStatusGenerator( mode=('change',), tags=['libabigail']) diff --git a/htdocs/index.html b/htdocs/index.html index 9d12fb9..b08a17b 100644 --- a/htdocs/index.html +++ b/htdocs/index.html @@ -144,6 +144,11 @@ fedora-ppc64le
+ + gdb + centos-x86_64
+
+ libabigail centos-x86_64
-- 2.30.2 --ePX3+SIwIKTfUMoB--