public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Carl Love <cel@us.ibm.com>
Cc: Luis Machado <luis.machado@arm.com>,
	Will Schmidt <will_schmidt@vnet.ibm.com>,
	gdb@sourceware.org, buildbot@sourceware.org
Subject: Re: [builder] gdb_check_step: remove gdb.gdb/selftest.exp
Date: Thu, 30 Jun 2022 00:42:38 +0200	[thread overview]
Message-ID: <YrzVXuE47EGDh09c@wildebeest.org> (raw)
In-Reply-To: <3df33b29575bcd78d12c5178dadd274b225b0e7d.camel@us.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]

Hi Carl,

On Wed, Jun 29, 2022 at 08:58:43AM -0700, Carl Love wrote:
> The test was failing the same way when running locally.  It was a test
> issue related to checking for hardware watchpoint support on PowerPC. I
> posted a patch to fix it.  Andrew Burgess merged a similar patch that
> he did to fix the test with my patch and committed the fix.  The test
> is now running correctly locally.  Note, I have not tested it in the
> remote configuration as you mentioned.   Here is the commit for the
> fix:
> 
> commit 13f72372413400410aaa94b7f0e2ff7de663fdcb
> Author: Carl Love <cel@us.ibm.com>
> Date:   Wed Jun 22 16:14:20 2022 +0100
> 
>     gdb/testsuite: fix gdb.base/break-idempotent.exp on ppc
>     
>     When running the gdb.base/break-idempotent.exp test on ppc, I was
>     seeing some test failures (or rather errors), that looked like
> this:
>     
>       (gdb) watch local
>       Hardware watchpoint 2: local
>     
>       has_hw_wp_support: Hardware watchpoint detected
>       ERROR: no fileid for gcc2-power8
>       ERROR: Couldn't send delete breakpoints to GDB.
>       ERROR OCCURED: can't read "gdb_spawn_id": no such variable
>           while executing
> ...
> 
> Please let me know if you see any additional issues with the test. 

Lets add it back to the buildbot tests and see if anything breaks.

Cheers,

Mark

[-- Attachment #2: 0001-gdb_test_exp-Add-gdb.base-break-idempotent.exp-back.patch --]
[-- Type: text/x-diff, Size: 844 bytes --]

From a1f7675ab2fa8a4c987d0e7f1fb53de564cf9ed9 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Thu, 30 Jun 2022 00:40:08 +0200
Subject: [PATCH] gdb_test_exp: Add gdb.base/break-idempotent.exp back

This should now work on all arches
---
 builder/master.cfg | 1 +
 1 file changed, 1 insertion(+)

diff --git a/builder/master.cfg b/builder/master.cfg
index 219f88d..729ec37 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -1820,6 +1820,7 @@ gdb_test_exp = ("TESTS= "
                 "gdb.base/break-entry.exp "
                 "gdb.base/break.exp "
                 "gdb.base/break-fun-addr.exp "
+                "gdb.base/break-idempotent.exp "
                 "gdb.base/break-include.exp "
                 "gdb.base/break-inline.exp "
                 "gdb.base/break-main-file-remove-fail.exp "
-- 
2.30.2


      reply	other threads:[~2022-06-29 22:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08 18:51 Mark Wielaard
2022-06-09  9:37 ` Luis Machado
2022-06-09 23:09   ` Mark Wielaard
2022-06-09 23:21     ` Mark Wielaard
2022-06-10 10:50       ` Mark Wielaard
2022-06-10 10:58         ` Luis Machado
2022-06-10 15:17           ` will schmidt
2022-06-10 15:54           ` Carl Love
2022-06-10 19:11             ` Mark Wielaard
2022-06-10 20:11               ` Carl Love
2022-06-10 22:23                 ` Frank Ch. Eigler
2022-06-29 15:58               ` Carl Love
2022-06-29 22:42                 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrzVXuE47EGDh09c@wildebeest.org \
    --to=mark@klomp.org \
    --cc=buildbot@sourceware.org \
    --cc=cel@us.ibm.com \
    --cc=gdb@sourceware.org \
    --cc=luis.machado@arm.com \
    --cc=will_schmidt@vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).