From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id AAC2B3858D33; Sun, 15 Oct 2023 10:37:59 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AAC2B3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697366281; cv=none; b=GPF2EcJGrqi0l12UD+g0xvocBE60mQCB68o+hU7QcCEPVMFJPfKJ7JPJ9lXUHXqgiGALhqDdJYduu1a+2uzzafzz/q8ucukMLp5fHtCQWhD92OHDcxv+mAtGzfeyr7kA9YNb40Ilj11047ASX8JPWjoV2OFOFmu7yelNFb39Ik0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697366281; c=relaxed/simple; bh=DcPJjMnOmELunTgjr8DbihH9r2gB5wTvIqKZuWrCMKk=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=iwwrg9mqh6Wh/0LBgDQ46+q+ubOjRJEgeV2y7sMwsQZ2Tu6MLlnoRyIc7hto5viZN1ucdEanDh0Dwl79gWLCUmwPsMjuk4vDSsg+pQ5aaiqriFSXui7wMGaA+cadqHTI6vyiCTK2ILd3DC8NKqZQFEfribIzToe3ayvRhooQ/p8= ARC-Authentication-Results: i=1; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AAC2B3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 54372335CCD; Sun, 15 Oct 2023 10:37:59 +0000 (UTC) Date: Sun, 15 Oct 2023 16:22:57 +0545 From: Mike Frysinger To: Jan-Benedict Glaw Cc: gdb-patches@sourceware.org, gdb@sourceware.org, joel@rtems.org Subject: Re: [PATCH] sim: mips/ppc/riscv: re-add AC_CANONICAL_SYSTEM [PR sim/29439] Message-ID: References: <20221023171147.12371-1-vapier@gentoo.org> <20230303212758.jeukghx7kmxhn6cx@lug-owl.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SSQrAcE+Wd4TqDir" Content-Disposition: inline In-Reply-To: <20230303212758.jeukghx7kmxhn6cx@lug-owl.de> X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --SSQrAcE+Wd4TqDir Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 03 Mar 2023 22:27, Jan-Benedict Glaw wrote: > On Sun, 2022-10-23 22:56:47 +0545, Mike Frysinger via Gdb-patches wrote: > > These configure scripts check $target and change behavior. They > > shouldn't be doing that, but until we can rework the sim to change > > behavior based on the input ELF, restore AC_CANONICAL_SYSTEM to > > these so that $target is correctly populated. > >=20 > > This was lost in the d3562f83a7b8a1ae6e333cd5561419d3da18fcb4 > > ("sim: unify toolchain probing logic") refactor as the logic was > > hoisted up to the common code. But the fact the vars weren't > > passed down to the sub-configure scripts was missed. > >=20 > > Bug: https://sourceware.org/PR29439 >=20 > This fix seems to have a side effect: >=20 > .../configure --prefix=3D/tmp/gdb-mipsisa64sb1-elf --target=3Dmipsisa64sb= 1-elf >=20 > make V=3D1 all-gdb > [...] > [all 2023-03-03 21:07:56] /usr/lib/gcc-snapshot/bin/gcc -DHAVE_CONFIG_H = -DWITH_TARGET_WORD_BITSIZE=3D64 -DWITH_TARGET_WORD_MSB=3D63 -DWITH_FLOATING= _POINT=3DHARD_FLOATING_POINT -DWITH_TARGET_FLOATING_POINT_BITSIZE=3D64 -DWI= TH_HW=3D1 -DHAVE_DV_SOCKSER -DDEFAULT_INLINE=3D0 -Wall -Wdeclaration-after-= statement -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno= -switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wno-e= rror=3Dmaybe-uninitialized -Wmissing-declarations -Wmissing-prototypes -Wde= claration-after-statement -Wmissing-parameter-type -Wpointer-sign -Wold-sty= le-declaration -Werror -I. -I/var/lib/laminar/run/gdb-mipsisa64sb1-elf/51/= binutils-gdb/sim/mips -I../common -I/var/lib/laminar/run/gdb-mipsisa64sb1-e= lf/51/binutils-gdb/sim/mips/../common -I../../include -I/var/lib/laminar/ru= n/gdb-mipsisa64sb1-elf/51/binutils-gdb/sim/mips/../../include -I../../bfd -= I/var/lib/laminar/run/gdb-mipsisa64sb1-elf/51/binutils-gdb/sim/mips/../../b= fd -I../../opcodes -I/var/lib/laminar/run/gdb-mipsisa64sb1-elf/51/binutils-= gdb/sim/mips/../../opcodes -I../.. -I/var/lib/laminar/run/gdb-mipsisa64sb1= -elf/51/binutils-gdb/sim/mips/../../gnulib/import -I../../gnulib/import -DT= ARGET_ENABLE_FR=3D1 -DMIPS_MACH_DEFAULT=3Dbfd_mach_mips_sb1 -g -O2 -c -o = semantics.o -MT semantics.o -MMD -MP -MF .deps/semantics.Tpo semantics.c > [all 2023-03-03 21:07:56] sb1.igen: In function 'semantic_PABSDIFC_fmt_MD= MX': > [all 2023-03-03 21:07:56] sb1.igen:178:21: error: unknown conversion type= character 'v' in format [-Werror=3Dformat=3D] > [all 2023-03-03 21:07:56] 178 | check_mdmx (SD_, instruction_0); > [all 2023-03-03 21:07:56] | ^~~~~~~~~~~~~~ = =20 > [all 2023-03-03 21:07:56] sb1.igen:178:21: error: format '%ld' expects ar= gument of type 'long int', but argument 9 has type 'unsigned int' [-Werror= =3Dformat=3D] > [all 2023-03-03 21:07:56] 178 | check_mdmx (SD_, instruction_0); > [all 2023-03-03 21:07:56] | ^~~~~~~~~~~~~~ = =20 > [all 2023-03-03 21:07:56] sb1.igen:178:21: error: too many arguments for = format [-Werror=3Dformat-extra-args] > [all 2023-03-03 21:08:05] cc1: all warnings being treated as errors i doubt this patch is related to that failure. seems likely sb1.igen has always been broken. -mike --SSQrAcE+Wd4TqDir Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEfjLn+uywF2RXRpXdyTaAqES06MkFAmUrwQUACgkQyTaAqES0 6Mko+gv6AstUfvNJ/b+o0i7q3MZgQZ/EWg7iPmByHdIJZkHYJyCqua+wM7cpLHEK WizEIIwkAvKdkEJ69ul1wZ5O9mmHbr39iRPRpQuHlSoMpLzMaUfh661oFbCWVPnk MKEw4L/7JyLWRji6zwOuklSHEkQ/BbB7OWifQ8QX5Z3w/DJqB0fY1HKXgbCMGpj6 lMyc03mRoVQK2HZj3BxgnagEUUw+rCR2ltCSI3GINGis8HekElf7Da0BlI0sdDEd u6EM1BEBTEpoklffWGkxVNjBcTirQpP22cRJgCa3u20ZfpLSJ3KqLDZqzXLsRXWQ 6GKUf/gIvgRAcXdgzaPjUNz+ymtah5q31RHDtR2TlWPLPzSmYx/+O81FBKzcPnYN R94XQvHUJ+64XRJ/qwRPwGqyVJUyMVv5Ggqmrno1vPZeoks43dYKTMNDVxdBuMea bowGP6znWHTBLczqxBxw1Bas0ArW9ycuUnxe00YPwRjptWoPeTi+NFraO5rIOlNi YZ2kMFOe =keE7 -----END PGP SIGNATURE----- --SSQrAcE+Wd4TqDir--