From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Tom Tromey <tromey@redhat.com>,
Sergio Durigan Junior <sergiodj@redhat.com>,
Jan Kratochvil <jan.kratochvil@redhat.com>, <gdb@sourceware.org>
Subject: Re: Switch -Wunused-variable on?
Date: Wed, 25 Apr 2012 17:22:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1204251811320.19835@tp.orcam.me.uk> (raw)
In-Reply-To: <m2ty07ycvz.fsf@igel.home>
On Wed, 25 Apr 2012, Andreas Schwab wrote:
> >> It also requires an unconditional declaration and definition of
> >> target_frobnicate_harder.
> >
> > Yes, but do you see at as advantage or disadvantage?
>
> It makes your example non-working as written due to the missing
> declaration.
The declaration should be moved outside the conditional, I've overlooked
that, sorry. If target_frobnicate_harder is external then the prototype
will be in a header anyway.
And such an unconditional declaration is actually good for conditional
pieces that are rarely enabled -- people making bulk changes will still
receive the usual diagnostics about this function's argument type
compatibility, etc. even if this piece of code is actually not used for
the configuration they chose, as long as this source file is compiled at
all.
Then you don't actually need a definition, because the call will be
optimised away (together with the whole enclosing "if (0)" block) by the
compiler. There's nothing wrong with having a declaration and no
definition for an entity that's never eventually used.
Maciej
next prev parent reply other threads:[~2012-04-25 17:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-22 8:06 Sergio Durigan Junior
2012-04-22 8:23 ` Jan Kratochvil
2012-04-22 20:25 ` Sergio Durigan Junior
2012-04-22 22:25 ` Jeffrey Walton
2012-04-23 8:55 ` Jan Kratochvil
2012-04-23 14:30 ` Tom Tromey
2012-04-23 15:49 ` Sergio Durigan Junior
2012-04-23 18:02 ` Pedro Alves
2012-04-23 18:39 ` Michael Eager
2012-04-24 22:11 ` Maciej W. Rozycki
2012-04-25 7:51 ` Andreas Schwab
2012-04-25 15:57 ` Maciej W. Rozycki
2012-04-25 16:50 ` Andreas Schwab
2012-04-25 17:22 ` Maciej W. Rozycki [this message]
2012-04-25 18:13 ` Andreas Schwab
2012-04-25 18:20 ` Sterling Augustine
2012-04-25 18:52 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1204251811320.19835@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=gdb@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=schwab@linux-m68k.org \
--cc=sergiodj@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).