From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <macro@linux-mips.org>
Received: from orcam.me.uk (unknown [157.25.102.26])
 by sourceware.org (Postfix) with ESMTP id 0D6363857827
 for <gdb@sourceware.org>; Sun,  4 Oct 2020 17:56:11 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0D6363857827
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=linux-mips.org
Authentication-Results: sourceware.org;
 spf=none smtp.mailfrom=macro@linux-mips.org
Received: from bugs.linux-mips.org (eddie.linux-mips.org
 [IPv6:2a01:4f8:201:92aa::3])
 by orcam.me.uk (Postfix) with ESMTPS id 68BE62BE086;
 Sun,  4 Oct 2020 18:56:10 +0100 (BST)
Date: Sun, 4 Oct 2020 18:56:06 +0100 (BST)
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Eli Zaretskii <eliz@gnu.org>
cc: gdb@sourceware.org
Subject: Re: Running selftests in GDB
In-Reply-To: <83pn5ydkxq.fsf@gnu.org>
Message-ID: <alpine.LFD.2.21.2010041851220.333514@eddie.linux-mips.org>
References: <83h7rimej3.fsf@gnu.org> <83pn65lu67.fsf@gnu.org>
 <alpine.LFD.2.21.2010041648350.333514@eddie.linux-mips.org>
 <83pn5ydkxq.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb mailing list <gdb.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb>,
 <mailto:gdb-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb>,
 <mailto:gdb-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Oct 2020 17:56:12 -0000

On Sun, 4 Oct 2020, Eli Zaretskii wrote:

> > > Answering myself: after reconfiguring with --enable-unit-tests, one
> > > should make sure gdb/init.c is regenerated.  It looks like it won't be
> > > regenerated, unless you touch one of the source files mentioned in
> > > COMMON_SFILES by gdb/Makefile.
> > 
> >  It looks like a dependency needs to be added to gdb/Makefile.in for 
> > gdb/init.c on whatever is changed with `--enable-unit-tests' that affects 
> > the file; can you run a diff on the object tree configured with and 
> > without the option to figure out what has changed that affects gdb/init.c?
> 
> AFAIR, the object tree didn't change, but SELFTESTS_OBS don't appear
> in CONFIG_OBS.  When you reconfigure, SELFTESTS_OBS gets added to
> CONFIG_OBS, but there's nothing to trigger init.c regeneration.

 Well, it couldn't have been that the object tree didn't change then, as 
the addition of SELFTESTS_OBS to CONFIG_OBS is clearly a change. :)  It 
looks to me like gdb/Makefile should be a dependency of gdb/init.c then 
(or stamp-init really).

  Maciej