From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by sourceware.org (Postfix) with ESMTPS id 163F53857823 for ; Wed, 17 Mar 2021 17:24:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 163F53857823 Received: by mail-qt1-x830.google.com with SMTP id h7so1994073qtx.3 for ; Wed, 17 Mar 2021 10:24:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=n7Y9qcUYIXbUwRNjh+DHva6NeuABYzYiErEPqbHxJOs=; b=DZgqz/FVbRexmbZuBuX6IM20uSEqrrzyTwzS4iHHLldKVHoLqttTemU25zTbIvBz+Z cA/ewqSFPOIKHSejQbYg2LKDdIuSYE8uXWxUHLBD0KvfwuZpsAdZMv8KdH1B+7iLGQwz pCAvs7dI4eUJ2GiewkoQkLM+gSYfVCHX4l0RON9dHKaZxlRw+p9nZj2S9x3EOUL59mVv ug+ss2KirvxOmF3qv8ywhFfwmLVd3IKegll1dA/woaTdebdRc5q7fM2Fvya6rqqXV5UM hPwO0fyL6QxuogHLuNnhed3fI2uBxK1yZEOTH+vr/zbMgnlLqzi5T4i1nS2q8AMkLE9A doqA== X-Gm-Message-State: AOAM531J+2l4+UBKwg+LweBx9sXIIlQP1AfLt2iKkw7xdcJrOYGXzTsS AkgWvvj913DmLikJmXbduX5VMw== X-Google-Smtp-Source: ABdhPJz6HkJLvfvZuLAEEzcYQzwOHRQ311M7gbhprLELOgwV3/oM+yy8uVZ91RSEHNFy8U+PwNjU1g== X-Received: by 2002:aed:2f25:: with SMTP id l34mr117242qtd.152.1616001871975; Wed, 17 Mar 2021 10:24:31 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:2841:c502:89bb:c3bf:f9a1? ([2804:7f0:4841:2841:c502:89bb:c3bf:f9a1]) by smtp.gmail.com with ESMTPSA id d16sm17621288qka.43.2021.03.17.10.24.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Mar 2021 10:24:31 -0700 (PDT) Subject: Re: sim: replacing ChangeLog files with online git logs To: Eli Zaretskii , Simon Marchi Cc: gdb@sourceware.org, Mike Frysinger References: <83ft0zjys1.fsf@gnu.org> <83lfarhwjq.fsf@gnu.org> <83eegjhuuq.fsf@gnu.org> <8335wyj461.fsf@gnu.org> <83tup9disi.fsf@gnu.org> <2012fb21-38f2-3d1c-62c8-52d94d19e243@linaro.org> <83pmzxdegd.fsf@gnu.org> <83o8fhddg3.fsf@gnu.org> <18f4f0e2-0a35-a6c5-1886-943f81f817fd@linaro.org> <83mtv1dbzr.fsf@gnu.org> <83im5pdao2.fsf@gnu.org> From: Luis Machado Message-ID: Date: Wed, 17 Mar 2021 14:24:27 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <83im5pdao2.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 17:24:34 -0000 On 3/17/21 1:09 PM, Eli Zaretskii wrote: >> Cc: gdb@sourceware.org >> From: Simon Marchi >> Date: Wed, 17 Mar 2021 11:52:49 -0400 >> >> In the GDB project, we write what I believe are excellent git commit >> messages that go in depth describing the observed problem and the >> solution provided by the patch. That provides valuable information for >> anyone wanting to understand why the code is the way it is. A list of >> modified symbols doesn't help. So I am completely fine if the "list of >> modified symbols" part of the information is lost. > > Well, if that's what the majority here wants, then so be it. That's what we should assess. From chatting with other active GDB developers, my feeling is that most of us want to drop the process of having to write ChangeLog entries manually. But we tend to keep quiet and carry on doing it. > > (The importance of having the list of modified symbols in the log is > that then one doesn't need advanced Git commands to find out which > changes modified a given function and why.) > I understand the concern about git. I used to find git a bit too cryptic too, but using it daily has made that better. Now git log/git blame shows very useful information when I'm looking for specific changes from a commit, and I rarely need to go through ChangeLogs other than to find commits that touched a particular function/variable. The auto-generated ChangeLog entry may still help with that, but it would be auto-generated instead of taking time away from active developers. >>> If that is not an option that this community wants to adopt, then >>> gitlog-to-changelog is probably not the adequate solution, and we >>> should try using vcs-to-changelog.py (also in Gnulib). >> >> I tried vcs-to-changelog, it gave horrible/useless results with our >> codebase. This is not an option. > > Too bad. Maybe we should report this to the developer of the script, > it could help fix those shortcomings in the future. > Maybe. But looking into the future, parsing C++ to extract that kind of information is really not trivial. So it may never work in a reasonable way for GDB without some serious effort put into the script.