From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by sourceware.org (Postfix) with ESMTPS id E32903858CDA for ; Thu, 14 Sep 2023 20:26:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E32903858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=foss.st.com Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 38EJdmsL026018; Thu, 14 Sep 2023 22:26:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=1Xig9X9e9z2Jsu0T2hTQ6KKTFVhibJY+rLtU38uoJpg=; b=xY q1EnwCUm1GMmfRWqtg4p8KQX6YRHLWW82jhK7IHNKZgkSJqi2St411rFmgXx2mOb V+EtSu4ztSPYry1kt04SDZUuWR8R/sZbEP+mfiN2UfUWPtFulLXnJnIHqPN7M6RG zH8u8D1amfIl/aBw7RHYlpgpQ2IemAkl0Kcb8LasskbESdefrGSFAn9q2zsVHR5l /mFcdEQnUb3z5dMI7RksW8TZsdLf9KiQsLfOI4xBAbkVG0jadZMWE6NXvd2JH0s3 RPvgR8Hrr2dwobR+KES466ufzZI0IlMV7pe0kgW/8CJyZOyB+K+5JZfLlL5g3yPp 8LLvzOAuShSaCrH5NAsA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3t3tyw3r8h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Sep 2023 22:26:35 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 7A88410005A; Thu, 14 Sep 2023 22:26:34 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 47DE02085C0; Thu, 14 Sep 2023 22:26:34 +0200 (CEST) Received: from [10.252.1.152] (10.252.1.152) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 14 Sep 2023 22:26:33 +0200 Message-ID: Date: Thu, 14 Sep 2023 22:26:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: GDB13 fails to build on MacOS using supplied GNU Bison 2.3 Content-Language: en-US To: , Tom Tromey References: <0badf084-d0b7-54bb-aec6-b79f29ad191d@foss.st.com> <87jztbpccn.fsf@tromey.com> <0007c884-16a1-2fe3-e574-d9fe5c944c83@foss.st.com> <87bkenoxvf.fsf@tromey.com> <875y4uoxl6.fsf@tromey.com> From: Torbjorn SVENSSON In-Reply-To: <875y4uoxl6.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.252.1.152] X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-14_12,2023-09-14_01,2023-05-22_02 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom, Sorry for taking so long to check your patch, but I've been OoO for the past 2 weeks. What type of tests did you have in mind when you, in a previous mail in the same thread, wrote: If the appended works for you (be sure to run some tests), I can check it in. Is it sufficient with a simple C project and a simple C++ project (my example was using std::vector to get some namespace and template expansion) built for arm-none-eabi? Those 2 projects appears to work as expected anyway. Kind regards, Torbjörn On 2023-09-01 15:02, Tom Tromey wrote: > Martin> Also need to patch gdb/split-name.c? > > Really thought I built it but apparently not. Thanks. > > Tom > > diff --git a/gdb/dwarf2/cooked-index.c b/gdb/dwarf2/cooked-index.c > index d6531260c86..58ea541a5c9 100644 > --- a/gdb/dwarf2/cooked-index.c > +++ b/gdb/dwarf2/cooked-index.c > @@ -267,7 +267,7 @@ cooked_index_shard::handle_gnat_encoded_entry (cooked_index_entry *entry, > if (canonical.empty ()) > return {}; > std::vector names = split_name (canonical.c_str (), > - split_style::DOT); > + split_style::DOT_STYLE); > gdb::string_view tail = names.back (); > names.pop_back (); > > diff --git a/gdb/split-name.c b/gdb/split-name.c > index a50a6fa4946..0253b3cf675 100644 > --- a/gdb/split-name.c > +++ b/gdb/split-name.c > @@ -58,7 +58,7 @@ split_name (const char *name, split_style style) > } > break; > > - case split_style::DOT: > + case split_style::DOT_STYLE: > /* D and Go-style names. */ > for (const char *iter = strchr (name, '.'); > iter != nullptr; > diff --git a/gdb/split-name.h b/gdb/split-name.h > index 47896cc4406..7648cf9b900 100644 > --- a/gdb/split-name.h > +++ b/gdb/split-name.h > @@ -30,8 +30,9 @@ enum class split_style > NONE, > /* C++ style, with "::" and template parameter intelligence. */ > CXX, > - /* Split at ".". Used by Ada, Go, D. */ > - DOT, > + /* Split at ".". Used by Ada, Go, D. This has a funny name to work > + around a bug in Bison 2.3, which is used on macOS. */ > + DOT_STYLE, > /* Split at "__". Used by Ada encoded names. */ > UNDERSCORE, > }; > diff --git a/gdb/symtab.h b/gdb/symtab.h > index ca3b1a4a0b6..8f587807ff9 100644 > --- a/gdb/symtab.h > +++ b/gdb/symtab.h > @@ -305,7 +305,7 @@ class lookup_name_info final > break; > case language_d: > case language_go: > - style = split_style::DOT; > + style = split_style::DOT_STYLE; > break; > } > return ::split_name (language_lookup_name (lang), style);