From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 2DFCD38618D4 for ; Fri, 19 Mar 2021 03:29:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2DFCD38618D4 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12J3TrTl027245 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Mar 2021 23:29:57 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12J3TrTl027245 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5C1F51E789; Thu, 18 Mar 2021 23:29:52 -0400 (EDT) Subject: Re: where to put defines for exception numbers as encoded in ARM CoreSight ETM traces To: Zied Guermazi , "gdb@sourceware.org" References: From: Simon Marchi Message-ID: Date: Thu, 18 Mar 2021 23:29:51 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 19 Mar 2021 03:29:53 +0000 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Mar 2021 03:30:00 -0000 > hi > > in ETM traces (3.4 and above), exception encodings for non v7m processors (v7A, is done in a 4 bit field, defined in table 7.12 - (https://developer.arm.com/documentation/ihi0014/q/ETMv3-Signal-Protocol/Instruction-tracing/Branch-Packets?lang=en#BABIECBB ). This is not the same encoding as for exception vector. > > This is needed for handling the implementation of breakpoints as an undefined instruction trap in GDB for ARMv7 while decoding ETM traces (branch tracing extension to use ARM CoreSight ETM) > > what will be a good location for adding defines for this exception encoding? will it be fine to add them in arch/arm.h? shall I create a new header file for them? please advise. > > Kind Regards > > Zied Guermazi Hi, I don't know the specific details of this problem, but yes a file under arch/ sounds fine. These files contain definitions and helpers shared between gdb and gdbserver (yes, even though it's under the gdb directory). Puting them in arm.h or in a new file are both fine. Simon