From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 6909E3858C2D for ; Tue, 27 Sep 2022 12:03:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6909E3858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 26E291E0D3; Tue, 27 Sep 2022 08:03:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1664280234; bh=grhGjwFDXY3DUP/SGI3St9uRI+KMrX06cnN7YSJ/Wdo=; h=Date:Subject:To:References:From:In-Reply-To:From; b=NS+bsz085ADaRssmT2En9RZcaZREk3r6wNo7jJt/wyX9iU5LD7FvtZx0p2am+9xwG /4HwXWxD3GML6sAjxVO0vWm1r9UDeA9iRquNks3mdAjDFzjdMT3ZJO+D8PGWiGoOKJ 7VLORaVz92aYd+Av5gjzlyAWXZeIxV8Ko9yrfowQ= Message-ID: Date: Tue, 27 Sep 2022 08:03:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: Proposal: Add review tags to patch review workflow. Content-Language: en-US To: Bruno Larsen , gdb@sourceware.org References: <453759b1-1ddf-1aff-a033-6183b84a4a4d@simark.ca> <08d732c8-2c5e-c9d6-5d37-7a740bf73255@redhat.com> From: Simon Marchi In-Reply-To: <08d732c8-2c5e-c9d6-5d37-7a740bf73255@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-09-27 03:58, Bruno Larsen via Gdb wrote: > > On 26/09/2022 15:55, Simon Marchi wrote: >> >> On 2022-09-21 07:04, Bruno Larsen via Gdb wrote: >>> TL;DR: I want to introduce the usage of 3 new review tags to the GDB patch review workflow. They are: Reviewed-by, Approved-by and Tested-by. >> Hi Bruno, >> >> I completely agree with the proposal.  I really like the fact that it >> makes communication less ambiguous.  Following some process (or changing >> the process) can feel a bit heavy for long-timers, but I think it makes >> things much clearer for newcomers. >> >> Assuming we will go through with this proposal, it will need to be >> documented on the wiki so we can easily refer people to the procedure. >> Probably the ContributionChecklist page? >> >>    https://sourceware.org/gdb/wiki/ContributionChecklist >> >> Will you be able to take care of this when needed (do you have write >> access to the wiki)? > > Hi Simon, > > Thanks for the reply! I don't have write access to the wiki (In fact, I just created my account on it), can you give me the necessary permissions, or do I need to ask someone else? (in case it is the latter, who?) Done. Simon