From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 547563858D34 for ; Thu, 2 Jul 2020 12:23:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 547563858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 399321E5F9; Thu, 2 Jul 2020 08:23:50 -0400 (EDT) Subject: Re: Building GDB with GCC 10 (-fno-common by default) To: Sebastian Huber , gdb@sourceware.org References: From: Simon Marchi Message-ID: Date: Thu, 2 Jul 2020 08:23:49 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, BODY_8BITS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jul 2020 12:23:52 -0000 On 2020-07-01 5:29 a.m., Sebastian Huber wrote: > Hello, > > could this build error of the powerpc-rtems target be an issue with the > new -fno-common default of GCC 10? > > make[3]: Entering directory > '/scratch/git-rtems-source-builder/rtems/build/powerpc-rtems6-gdb-4e394b2-x86_64-linux-gnu-1/build/sim/ppc' > gcc -O2 -g -pipe > -I/scratch/git-rtems-source-builder/rtems/build/tmp/sb-10000/6/rtems-powerpc/build/rtems/6/include > -g -O2 -I. -I../../../sourceware-mirror-binutils-gdb-4e394b2/sim/ppc > -I../../../sourceware-mirror-binutils-gdb-4e394b2/sim/ppc/../../include > -I../../bfd > -I../../../sourceware-mirror-binutils-gdb-4e394b2/sim/ppc/../../bfd > -I../../gdb > -I../../../sourceware-mirror-binutils-gdb-4e394b2/sim/ppc/../../gdb > -I../../../sourceware-mirror-binutils-gdb-4e394b2/sim/ppc/../../gdb/config > -o igen igen.o table.o lf.o misc.o filter_host.o ld-decode.o ld-cache.o > filter.o ld-insn.o gen-model.o gen-itable.o gen-icache.o gen-semantics.o > gen-idecode.o gen-support.o > /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: > ld-insn.o:/scratch/git-rtems-source-builder/rtems/build/powerpc-rtems6-gdb-4e394b2-x86_64-linux-gnu-1/build/sim/ppc/../../../sourceware-mirror-binutils-gdb-4e394b2/sim/ppc/ld-insn.h:221: > multiple definition of `max_model_fields_len'; > igen.o:/scratch/git-rtems-source-builder/rtems/build/powerpc-rtems6-gdb-4e394b2-x86_64-linux-gnu-1/build/sim/ppc/../../../sourceware-mirror-binutils-gdb-4e394b2/sim/ppc/ld-insn.h:221: > first defined here > > We have: > > sim/ppc/ld-insn.h:int max_model_fields_len; > sim/ppc/ld-insn.c:  if (max_model_fields_len < len) > sim/ppc/ld-insn.c:    max_model_fields_len = len; > sim/ppc/ld-insn.c:    if (max_model_fields_len < len) > sim/ppc/ld-insn.c:      max_model_fields_len = len; > sim/ppc/gen-model.c:            max_model_fields_len, > sim/ppc/gen-model.c:        max_model_fields_len, > > Missing extern in ld-insn.h and no definition in a source file? Indeed, the .h should have an extern declaration, and there should be one definition to allocate the storage, probably in ld-insn.c. If that fixes the issue, would you mind sending a patch? Thanks, Simon