From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 721BC3857BBE for ; Tue, 27 Sep 2022 17:11:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 721BC3857BBE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4McR3x0hlDz3vlW; Tue, 27 Sep 2022 17:11:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4McR3w74hpz3tdl; Tue, 27 Sep 2022 17:11:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664298685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y4xeKIrmATAePwcH3zLuORpIr2a7AnJB3Qe70RKYLrY=; b=wQ0ZXr/YkKMnayJBlykMDRJa1cM1NLYgHck0/DLgPH+u0WwNV2h06oAfil5eg4rFB2e3sV FVll9E1nU6vq8FSMYgn7oHpLa/nKt9oL7FWz22CUSI2XDLPCBnrPSLqQ34jjo93gEb4VyY i5MZxTeVPbycy3ANTLH437QfvLrdFlR1CXGp1mVgo/kO4kfVhxWBHdMFyi2upgNo5nlRkG EdjaOuer3SLuU8l5UudLukGdy5txJud6YT1DNgk5D3mrnYNo05f2u6ZLCu/IAlV4z9YtP4 onQilmEbZBiW6hvojGLYdsaMoY+0h/MgS50q7goEn3lxMW7JMw7H6RWwZ/AF8w== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4McR3w3SfyznKx; Tue, 27 Sep 2022 17:11:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 27 Sep 2022 10:11:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: Proposal: Add review tags to patch review workflow. Content-Language: en-US To: Bruno Larsen , Simon Marchi , gdb@sourceware.org References: <453759b1-1ddf-1aff-a033-6183b84a4a4d@simark.ca> <4c321d90-ca45-c3dd-27dc-cc8c74b6e999@FreeBSD.org> <5bc9205b-65ea-4436-e9d7-2e9f70147d5d@redhat.com> <8b2913f0-fd8c-5b48-cab3-f87b581171e1@simark.ca> <65be7ed9-7e0e-fd85-96ed-28bfaa442bca@redhat.com> From: John Baldwin In-Reply-To: <65be7ed9-7e0e-fd85-96ed-28bfaa442bca@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664298685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y4xeKIrmATAePwcH3zLuORpIr2a7AnJB3Qe70RKYLrY=; b=XGq7glPgvqqO9y3Y5VVbMxfi+IcKHiz0fsAg8uLJ3BVtgzHXHHOyuJQBCsOyUgeO19E/TZ JgycFWNlZVaUgDMBz6TvXc2Bji9xaK4fuIsZVBMpV50Drdd/OklAbCdag1qsM8vls65yHa JMJpsk3T0Ndsv6oZHUYBIZyfN/3dEE6mkKhaEViffQiXPxAQhvsemcusrMJtIMLJIMBt0R akZfU2eSD5WpEJM0W8yRxuW8wmYVUsnlZ3O6KZp8liT3Se9sybdOYSnwvkSqJtLZjMv7Q1 I3OhyWne0fcFMdJ6A270ZgF9/EqVvR5R7HXzK3HwP6YDgnsc6rYeZybczNyPgA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1664298685; a=rsa-sha256; cv=none; b=kd/aIB6omBorEJup5RqyCU23qAMUNGB2XHG/Poq3+OmfSBIxNbHIsbf3A+kk4Ge+Yz92P8 1riOYcomvTPiZh2ziuUQ22HuI2C9v4QMk8FIb07MyokDfSN411U331VI1ET8DwYqZNxQUv wqIq+x+14gkaB55TQ5nlfeW1Nz+PbnS04OaQYxAcK3hu/p+19yWJ0rJ25knbbgN06z78zb eWE+mJc1+7njx2kp4e++5CHioZxudS3ixR3pfm+HRolHYxAyeWT4Y5YtixQVvewSBI7dRw ewsx/k8Xdbbzc/qYU8xu17bNH/6cOQBcDk0IL6WEIA2eQcfK/PZSKYKeKITAmw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/27/22 5:03 AM, Bruno Larsen wrote: > On 27/09/2022 14:02, Simon Marchi wrote: >> >>>> It also wasn't clear to me if the intention was for the commits to >>>> be amended with the annotations?  (I don't think it was explicitly >>>> stated in the original mail, and I'm not sure if it was an implicit >>>> assumption?) >>> No, I didn't intend on amending previous commits. The main problem this change intends to solve is fixing ambiguity, and the pushed patches don't have that issue anymore. Thanking a reviewer is just one more positive side (IMHO) going forward. >> Err, just to be clear, we won't amend existing commits in master >> obviously (can't rewrite history) but future commits in master would >> contain those tags. This means that if you give me a Reviewed-By, I >> amend my local commit patch to include that trailer before pushing. > Yes, thank you for clarifying what I meant! Yes, my question was about amending the in-progress commits before pushing, not existing history. If we weren't amending commits then you could perhaps omit the e-mail address (it's implicit from the From), but the full tag is better to copy/paste into a commit log or git commit --trailer -- John Baldwin