From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id D257B386F454; Mon, 1 Jun 2020 07:39:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D257B386F454 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6FAA1AD5D; Mon, 1 Jun 2020 07:39:11 +0000 (UTC) Subject: Re: Auto update ChangeLog for binutils+gdb commits? To: Eli Zaretskii , Tom Tromey Cc: simark@simark.ca, hjl.tools@gmail.com, binutils@sourceware.org, gdb@sourceware.org References: <891ef86a-a47f-18f2-c6bd-e525719e3768@simark.ca> <9492d857-c259-1429-f1c7-31a6dbf6510f@simark.ca> <1fb47dab-7a52-524b-17a3-672122277a48@suse.cz> <87tuzzaqey.fsf@tromey.com> <83tuzyn8sd.fsf@gnu.org> <87367hrzua.fsf@tromey.com> <83h7vxkygu.fsf@gnu.org> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: Date: Mon, 1 Jun 2020 09:39:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <83h7vxkygu.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2020 07:39:12 -0000 On 5/30/20 9:35 PM, Eli Zaretskii wrote: >> From: Tom Tromey >> Cc: Tom Tromey , mliska@suse.cz, simark@simark.ca, >> hjl.tools@gmail.com, binutils@sourceware.org, gdb@sourceware.org >> Date: Sat, 30 May 2020 13:23:57 -0600 >> >> Eli> Having the names of the functions in the log is one of the most >> Eli> important reasons for following the ChangeLog format. If it were not >> Eli> for that reason, we could let people write free-text log messages, >> Eli> because file names are easily gleaned from the VCS log. >> >> If the mklog script works, then the function names are also easily >> computed from the diff. > > If all the script does is look at the hunk headers of the diffs, then > indeed such a script doesn't have any added value. I thought it did a > more thorough (and thus more accurate) job than that. > It does, it tries to find a function name, macro, struct in a diff hunk and this name is taken as changed. If nothing like this is found, then diff header name is used. Martin