From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50056.outbound.protection.outlook.com [40.107.5.56]) by sourceware.org (Postfix) with ESMTPS id 48A073858400; Wed, 3 Aug 2022 11:36:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 48A073858400 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=fOXS5Yxt1aFx9+l1xjNVS1bG4azRKOJtRgMSf2LTp+KiTZBk39eU4NfXLUt6RbSAZp/LYR5KNnxGI0OYmag5nqfR+KvU7NoWgSiaSUyNKO2wblEvpcCBUKEJ8yVfG/tUCRDFdeDyagPiSzXt2ACfqgzhd1ObBd6lVCHsqKklAFpDQxKOBEk9zE1mBMSY7GzYkwAnuzND+9jLI42/eMLhZvOEeZUyVidfkf5BmE2YZBq4vFS14j3nd2ac9ZFd5nSw8uq9wh7LaeGAp1d+FKXNfQs9EjKxkWBuhuMhFLUZGtWxQiYFfSB29su0gQzxdS5+M0T8KT5x23Vn0p2MMJVjBw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WqdAqBs4TOmTS2SoK9NoqABLYgRx/VtBWOSPp64ugRg=; b=W/14csGXDrq8mWrwFqVJYu14EG6ZoxXvFUAk5PFMNW7ZhNM7oTHqDDYzTIlEYUwRhZO6AAZtO7SZmUbYbciNArjfuwR8TDGk1u6nGC+ozp8qsrRy0wWKjMXAY5g6N4pnp/FEEaWlwPUT1RtuTuGp3aJcPHfop/MYSwrWzEW3ERD2GB8Q4eYTz1U3+g8b/CaeC8UO219lMUT3N+BJm75JGE23vc/ysbuyVzq0R1nzHXd46n5CxzaEklBD+GYbPrGHpd6OHnEj/GbFI3PVZoysWelfza6GDi2+G2EB4P54Z+FOlhvOepUs+3l275ywGa9VuBztFCJpjVhH7YJIxzUdGQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS8P251CA0007.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::7) by DB6PR0801MB2037.eurprd08.prod.outlook.com (2603:10a6:4:74::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12; Wed, 3 Aug 2022 11:35:53 +0000 Received: from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::ba) by AS8P251CA0007.outlook.office365.com (2603:10a6:20b:2f2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14 via Frontend Transport; Wed, 3 Aug 2022 11:35:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Wed, 3 Aug 2022 11:35:53 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Wed, 03 Aug 2022 11:35:53 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 46539ae4b87da12d X-CR-MTA-TID: 64aa7808 Received: from 2b5d7fd37c52.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9290871A-B352-42A1-8E3E-FB2F6FC66496.1; Wed, 03 Aug 2022 11:35:46 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2b5d7fd37c52.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 03 Aug 2022 11:35:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iBClGnRBNMLf35m/Jr0ZUdDUneJbcG9pgotjfjDvD488Gl3JNYhLPUksFqovtjVsF2fhHopwhxIZa2PTufQ8mbtAtLSKJLFP6XeW/gTQ6VOPk5mL1G7p3WoNwpyQcSPUazuWGNbICxW5wy9YYP577Twm8vlNc5rs7LiaoXXTbIQxMQRqVxiuatANCo9fuxo+2+iiO+wuV+Sq2Oye05IBQNVy3rsIJKnudSAT+NuaOnHW2Bbob2UvMuraDibQxIoc7GVTbe07qy1Si7Awm3oBxJaThpQKkx2N0/v2Ajp5oq5rMK+Nr4tLaGJbJnK45HAPnRiw062iieb6VWLtt51rxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WqdAqBs4TOmTS2SoK9NoqABLYgRx/VtBWOSPp64ugRg=; b=RO1S7P0G7nreOmcP432F+lb+rpp05kk+MX6qzv0QielTi8791ZuBK1frn1bajrZRQvA3glCooMjnZh4kTWFErzgmrWJrfrGYrkp+I8l453LGzcwa7OJrAO9D3uu0IbC7eTyBfHHpcwF9FdWeVW/yFg/jyKgBEFCWfVLc+irWmY3h+5YwwXvTT+7o4Kr8W+t6wJpOHBkoh5RX8Iz6b9oahJxUtj7Zt9IKIwKbf/45InUhQu7PYmQNkHEykfrWhs+B9Nk1trraU7ye/QNqtTUjm3pvK8lREKHakcUdKKTZT3s2R8ETPGaaqZFXd32TaM/k06ZAor2boVW4SN3qByziRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by PAXPR08MB7122.eurprd08.prod.outlook.com (2603:10a6:102:205::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Wed, 3 Aug 2022 11:35:44 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8%4]) with mapi id 15.20.5504.014; Wed, 3 Aug 2022 11:35:44 +0000 Message-ID: Date: Wed, 3 Aug 2022 12:35:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: buildbot vs --enable-targets=all Content-Language: en-US To: Mark Wielaard , noloader@gmail.com Cc: Gdb , Binutils References: <94d446556e470859b878bb27eec5e2a52d063673.camel@klomp.org> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0618.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::20) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8d7c2804-bcc1-4872-7daf-08da754452e4 X-MS-TrafficTypeDiagnostic: PAXPR08MB7122:EE_|VE1EUR03FT042:EE_|DB6PR0801MB2037:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +hUW9lPR+AL9F6q3PuzrlM4Cl+ZCifGS/W9pMLDgvJSUBPTM7l7ItOYbdxG2REj+fulkbi+COj4NSvqpSkeTXiFT0nJOjj3J8BYmnfHZ673xOg2LfCgT/CL+igFXnr8nv1sdpXwLXxldrQk+kns5rR7nvgFw6zf/TYzstn29WE296gaCIwYLtPYI4GZH/ZxG1Mv0a4jjQMiPOeVizg+ANPdoAyDhT080MMJC/OJ3zUtBWFej2bVTbLqVTR6PIrvBXUSwaVSLHBng/Xx0uDSEJb5bUJmOO77VA5DvFLJ7up0CCs812huyw+o462NYk9jJ1fyFherKNX1cMWhODdwJ0rZtrBN2f0nYM1g+Jbjk+8ni5tBlCGMlj8Ok1gi3G0ECYJd+jUd6g3mF5NmJJ77vczy6XTbmtLW1ml1KLuhIixndl4pPPRsvi9pL+AcJ1T+3ayyuSnYkl894OCj0OHdyYmXjE9DW5FU+Xv/nFYD6lvfxyN/sKuKYx5LvLTttJhvhTtSwvKulAcju2nk9zfhibCoVdbIZNc8h/ArdzGxq5qvbD8VM2gCHMNrYtloCWm1n1hoGD9sbDL3UmOlo6xlC3GMevn3Omtp+MNWlsEgu5AdHgfAIygxuBcGKMh+wfELT5m+XRC9jkZPrRevSH2v7Ao3e1c53eE86qH+So3v6jujdmGcUCUrN1sVrR1aaKiM1U6/DmeBrZ5GOXevuPekL2Ed9XjfUvdNRZbItIsq0+f0KAKxw/tjIqW1tIlF4WjS4+djtc7t3iuTzA+V5ztDrp/hNZ0U9pFgNr75ywGxbgrb9qxT8RkaAb6sAH1A/IkH4tJLzUbTU9NXBsqo2Pc4cJWXilSK0B1qoiSx/hq6FU8quetQYFItanjU1Gqx1G7uu X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(396003)(376002)(366004)(136003)(39860400002)(346002)(66476007)(316002)(54906003)(66946007)(38100700002)(4326008)(8676002)(5660300002)(44832011)(66556008)(41300700001)(8936002)(2906002)(966005)(83380400001)(86362001)(186003)(36756003)(478600001)(31686004)(6512007)(26005)(31696002)(53546011)(2616005)(6506007)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7122 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 720a7f1f-2e48-4b77-e149-08da75444d54 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VnHDQJ1hHPOH+0kuqCWg+rSXwFSONqN9CymQ0b+ar7FRoE6/v947pgSrxMTSBlvEv4TEXcSbycUEwKFa9OVM/KpbxvVyHBGRmZzXTNy6//bN952gUJtA2ZJnLmdgbIsgPgKvKmUZFceUNGDlf9LuSUKrxYwPGczwQgqPpmyz0vNyz1wEKXYQPVrvd1vJZbuVj/Bf3o7z65nrhAqmipPKDXD98bbKQLXJxsuGmH3orJQh8YtrRH0AKH+Sqh8oaQpdWZtEnwTUMY/VR5Gyjf4DL+pcLNPKbxh1Vx0lPFvcBuaXykxn7w2embNTvpt/ZzvDbd0ZyP6QKiZsraOyzubv7yXgy5zUTgEJjbNuG1/Uf4mfo1ANGt1kfajQTxDq2U6GKsrRIEA1GHTalzdu0JTMwPLL2O+lc39aRLUVqM2CKPmw0JlaCVb3ou26ex2GYKG+ehifotgEmM3Ullkck17AGRC59HZVrqFHd7lVPKQTe8txPpz1OcViyASgjm/iiangs6ZiBub2AAIRvFiEu4H1kvJC2T3Ck3tvauM37RZv3wHbnEuiJjl1dqJ8aIrSEansNrMcf0RMHmEE5dbQCqXdTnopHQhOg6+aBYL80hfBipCviFl+Wr0ueByno4yKT1shrOPm7NrlwXoijnB+tc9XIru/g46mo7S6tBUhhrFBA82MKm3FI4sLn3yCQMYvQLXr3xmzw/7Yu7nsEaPBxrKYICuYUDV5/Bb7/pjI6q9Z2781ORwkdjNnQPIijyo2Bw8s3mJnJDf9ZtLP5oA8fjlR9ayBVJbCDcjDIioYBWWaVvcNAZgGhSbX9kmCxK3Lp32ACkuFj2/sp5fAfVTRzLSJX6/HmP2pOkKTCuBgM3GHPz6dMqLjxUkNVhmvpw5CtnWH X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(136003)(396003)(376002)(39860400002)(346002)(40470700004)(36840700001)(46966006)(8676002)(83380400001)(4326008)(450100002)(186003)(36860700001)(2616005)(31686004)(36756003)(8936002)(70206006)(70586007)(5660300002)(44832011)(2906002)(478600001)(966005)(6486002)(53546011)(82310400005)(40480700001)(316002)(6512007)(54906003)(41300700001)(26005)(86362001)(6506007)(31696002)(356005)(40460700003)(47076005)(336012)(82740400003)(81166007)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2022 11:35:53.3716 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d7c2804-bcc1-4872-7daf-08da754452e4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2037 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2022 11:36:05 -0000 On 8/3/22 11:38, Mark Wielaard wrote: > Hi Jeffrey, > > On Mon, 2022-07-25 at 21:59 -0400, Jeffrey Walton wrote: >> On Mon, Jul 25, 2022 at 8:26 AM Mark Wielaard wrote: >>> On fedora-s390x and debian-ppc64 one of the gdb selftests fails >>> https://builder.sourceware.org/buildbot/#builders/75/builds/783 >>> https://builder.sourceware.org/buildbot/#builders/76/builds/772 >>> >>> Running selftest arm-record. >>> Process record and replay target doesn't support syscall number >>> -2036195 >>> Process record does not support instruction 0x7f70ee1d at address 0x0. >>> Self test failed: self-test failed at ../../binutils-gdb/gdb/arm- >>> tdep.c:14407 >>> >>> Which is: >>> >>> /* 32-bit Thumb-2 instructions. */ >>> { >>> arm_insn_decode_record arm_record; >>> >>> memset (&arm_record, 0, sizeof (arm_insn_decode_record)); >>> arm_record.gdbarch = gdbarch; >>> >>> static const uint16_t insns[] = { >>> /* 1d ee 70 7f mrc 15, 0, r7, cr13, cr0, {3} */ >>> 0xee1d, 0x7f70, >>> }; >>> >>> enum bfd_endian endian = gdbarch_byte_order_for_code (arm_record.gdbarch); >>> instruction_reader_thumb reader (endian, insns); >>> int ret = decode_insn (reader, &arm_record, THUMB2_RECORD, >>> THUMB2_INSN_SIZE_BYTES); >>> >>> SELF_CHECK (ret == 0); >>> SELF_CHECK (arm_record.mem_rec_count == 0); >>> SELF_CHECK (arm_record.reg_rec_count == 1); >>> SELF_CHECK (arm_record.arm_regs[0] == 7); >>> } >>> >>> This seems a big endian issue given the instructions are given as two >>> 16bit numbers. >> [...] > >>> For ARM, this does not look right (to me): >> >>> static const uint16_t insns[] = { >>> /* 1d ee 70 7f mrc 15, 0, r7, cr13, cr0, {3} */ >>> 0xee1d, 0x7f70, >>> }; >> >> I think you are supposed to use .inst.n and .inst.w because they >> handle endianness properly. > > I couldn't figure out how to do that. Could you give an example? > It looks like the instruction_reader_thumb only takes an array of > uint16_t (even though the instructions are 32bit long). But I might be > looking at the wrong code. > > So the following fixes it for me on s390x and ppc64 > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index d4c5beb5e06..ef0da73398d 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -14471,7 +14471,7 @@ arm_record_test (void) > > static const uint16_t insns[] = { > /* 1d ee 70 7f mrc 15, 0, r7, cr13, cr0, {3} */ > - 0xee1d, 0x7f70, > + 0x7f70, 0xee1d, > }; > > enum bfd_endian endian = gdbarch_byte_order_for_code (arm_record.gdbarch); > > But obviously that breaks things on little-endian architectures. > We could define the insns[] differently using > > #if _BYTE_ORDER == _LITTLE_ENDIAN > 0xee1d, 0x7f70, > #else > 0x7f70, 0xee1d, > #endif > > But that might not be what you meant. > > Thanks, > > Mark I wonder what's going wrong here given we're using gdbarch_byte_order_for_code to read things. Technically it should read in the right order.