From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A5DBF3858D37 for ; Thu, 9 Mar 2023 02:15:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A5DBF3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 22AA91E110; Wed, 8 Mar 2023 21:15:52 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1678328152; bh=QWtYJ64hLDw1hok2yyRR+Mj0brcUTjJ70s7BZbZ3Zk4=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Nn5BJOyCM9Nb4cJ5OQcGy2KAoPR8g7EoJuuOOUL8TJLTb9PJ5yWKoEfS459k3CbC/ Pyj0HeLYx+xkyk3Q4jyDr+Bou5Lzc60FyMdJHlWNjk2f4y2oaNNHIw4XF8wHqKT5fJ QW7PWYiGOvshIPn++qAgUUkJpInCZ9VT0eheGI3c= Message-ID: Date: Wed, 8 Mar 2023 21:15:51 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: GDB 13.1 and clang Content-Language: en-US To: John Baldwin , Chris Johns , gdb@sourceware.org References: <70b50c1d-29bf-2c5c-2dbb-c2ed7dc55ab2@FreeBSD.org> From: Simon Marchi In-Reply-To: <70b50c1d-29bf-2c5c-2dbb-c2ed7dc55ab2@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/8/23 17:53, John Baldwin wrote: > On 3/8/23 1:22 PM, Chris Johns wrote: >> On 9/3/2023 5:22 am, Simon Marchi wrote: >>> On 3/8/23 15:07, Chris Johns wrote: >>>> Hi, >>>> >>>> I have just tried to build the latest RTEMS tools and we now use gdb 13.1. I am >>>> seeing a build failure on FreeBSD 13.1 of: >>>> >>>> In file included from ../../gdb-13.1/gdb/xml-tdesc.c:23: >>>> In file included from ../../gdb-13.1/gdb/target.h:42: >>>> In file included from ../../gdb-13.1/gdb/infrun.h:21: >>>> In file included from ../../gdb-13.1/gdb/gdbthread.h:26: >>>> In file included from ../../gdb-13.1/gdb/breakpoint.h:38: >>>> ../../gdb-13.1/gdb/target/waitstatus.h:113:1: error: use of undeclared >>>> identifier 'DIAGNOSTIC_ERROR_SWITCH' >>>> DIAGNOSTIC_ERROR_SWITCH >>>> ^ >>>> >>>> I only have clang installed on the FreeBSD machine. >>>> >>>> A quick review of include/diagnostics.h seems to show support for >>>> DIAGNOSTIC_ERROR_SWITCH only in the gcc area? >>> >>> Hmm, I see it in the clang section: >>> >>> # define DIAGNOSTIC_ERROR_SWITCH \ >>> DIAGNOSTIC_ERROR ("-Wswitch") >>> >> >> It seems I need to do a better review before posting :) >> >>> https://sourceware.org/cgit/binutils-gdb/tree/include/diagnostics.h?h=gdb-13.1-release&id=4f3e26ac6ee31f7bc4b04abd8bdb944e7f1fc5d2#n76 >>> >>> Unless there's a typo I don't see. >>> >>> diagnostics.h is included at the top of waitstatus.h. Is it possible >>> that another unrelated diagnostics.h gets included on FreeBSD? You >>> could inspect the preprocessed file to see what the preprocessor >>> included for diagnostics.h. >> >> There is another version installed here: >> >> $ pkg which /usr/local/include/diagnostics.h >> /usr/local/include/diagnostics.h was installed by package binutils-2.37_2,1 >> >> We have /usr/local/include early in the include list on FreeBSD to pick up some >> of the required libraries installed as packages. I will check for a package >> update or I revisit the build flags to see how it can be handled. >> >> Thank you for the prompt and helpful responses. > > Yes, I manually delete all the headers installed by binutils into > /usr/local/include when building GDB from source locally to work > around this. :( I'm not sure of the best fix for this. I tracked > it down to the change to add zstd as ZSTD_CFLAGS is before BFD_CFLAGS > in INTERNAL_CFLAGS_BASE in Makefile.in in this commit: > > commit 2cac01e3ffff74898c54fa5e6418817f5578adb6 > Author: Fangrui Song > Date: Mon Sep 26 19:50:13 2022 -0700 > > binutils, gdb: support zstd compressed debug sections > PR29397 PR29563: Add new configure option --with-zstd which defaults to > auto. If pkgconfig/libzstd.pc is found, define HAVE_ZSTD and support > zstd compressed debug sections for most tools. > * bfd: for addr2line, objdump --dwarf, gdb, etc > * gas: support --compress-debug-sections=zstd > * ld: support ELFCOMPRESS_ZSTD input and --compress-debug-sections=zstd > * objcopy: support ELFCOMPRESS_ZSTD input for > --decompress-debug-sections and --compress-debug-sections=zstd > * gdb: support ELFCOMPRESS_ZSTD input. The bfd change references zstd > symbols, so gdb has to link against -lzstd in this patch. > If zstd is not supported, ELFCOMPRESS_ZSTD input triggers an error. We > can avoid HAVE_ZSTD if binutils-gdb imports zstd/ like zlib/, but this > is too heavyweight, so don't do it for now. > ``` > % ld/ld-new a.o > ld/ld-new: a.o: section .debug_abbrev is compressed with zstd, but BFD is not built with zstd support > ... > % ld/ld-new a.o --compress-debug-sections=zstd > ld/ld-new: --compress-debug-sections=zstd: ld is not built with zstd support > % binutils/objcopy --compress-debug-sections=zstd a.o b.o > binutils/objcopy: --compress-debug-sections=zstd: binutils is not built with zstd support > % binutils/objcopy b.o --decompress-debug-sections > binutils/objcopy: zstd.o: section .debug_abbrev is compressed with zstd, but BFD is not built with zstd support > ... > ``` > > I have not tried moving ZSTD_CFLAGS after BFD_CFLAGS, but if it worked I > think the right solution is to ensure all the "local" includes for things > in git come first before any includes that pull from the installed system. > I think this would mean moving READLINE_CFLAGS (for systems that use a > system readline), ZLIBINC, and ZSTD_CFLAGS after INCLUDE_CFLAGS. > > I just tried this and it worked for me locally: > > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > index 6e39383eb93..40497541880 100644 > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -629,8 +629,8 @@ INTERNAL_CPPFLAGS = $(CPPFLAGS) @GUILE_CPPFLAGS@ @PYTHON_CPPFLAGS@ \ > # INTERNAL_CFLAGS is the aggregate of all other *CFLAGS macros. > INTERNAL_CFLAGS_BASE = \ > $(GLOBAL_CFLAGS) $(PROFILE_CFLAGS) \ > - $(GDB_CFLAGS) $(OPCODES_CFLAGS) $(READLINE_CFLAGS) $(ZLIBINC) \ > - $(ZSTD_CFLAGS) $(BFD_CFLAGS) $(INCLUDE_CFLAGS) $(LIBDECNUMBER_CFLAGS) \ > + $(GDB_CFLAGS) $(OPCODES_CFLAGS) $(BFD_CFLAGS) $(INCLUDE_CFLAGS) \ > + $(READLINE_CFLAGS) $(ZLIBINC) $(ZSTD_CFLAGS) $(LIBDECNUMBER_CFLAGS) \ > $(INTL_CFLAGS) $(INCGNU) $(INCSUPPORT) $(LIBBACKTRACE_INC) \ > $(ENABLE_CFLAGS) $(INTERNAL_CPPFLAGS) $(SRCHIGH_CFLAGS) \ > $(TOP_CFLAGS) $(PTHREAD_CFLAGS) $(DEBUGINFOD_CFLAGS) $(GMPINC) \ If it works, I'd be fine with that patch. We'll need a PR number for the patch to make it to the 13 branch though. Simon