From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2079.outbound.protection.outlook.com [40.107.7.79]) by sourceware.org (Postfix) with ESMTPS id A6521383FBAE for ; Mon, 13 Feb 2023 14:43:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A6521383FBAE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4geS0/BTIQ8X5kJ03Qz9cz1tD8BKRbG/aB0j6x2acT4=; b=YB05+bNjS/LhoUBwoJEQfhBv7U9FdlNApzBT/oytbAJ4mCplfeUKcC+guTLzriB+On2qMQGIrsVfQ425CZOIRmHSErVQ5ETEVQBDjmIqbJHgNcQc+nBf3lyoHJgNoB6cyPixB7uUTI9IrFtOX6MXfo9HPQFqh7MiZd7pquCxWow= Received: from DUZPR01CA0009.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c3::16) by PAWPR08MB9121.eurprd08.prod.outlook.com (2603:10a6:102:330::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 14:43:10 +0000 Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3c3:cafe::63) by DUZPR01CA0009.outlook.office365.com (2603:10a6:10:3c3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 14:43:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 14:43:10 +0000 Received: ("Tessian outbound b1d3ffe56e73:v132"); Mon, 13 Feb 2023 14:43:09 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: df817c022594ccb0 X-CR-MTA-TID: 64aa7808 Received: from 020261f8c3db.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E2DF23DA-4130-42DC-8D7A-6161313CBD58.1; Mon, 13 Feb 2023 14:43:02 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 020261f8c3db.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 13 Feb 2023 14:43:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nm0Pzo8gIIJt5t0zKHQzhi4j9kZksH3FiBjgnxHZU7aGwfsGY+V5DAD9XNQEoV3Y9bTCEL7jcTCB+lyijLGpr8T5vDwVnkzfbYvR4SFIiNnTssWyzYprD9KL3VJBgbL1AECj6HOeEuNV0RlYvHH3XbJpQllELZcrE2nvStoMwx8SCpRflBbdw/uX+x3wzsm0lrWDOcaMV2+BGxKpJcyP8zSaFfts9pNh+CMth6Z3SZKm6AkMkorQSbmxfqgJQ+SLJ2mfApgqoctM/jS6ZjsqMeqtfOZ6R89vrkhwd4cWsR1DmAoeXZaHU7vDQ7j4hJMHKxzD0/sv76c2qFpdaLFUaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4geS0/BTIQ8X5kJ03Qz9cz1tD8BKRbG/aB0j6x2acT4=; b=MSvvpbQ/I3m4l06XdYCJhKtJ/EkrG0MSnmsGMM+9e/BF5FeGfXtTAT9IOMdJJpnrcxPO2LTEyaiIhMyPKp18o7m9JwFmPeJC8DoE73cTZxODEsdVf5m9O7GRTAwZhUxNJMzqvz5vXAx1vFh1tZtezDmtLUkWhEQoJKYRqgEB7WS+hMQyO3qkk+2bKTJzlQqpyKqH9VSau7biKxemnlQQu9b+p8tvUCFHixaYZ4awc85n/ZJdumQRhaIneZ68SdX0uMc/d+Kqc0kqo/LBju69S1PHfvmWonWnBN1Ra6PxU2HtbsGe1gkhjhhiJRzi8VkuJ84z1avtsCNZTVR4VmxJ4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4geS0/BTIQ8X5kJ03Qz9cz1tD8BKRbG/aB0j6x2acT4=; b=YB05+bNjS/LhoUBwoJEQfhBv7U9FdlNApzBT/oytbAJ4mCplfeUKcC+guTLzriB+On2qMQGIrsVfQ425CZOIRmHSErVQ5ETEVQBDjmIqbJHgNcQc+nBf3lyoHJgNoB6cyPixB7uUTI9IrFtOX6MXfo9HPQFqh7MiZd7pquCxWow= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB6357.eurprd08.prod.outlook.com (2603:10a6:20b:31b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 14:42:52 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6%4]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 14:42:52 +0000 Message-ID: Date: Mon, 13 Feb 2023 14:42:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: Any concrete plans after the GDB BoF? Content-Language: en-US To: Tom Tromey , Luis Machado via Gdb Cc: Andrew Burgess , Mark Wielaard , Simon Marchi , Joel Brobecker References: <83485199-965e-7ff5-1dc8-d027b74b56f7@arm.com> <5924814b-2e53-da09-6125-48ac5a5296e7@simark.ca> <87mt5kunum.fsf@redhat.com> <20230212124345.GH2430@gnu.wildebeest.org> <87r0utu6ew.fsf@redhat.com> <65409b73-fc6d-9a89-3541-31eb1a0b0791@arm.com> <87wn4lve1b.fsf@tromey.com> From: Luis Machado In-Reply-To: <87wn4lve1b.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP123CA0008.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::20) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB6357:EE_|DBAEUR03FT018:EE_|PAWPR08MB9121:EE_ X-MS-Office365-Filtering-Correlation-Id: e8af2f2f-fcb3-4573-d12e-08db0dd0a083 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xewv7CrX+PCZahUQi3vAVu1e7we+iULDD96NZd1xJkwe8vSL2elzEHIMvjgMcToEt9lZrNOWjKBVD/lY1Xt7QuNvfZCw/mdETlQeD02OvFzeWmrOsUZuxyG57c4V1JM+TGpGcTWFltksyBIXobVw9PqXYq9nYncj+aJVlhLUeBIHN1mhb8wCt5lPkMBmo9zI4OFKMlx3i7o1zd1WN/hCgxgPJ9nUIqkUOfGy1p0L3yXMTIF9SFGUFrme/iSm8YybLc2bvCMboWBt3MCLjLc434x6A+OCIoD608fUczL8PxhRbe1b18hHX+iOVzHifj73OKm6YAOWvAlomcl5iVj2QSrP8qUfSh4Nb1PImxdxOpIWDFl9hxNpcWS3vQv+HIzvAX9/OXJkhjHU7qGsccNKe35MYgzOeKbMkB8+xXHqgBgd3YRCabD7RCO8gsFZvKvAzKGFoSjS0ez4f9kWkWahS1j9BJKRheoAcUbdrTDVSE+PhJBDhUe1bQEQojXlLmcqsKRPGJ6rxkkC1r6PdKX/CkQfVD/bk5FdDmZH1Q+06UTfs5z+HKqNjSWDzLdtFOpy20+9Cp9dPpp523aoV8dWDpG0bWdw+5E6r/Oy4zQfkqnjOjyt8cbc14fg9wEhmdgqyGGAGIHK6ReKREfSxAN0DObXNlcj83kFMQKmm2q1+bCb8k43ygILs54LyaAm7uB4i3HpjPRhUUAwoSHwgG3y5VcR710gVDPB2c7Munuld3g= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(366004)(39860400002)(376002)(346002)(451199018)(36756003)(44832011)(2906002)(5660300002)(6512007)(31696002)(83380400001)(26005)(186003)(2616005)(66946007)(38100700002)(4326008)(8676002)(54906003)(316002)(66556008)(8936002)(66476007)(41300700001)(478600001)(53546011)(86362001)(110136005)(6506007)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6357 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 72559f8b-9021-4fb6-a821-08db0dd095a7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /NvnrTehZsv7j+MogBncE1PRCPdp/b1C1yEigeQEEMY4DanOAWotw7ofGJ9B4e3OST72a+BAH6RDnyxRqDepR1TWeVAbUO/goiVVQnVwszepRBcuNZBaYIDuVgMpB5xstHZS9kH8yPf4mBg4c68bbXey2IG5IzyH+M8pGFH2ucLjmCR5I+zrrO7iWcnjDB2/vLUTHcSY05yOS1L0fR4qcoXzT7TN0niBvSgqHzSt6cz8481nuDB1wltuu175dk3vUiS6qtEfPJ6VtyclleeVjyAVlXvsqTtUoRpiA3HMVWHK67UQa6CLVeM/Cd0v83msxlsx/4l0gFc+jMlyv5RSrq6BsXsRM5pUrJXJBk+nAd2qmxoT8bZ3zg+3htcMmaUcISi5vOd6yeslqdrFuVbJhAo+hLKnhCPR5btyeKQZg9hXkuEtcap8PD1B59Zx7oBc7s36PS4ohA+G3wVf3mzRNuBsAG50NLR7xpmaBMzbs7vTVgH+DwU1tl9Wdmt9BVwEn1V5pmVTbpRkEtfreSB2F4ThnvSVYfHLYzPG4ZD+eBjBthmHVffzJ9GS4ZT/wTOyfcb4sVODQxBlRVhYwmE2O77vQkkJ7lxulinBQx4oVNr2RUFIMkhMh97C4chddq/EB9j4EXPf0+L0OTzC0BJ3nxCSIG6lcAcb+y4ppDhG89Ohb1aVUeimNMMQ5r1ZVfmq7fhzu4XRlQG34gIUonHYwG4BJ6ZQyJlAb7OZxhcmCvU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199018)(36840700001)(46966006)(40470700004)(31686004)(82310400005)(82740400003)(36756003)(44832011)(8676002)(8936002)(5660300002)(2906002)(41300700001)(4326008)(70206006)(86362001)(70586007)(316002)(31696002)(40480700001)(36860700001)(110136005)(356005)(54906003)(81166007)(83380400001)(40460700003)(47076005)(6486002)(53546011)(107886003)(336012)(2616005)(478600001)(6506007)(6512007)(26005)(186003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 14:43:10.0252 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e8af2f2f-fcb3-4573-d12e-08db0dd0a083 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9121 X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/13/23 14:24, Tom Tromey wrote: > Luis> It is also a burden for reviewing. It doesn't seem like the kind > Luis> of thing people should be doing manually at this point in time. > > The ability to read the code and change one's style to adapt is a > quality signal to reviewers. However if that goes away it probably > won't be a huge loss. That's fair. But should we consider the current state of today's helper tools (auto-formatters, code review tools etc) from the perspective of lowering the bar to what is required for new contributors to volunteer some work to gdb? > > Luis> Yes, there is a gnu style there already, but we haven't decide if > Luis> it is good enough or not. > > IMO it definitely isn't but feel free to log your findings in the bug. > One of these days I'll dig up the counter-examples that I dislike and do > that myself as well. I've used clang-format for another project, and to be honest I didn't find much I couldn't adapt to/get used to. The worst so far seems to be the comment reflows. They don't always come out in the best way possible. But that may be due to our use of block comments. In terms of readability, one could argue some of the C++ constructs in the code aren't that obvious either. But they're convenient, so worth the effort to get over the syntax. > > Tom